Re: [PATCH v19 5/8] mm: introduce memfd_secret system call to create "secret" memory areas

2021-05-18 Thread Michal Hocko
On Tue 18-05-21 12:35:36, David Hildenbrand wrote: > On 18.05.21 12:31, Michal Hocko wrote: > > On Tue 18-05-21 12:06:42, David Hildenbrand wrote: > > > On 18.05.21 11:59, Michal Hocko wrote: > > > > On Sun 16-05-21 10:29:24, Mike Rapoport wrote: > > > >

Re: [PATCH v19 5/8] mm: introduce memfd_secret system call to create "secret" memory areas

2021-05-18 Thread Michal Hocko
On Tue 18-05-21 12:06:42, David Hildenbrand wrote: > On 18.05.21 11:59, Michal Hocko wrote: > > On Sun 16-05-21 10:29:24, Mike Rapoport wrote: > > > On Fri, May 14, 2021 at 11:25:43AM +0200, David Hildenbrand wrote: > > [...] > >

Re: [PATCH v19 5/8] mm: introduce memfd_secret system call to create "secret" memory areas

2021-05-18 Thread Michal Hocko
e it is quite unlikely to se ENOMEM from that path (it allocates small pages) but this can become quite sublte over time. Shouldn't this simply SIGBUS if it cannot manipulate the direct mapping regardless of the underlying reason for that? -- Michal Hocko SUSE Labs

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-16 Thread Michal Hocko
On Tue 16-02-21 08:25:39, James Bottomley wrote: > On Mon, 2021-02-15 at 20:20 +0100, Michal Hocko wrote: > [...] > > > > What kind of flags are we talking about and why would that be a > > > > problem with memfd_create interface? Could you be more specific > &g

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-15 Thread Michal Hocko
On Mon 15-02-21 10:14:43, James Bottomley wrote: > On Mon, 2021-02-15 at 10:13 +0100, Michal Hocko wrote: > > On Sun 14-02-21 11:21:02, James Bottomley wrote: > > > On Sun, 2021-02-14 at 10:58 +0100, David Hildenbrand wrote: > > > [...] > > > > &

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-15 Thread Michal Hocko
itional features and extend the API with flags > without causing anti-ioctl riots. I am sorry but I do not understand this argument. What kind of flags are we talking about and why would that be a problem with memfd_create interface? Could you be more specific please? -- Michal Hocko SUSE Labs __

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-12 Thread Michal Hocko
On Fri 12-02-21 00:59:29, Mike Rapoport wrote: > On Thu, Feb 11, 2021 at 01:30:42PM +0100, Michal Hocko wrote: [...] > > Have a look how hugetlb proliferates through our MM APIs. I strongly > > suspect this is strong signal that this won't be any different. > > > >

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-11 Thread Michal Hocko
but we have different thoughts about it ;-) Then you must be carrying a lot of implicit knowledge which I want you to document. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-11 Thread Michal Hocko
h -EINVAL". I think that the behavior should be really in sync with shmem semantic as much as possible. Most operations should simply work with an aditional direct map manipulation. There is no real reason to be special. Some functionality might be missing, e.g. hugetlb support but that has b

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-11 Thread Michal Hocko
On Thu 11-02-21 09:13:19, Mike Rapoport wrote: > On Tue, Feb 09, 2021 at 02:17:11PM +0100, Michal Hocko wrote: > > On Tue 09-02-21 11:09:38, Mike Rapoport wrote: [...] > > > Citing my older email: > > > > > > I've hesitated whether to conti

Re: [PATCH v17 00/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-09 Thread Michal Hocko
On Tue 09-02-21 17:17:22, David Hildenbrand wrote: > On 09.02.21 14:25, Michal Hocko wrote: > > On Tue 09-02-21 11:23:35, David Hildenbrand wrote: > > [...] > > > I am constantly trying to fight for making more stuff MOVABLE instead of > > > going into the ot

Re: [PATCH v17 00/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-09 Thread Michal Hocko
s documented with all the potential problems we have encountered over time and explicitly state which features are fully/partially incompatible. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an ema

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-09 Thread Michal Hocko
On Tue 09-02-21 11:09:38, Mike Rapoport wrote: > On Tue, Feb 09, 2021 at 09:47:08AM +0100, Michal Hocko wrote: > > On Mon 08-02-21 23:26:05, Mike Rapoport wrote: > > > On Mon, Feb 08, 2021 at 11:49:22AM +0100, Michal Hocko wrote: > > > > On Mon 08-02-21

Re: [PATCH v17 00/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-09 Thread Michal Hocko
On Tue 09-02-21 10:15:17, David Hildenbrand wrote: > On 09.02.21 09:59, Michal Hocko wrote: > > On Mon 08-02-21 22:38:03, David Hildenbrand wrote: > > > > > > > Am 08.02.2021 um 22:13 schrieb Mike Rapoport : > > > > > > > > On Mon, Feb

Re: [PATCH v17 00/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-09 Thread Michal Hocko
very careful when relying on CMA or movable zones. This is definitely worth a comment in the kernel command line parameter documentation. But this is not a new problem. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-09 Thread Michal Hocko
On Mon 08-02-21 23:26:05, Mike Rapoport wrote: > On Mon, Feb 08, 2021 at 11:49:22AM +0100, Michal Hocko wrote: > > On Mon 08-02-21 10:49:17, Mike Rapoport wrote: [...] > > > The file descriptor based memory has several advantages over the > > > "tradition

Re: [PATCH v17 08/10] PM: hibernate: disable when there are active secretmem users

2021-02-08 Thread Michal Hocko
, Michal Hocko wrote: > On Mon 08-02-21 12:26:31, David Hildenbrand wrote: > [...] > > My F33 system happily hibernates to disk, even with an application that > > succeeded in din doing an mlockall(). > > > > And it somewhat makes sense. Even my freshly-booted, idle F33 ha

Re: [PATCH v17 08/10] PM: hibernate: disable when there are active secretmem users

2021-02-08 Thread Michal Hocko
k whether the expectated mlock semantic really works for those. This should be documented at least. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH v17 08/10] PM: hibernate: disable when there are active secretmem users

2021-02-08 Thread Michal Hocko
On Mon 08-02-21 11:53:58, David Hildenbrand wrote: > On 08.02.21 11:51, Michal Hocko wrote: > > On Mon 08-02-21 11:32:11, David Hildenbrand wrote: > > > On 08.02.21 11:18, Michal Hocko wrote: > > > > On Mon 08-02-21 10:49:18, Mike Rapoport wrote:

Re: [PATCH v17 08/10] PM: hibernate: disable when there are active secretmem users

2021-02-08 Thread Michal Hocko
On Mon 08-02-21 11:32:11, David Hildenbrand wrote: > On 08.02.21 11:18, Michal Hocko wrote: > > On Mon 08-02-21 10:49:18, Mike Rapoport wrote: > > > From: Mike Rapoport > > > > > > It is unsafe to allow saving of secretmem areas to the hibernation > >

Re: [PATCH v17 07/10] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-08 Thread Michal Hocko
https://lore.kernel.org/linux-mm/213b4567-46ce-f116-9cdf-bbd0c884e...@linux.intel.com/ I have only glanced through the implementation and it looks sane. I will have a closer look later but this should be pretty simple with the proposed semantic. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH v17 08/10] PM: hibernate: disable when there are active secretmem users

2021-02-08 Thread Michal Hocko
; Prevent hibernation whenever there are active secret memory users. Does this feature need any special handling? As it is effectivelly unevictable memory then it should behave the same as other mlock, ramfs which should already disable hibernation as those cannot be swapped out, no? -- M

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-02-04 Thread Michal Hocko
On Thu 04-02-21 11:58:55, Mike Rapoport wrote: > On Wed, Feb 03, 2021 at 10:12:22AM +0100, Michal Hocko wrote: [...] > > Wrt to the specific syscall, please document why existing interfaces are > > not a good fit as well. It would be also great to describe interaction > >

Re: [PATCH v16 06/11] mm: introduce memfd_secret system call to create "secret" memory areas

2021-02-03 Thread Michal Hocko
ou do not support migration so no pages from movable zones should be allowed. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-02-03 Thread Michal Hocko
On Tue 02-02-21 10:55:40, James Bottomley wrote: > On Tue, 2021-02-02 at 20:15 +0200, Mike Rapoport wrote: > > On Tue, Feb 02, 2021 at 03:34:29PM +0100, David Hildenbrand wrote: > > > On 02.02.21 15:32, Michal Hocko wrote: > > > > On Tue 02-02-21 15:

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-02-03 Thread Michal Hocko
On Tue 02-02-21 21:10:40, Mike Rapoport wrote: > On Tue, Feb 02, 2021 at 02:27:14PM +0100, Michal Hocko wrote: > > On Tue 02-02-21 14:48:57, Mike Rapoport wrote: > > > On Tue, Feb 02, 2021 at 10:35:05AM +0100, Michal Hocko wrote: > > > > On Mon 01-02-21 0

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-02-02 Thread Michal Hocko
On Tue 02-02-21 15:26:20, David Hildenbrand wrote: > On 02.02.21 15:22, Michal Hocko wrote: > > On Tue 02-02-21 15:12:21, David Hildenbrand wrote: > > [...] > > > I think secretmem behaves much more like longterm GUP right now > > > ("unmigratable", &quo

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-02-02 Thread Michal Hocko
/limit it or > make it behave more like mlocked pages. I thought I have already asked but I must have forgotten. Is there any actual reason why the memory is not movable? Timing attacks? -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- lin

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-02-02 Thread Michal Hocko
). Another example is ramdisk or even tmpfs (with swap storage depleted or not configured). Both are PITA from the OOM POV but they are manageable if people are careful. If secretmem behaves along those existing models then we know what to expect at least. -- Mich

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-02-02 Thread Michal Hocko
On Tue 02-02-21 14:48:57, Mike Rapoport wrote: > On Tue, Feb 02, 2021 at 10:35:05AM +0100, Michal Hocko wrote: > > On Mon 01-02-21 08:56:19, James Bottomley wrote: > > > > I have also proposed potential ways out of this. Either the pool is not > > fixed sized and you ma

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-02-02 Thread Michal Hocko
On Mon 01-02-21 08:56:19, James Bottomley wrote: > On Fri, 2021-01-29 at 09:23 +0100, Michal Hocko wrote: > > On Thu 28-01-21 13:05:02, James Bottomley wrote: > > > Obviously the API choice could be revisited > > > but do you have anything to add over the previous discus

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-01-29 Thread Michal Hocko
On Fri 29-01-21 09:21:28, Mike Rapoport wrote: > On Thu, Jan 28, 2021 at 02:01:06PM +0100, Michal Hocko wrote: > > On Thu 28-01-21 11:22:59, Mike Rapoport wrote: > > > > > And hugetlb pools may be also depleted by anybody by calling > > > mmap(MAP_HUGETLB)

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-01-29 Thread Michal Hocko
ons would be that direct map would be handled on instantiation/tear down paths, migration would deal with the same (if possible). Other than that it would be mlock like. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lis

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-01-29 Thread Michal Hocko
On Thu 28-01-21 13:05:02, James Bottomley wrote: > On Thu, 2021-01-28 at 14:01 +0100, Michal Hocko wrote: [...] > > I am also still not sure why this whole thing is not just a > > ramdisk/ramfs which happens to unmap its pages from the direct > > map. Wouldn't that be a m

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-01-28 Thread Michal Hocko
On Thu 28-01-21 15:56:36, Cristopher Lameter wrote: > On Thu, 28 Jan 2021, Michal Hocko wrote: > > > > > If you kill the allocating process then yes, it would work, but your > > > > process might be the very last to be selected. > > > > > > OOMs are

Re: [PATCH v16 08/11] secretmem: add memcg accounting

2021-01-28 Thread Michal Hocko
On Thu 28-01-21 06:05:11, Shakeel Butt wrote: > On Wed, Jan 27, 2021 at 11:59 PM Michal Hocko wrote: > > > > On Wed 27-01-21 10:42:13, Roman Gushchin wrote: > > > On Tue, Jan 26, 2021 at 04:05:55PM +0100, Michal Hocko wrote: > > > > On Tue 26-01-21 14:48:38, Ma

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-01-28 Thread Michal Hocko
On Thu 28-01-21 13:28:10, Cristopher Lameter wrote: > On Thu, 28 Jan 2021, Michal Hocko wrote: > > > > So, if I understand your concerns correct this implementation has two > > > issues: > > > 1) allocation failure at page fault that causes unrecoverab

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-01-28 Thread Michal Hocko
On Thu 28-01-21 11:22:59, Mike Rapoport wrote: > On Tue, Jan 26, 2021 at 01:08:23PM +0100, Michal Hocko wrote: > > On Tue 26-01-21 12:56:48, David Hildenbrand wrote: > > > On 26.01.21 12:46, Michal Hocko wrote: > > > > On Thu 21-01-21 14:27:19, Mike Rapoport wrote:

Re: [PATCH v16 08/11] secretmem: add memcg accounting

2021-01-28 Thread Michal Hocko
On Wed 27-01-21 10:42:13, Roman Gushchin wrote: > On Tue, Jan 26, 2021 at 04:05:55PM +0100, Michal Hocko wrote: > > On Tue 26-01-21 14:48:38, Matthew Wilcox wrote: > > > On Mon, Jan 25, 2021 at 11:38:17PM +0200, Mike Rapoport wrote: > > > > I cannot use __GFP_AC

Re: [PATCH v16 08/11] secretmem: add memcg accounting

2021-01-26 Thread Michal Hocko
hey shouldn't be so special and they should live on unevistable LRU and get their stats automagically. I definitely do agree that this would be a better fit than NR_SLAB abuse. But considering that this is somehow even more special than mlock then a dedicated counter sounds as even better fit. -- Michal Ho

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-01-26 Thread Michal Hocko
On Tue 26-01-21 12:56:48, David Hildenbrand wrote: > On 26.01.21 12:46, Michal Hocko wrote: > > On Thu 21-01-21 14:27:19, Mike Rapoport wrote: > > > From: Mike Rapoport > > > > > > Removing a PAGE_SIZE page from the direct map every time such page is > &g

Re: [PATCH v16 07/11] secretmem: use PMD-size pages to amortize direct map fragmentation

2021-01-26 Thread Michal Hocko
he system. Now you could be less drastic and only make SIGBUS on fault but that would be still quite terrible. There is a very good reason why hugetlb implements is non-trivial reservation system to avoid exactly these problems. So unless I am really misreading the code Nacked-by: Michal Hocko That

Re: [PATCH v16 06/11] mm: introduce memfd_secret system call to create "secret" memory areas

2021-01-26 Thread Michal Hocko
On Tue 26-01-21 10:53:08, David Hildenbrand wrote: [...] > I assume you've seen the benchmark results provided by Xing Zhengjun > > https://lore.kernel.org/linux-mm/213b4567-46ce-f116-9cdf-bbd0c884e...@linux.intel.com/ I was not. Thanks for the pointer. I will have a look. -- Michal H

Re: [PATCH v16 06/11] mm: introduce memfd_secret system call to create "secret" memory areas

2021-01-26 Thread Michal Hocko
On Tue 26-01-21 11:20:11, Mike Rapoport wrote: > On Tue, Jan 26, 2021 at 10:00:13AM +0100, Michal Hocko wrote: > > On Tue 26-01-21 10:33:11, Mike Rapoport wrote: > > > On Tue, Jan 26, 2021 at 08:16:14AM +0100, Michal Hocko wrote: > > > > On Mon 25-01-21

Re: [PATCH v16 06/11] mm: introduce memfd_secret system call to create "secret" memory areas

2021-01-26 Thread Michal Hocko
On Tue 26-01-21 10:00:14, Michal Hocko wrote: > On Tue 26-01-21 10:33:11, Mike Rapoport wrote: > > On Tue, Jan 26, 2021 at 08:16:14AM +0100, Michal Hocko wrote: > > > On Mon 25-01-21 23:36:18, Mike Rapoport wrote: > > > > On Mon, Jan 25, 2021 at 06:01:

Re: [PATCH v16 08/11] secretmem: add memcg accounting

2021-01-26 Thread Michal Hocko
On Tue 26-01-21 10:56:54, Mike Rapoport wrote: > On Tue, Jan 26, 2021 at 08:31:42AM +0100, Michal Hocko wrote: > > On Mon 25-01-21 23:38:17, Mike Rapoport wrote: > > > On Mon, Jan 25, 2021 at 05:54:51PM +0100, Michal Hocko wrote: > > > > On Thu 21-01-21

Re: [PATCH v16 06/11] mm: introduce memfd_secret system call to create "secret" memory areas

2021-01-26 Thread Michal Hocko
On Tue 26-01-21 10:33:11, Mike Rapoport wrote: > On Tue, Jan 26, 2021 at 08:16:14AM +0100, Michal Hocko wrote: > > On Mon 25-01-21 23:36:18, Mike Rapoport wrote: > > > On Mon, Jan 25, 2021 at 06:01:22PM +0100, Michal Hocko wrote: > > > > On Thu 21-01-21

Re: [PATCH v16 08/11] secretmem: add memcg accounting

2021-01-26 Thread Michal Hocko
On Mon 25-01-21 23:38:17, Mike Rapoport wrote: > On Mon, Jan 25, 2021 at 05:54:51PM +0100, Michal Hocko wrote: > > On Thu 21-01-21 14:27:20, Mike Rapoport wrote: > > > From: Mike Rapoport > > > > > > Account memory consumed by secretmem to memcg. The account

Re: [PATCH v16 06/11] mm: introduce memfd_secret system call to create "secret" memory areas

2021-01-26 Thread Michal Hocko
On Mon 25-01-21 23:36:18, Mike Rapoport wrote: > On Mon, Jan 25, 2021 at 06:01:22PM +0100, Michal Hocko wrote: > > On Thu 21-01-21 14:27:18, Mike Rapoport wrote: > > > From: Mike Rapoport > > > > > > Introduce "memfd_secret" system call with the abi

Re: [PATCH v16 06/11] mm: introduce memfd_secret system call to create "secret" memory areas

2021-01-25 Thread Michal Hocko
, MAP_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); I do not see any access control or permission model for this feature. Is this feature generally safe to anybody? -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH v16 08/11] secretmem: add memcg accounting

2021-01-25 Thread Michal Hocko
hen this is not a slab owned memory? Why do you use the kmem accounting API when __GFP_ACCOUNT should give you the same without this details? -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH v4 3/5] mm: Teach pfn_to_online_page() about ZONE_DEVICE section collisions

2021-01-20 Thread Michal Hocko
tion() for a full ZONE_DEVICE section returns > false. > > Because the collision case is rare, and for simplicity, the > SECTION_TAINT_ZONE_DEVICE flag is never cleared once set. > > Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > Cc: Andrew Morton > Reported-by: Mi

Re: [PATCH v4 2/5] mm: Teach pfn_to_online_page() to consider subsection validity

2021-01-20 Thread Michal Hocko
tially offline memory (e.g. part of ZONE_DEVICE) then pfn_to_online_page would lead to a false positive on some pfns. Fix this by adding pfn_section_valid check which is subsection aware. " > > Fixes: b13bc35193d9 ("mm/hotplug: invalid PFNs from pfn_to_online_page()") >

Re: [PATCH v4 1/5] mm: Move pfn_to_online_page() out of line

2021-01-20 Thread Michal Hocko
On Wed 13-01-21 16:43:16, Dan Williams wrote: > pfn_to_online_page() is already too large to be a macro or an inline > function. In anticipation of further logic changes / growth, move it out > of line. > > No functional change, just code movement. > > Reported-by: Michal

Re: [PATCH v2 1/3] arm64/numa: export memory_add_physaddr_to_nid as EXPORT_SYMBOL_GPL

2020-07-07 Thread Michal Hocko
ory_add_physaddr_to_nid); Does it make sense to export a noop function? Wouldn't make more sense to simply make it static inline somewhere in a header? I haven't checked whether there is an easy way to do that sanely bu this just hit my eyes. -- Michal Hocko SUSE Labs _

Re: [PATCH v2 3/3] mm/memory_hotplug: fix unpaired mem_hotplug_begin/done

2020-07-07 Thread Michal Hocko
10/0xfe0 [dax_pmem] > > Fixes: f1037ec0cc8a ("mm/memory_hotplug: fix remove_memory() lockdep splat") > Cc: sta...@vger.kernel.org # v5.6+ > Signed-off-by: Jia He Ups, I have missed that when reviewing that commit. Thanks for catching this up! Acked-by: Michal Hocko > ---

Re: [PATCH v5] mm/memory_hotplug: refrain from adding memory into an impossible node

2020-04-21 Thread Michal Hocko
On Tue 21-04-20 00:14:43, Verma, Vishal L wrote: > On Fri, 2020-04-17 at 08:38 +0200, Michal Hocko wrote: > > On Thu 16-04-20 16:54:38, Vishal Verma wrote: > > > A misbehaving qemu created a situation where the ACPI SRAT table > > > advertised one fewer proximity doma

Re: [PATCH v5] mm/memory_hotplug: refrain from adding memory into an impossible node

2020-04-17 Thread Michal Hocko
kthread+0x120/0x140 > [ +0.000508] ? kthread_create_on_node+0x60/0x60 > [ +0.000706] ret_from_fork+0x3a/0x50 > > Add a check in the add_memory path to fail if the node to which we > are adding memory is in the node_possible_map > > Cc: Michal Hocko > Cc: David Hildenbr

Re: [PATCH v3] mm/memory_hotplug: refrain from adding memory into an impossible node

2020-04-16 Thread Michal Hocko
On Wed 15-04-20 20:32:00, Verma, Vishal L wrote: > On Wed, 2020-04-15 at 12:43 +0200, Michal Hocko wrote: > > On Tue 14-04-20 17:58:12, Vishal Verma wrote: > > [...] > > > +static int check_hotplug_node(int nid) > > > +{ > > > + int alt_

Re: [PATCH v3] mm/memory_hotplug: refrain from adding memory into an impossible node

2020-04-15 Thread Michal Hocko
we try to be clever and change the node id requested by the caller? I would just stick with node_possible check and be done with this. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-27 Thread Michal Hocko
On Wed 26-06-19 09:14:32, Dan Williams wrote: > On Tue, Jun 25, 2019 at 10:46 PM Michal Hocko wrote: > > > > On Tue 25-06-19 12:52:18, Dan Williams wrote: > > [...] > > > > Documentation/process/stable-api-nonsense.rst > > > > > > That d

Re: [PATCH 06/25] mm: export alloc_pages_vma

2019-06-26 Thread Michal Hocko
On Wed 26-06-19 14:27:05, Christoph Hellwig wrote: > nouveau is currently using this through an odd hmm wrapper, and I plan > to switch it to the real thing later in this series. > > Signed-off-by: Christoph Hellwig > Reviewed-by: John Hubbard Acked-by: Michal Hocko Thank

Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-25 Thread Michal Hocko
xported regardless of that document. Can you point me to any specific example where this would be the case for the core kernel symbols please? -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mail

Re: [PATCH 18/22] mm: mark DEVICE_PUBLIC as broken

2019-06-25 Thread Michal Hocko
to use it. So it really > does seem safe to remove, although of course it's good to start with > BROKEN and see if anyone pops up and complains. Well, I do not really see much of a difference. Preserving an unused code which doesn't have any user in sight just adds a maintenance burden whether the code depends on BROKEN or not. We can always revert patches which remove the code once a real user shows up. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-25 Thread Michal Hocko
uld go with consistency and export the same way we do with other functions. Also we do not want people to reinvent this API and screw that like we have seen in other cases when external modules try reimplement core functionality themselves. Thanks! -- Michal Hocko SUSE Labs __

Re: [PATCH 04/22] mm: don't clear ->mapping in hmm_devmem_free

2019-06-20 Thread Michal Hocko
data; > > - page->mapping = NULL; > - > devmem->ops->free(devmem, page); > } > > -- > 2.20.1 -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 03/22] mm: remove hmm_devmem_add_resource

2019-06-20 Thread Michal Hocko
directly now that we've simplified the API for it. > > Signed-off-by: Christoph Hellwig Acked-by: Michal Hocko > --- > include/linux/hmm.h | 3 --- > mm/hmm.c| 54 - > 2 files changed, 57 deletions(-) > > diff --git a

Re: [PATCH 18/22] mm: mark DEVICE_PUBLIC as broken

2019-06-20 Thread Michal Hocko
emove all the DEVICE_PUBLIC code. > Signed-off-by: Christoph Hellwig Anyway Acked-by: Michal Hocko > --- > mm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 0d2ba7e1f43e..406fa45e9ecc 100644 > --- a/mm/Kconfig > +++ b/mm/

Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-20 Thread Michal Hocko
> } > +EXPORT_SYMBOL_GPL(alloc_pages_vma); All allocator exported symbols are EXPORT_SYMBOL, what is a reason to have this one special? -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [v6 2/3] mm/hotplug: make remove_memory() interface useable

2019-05-28 Thread Michal Hocko
ooking closer acpi_memory_remove_memory and few others already do use __remove_memory instead of remove_memory so this is good to go. I really hate how we had to BUG in remove_memory as well so this is definitely a good change. > Signed-off-by: Pavel Tatashin > Reviewed-by: David Hildenbran

Re: NULL pointer dereference during memory hotremove

2019-05-20 Thread Michal Hocko
On Fri 17-05-19 13:33:25, Pavel Tatashin wrote: > On Fri, May 17, 2019 at 1:24 PM Pavel Tatashin > wrote: > > > > On Fri, May 17, 2019 at 1:22 PM Pavel Tatashin > > wrote: > > > > > > On Fri, May 17, 2019 at 10:38 AM Michal Hocko wrote: > > >

Re: NULL pointer dereference during memory hotremove

2019-05-17 Thread Michal Hocko
On Fri 17-05-19 10:20:38, Pavel Tatashin wrote: > This panic is unrelated to circular lock issue that I reported in a > separate thread, that also happens during memory hotremove. > > xakep ~/x/linux$ git describe > v5.1-12317-ga6a4b66bd8f4 Does this happen on 5.0 as well? -- Mi

Re: [PATCH] arm64: configurable sparsemem section size

2019-04-25 Thread Michal Hocko
to be used then the underlying question remains. If there is no real reason to use large memsections then it would be better to use smaller ones. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH] arm64: configurable sparsemem section size

2019-04-25 Thread Michal Hocko
On Thu 25-04-19 16:31:38, Will Deacon wrote: > On Thu, Apr 25, 2019 at 05:25:50PM +0200, Michal Hocko wrote: > > On Tue 23-04-19 16:38:43, Pavel Tatashin wrote: > > > sparsemem section size determines the maximum size and alignment that > > > is allowed to offline/onli

Re: [PATCH] arm64: configurable sparsemem section size

2019-04-25 Thread Michal Hocko
ction size is 1G, and devdax must > have 2M label section, the first 1G is always missed when device is > attached, because it is not 1G aligned. > > Allow, better flexibility by making section size configurable. Is there any inherent reason (64k page size?) that enforces such a

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-28 Thread Michal Hocko
On Thu 28-03-19 14:38:15, David Hildenbrand wrote: > On 27.03.19 17:13, Michal Hocko wrote: [...] > > People are asking for a smaller memory hotplug granularity for other > > usecases (e.g. memory ballooning into VMs) which are quite dubious to > > be honest and not real

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-27 Thread Michal Hocko
On Tue 26-03-19 17:20:41, Dan Williams wrote: > On Tue, Mar 26, 2019 at 1:04 AM Michal Hocko wrote: > > > > On Mon 25-03-19 13:03:47, Dan Williams wrote: > > > On Mon, Mar 25, 2019 at 3:20 AM Michal Hocko wrote: > > [...] > > > > > User-defined

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-26 Thread Michal Hocko
On Mon 25-03-19 13:03:47, Dan Williams wrote: > On Mon, Mar 25, 2019 at 3:20 AM Michal Hocko wrote: [...] > > > User-defined memory namespaces have this problem, but 2MB is the > > > default alignment and is sufficient for most uses. > > > > What does pre

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-25 Thread Michal Hocko
On Mon 25-03-19 10:28:00, Jeff Moyer wrote: > Michal Hocko writes: > > >> > and I would like to know that you are > >> > not just shifting the problem to a smaller unit and a new/creative HW > >> > will force us to go even more complicated. > >

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-25 Thread Michal Hocko
On Fri 22-03-19 11:32:11, Dan Williams wrote: > On Fri, Mar 22, 2019 at 11:06 AM Michal Hocko wrote: > > > > On Fri 22-03-19 09:57:54, Dan Williams wrote: > > > Changes since v4 [1]: > > > - Given v4 was from March of 2017 the bulk of the changes result from &g

Re: [PATCH v5 00/10] mm: Sub-section memory hotplug support

2019-03-22 Thread Michal Hocko
users for now. Does this mean that pfn_valid is more expensive now? How much? For any pfn? Also what about the section life time? Who is removing section now? I will probably have much more question, but it's friday and I am mostly offline already. I would just like to hear much more about the

Re: [Lsf-pc] [LSF/MM TOPIC] The end of the DAX experiment

2019-02-14 Thread Michal Hocko
On Wed 06-02-19 13:12:59, Dan Williams wrote: [...] > * Userfaultfd for file-backed mappings and DAX I assume that other topics are meant to be FS track but this one is MM, right? -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvd

Re: [PATCH 5/5] dax: "Hotplug" persistent memory for use like normal RAM

2019-01-28 Thread Michal Hocko
tion. I am not sure I understand. Do you mean to clear HWPoison when the memory is hotadded (add_pages) or onlined (resp. move_pfn_range_to_zone)? -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 2/4] mm/memory-hotplug: allow memory resources to be children

2019-01-23 Thread Michal Hocko
d APIs yet it allows to use nvdimms as a memory transparently. All future policies are to be defined by the userspace and I like that. I was especially astonished by the sheer size of the driver and changes it required to achieve that. Really nice! > Cc: Dan Williams > Cc: Dave Jiang > Cc: Ross

Re: [mm PATCH v6 6/7] mm: Add reserved flag setting to set_page_links

2018-12-05 Thread Michal Hocko
g that is not really needed. Based on that I am not going to waste my time on other patches in this series to review and give feedback which might be ignored again. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [mm PATCH v5 0/7] Deferred page init improvements

2018-11-15 Thread Michal Hocko
On Thu 15-11-18 08:02:33, Alexander Duyck wrote: > On 11/15/2018 12:10 AM, Michal Hocko wrote: > > On Wed 14-11-18 16:50:23, Alexander Duyck wrote: [...] > > > I plan to remove it, but don't think I can get to it in this patch set. > > > > What I am trying to argue

Re: [mm PATCH v5 0/7] Deferred page init improvements

2018-11-15 Thread Michal Hocko
On Wed 14-11-18 16:50:23, Alexander Duyck wrote: > > > On 11/14/2018 7:07 AM, Michal Hocko wrote: > > On Mon 05-11-18 13:19:25, Alexander Duyck wrote: > > > This patchset is essentially a refactor of the page initialization logic > > > that is meant to pr

Re: [mm PATCH v5 0/7] Deferred page init improvements

2018-11-14 Thread Michal Hocko
On Wed 14-11-18 19:12:53, Pavel Tatashin wrote: > On 18-11-14 16:07:42, Michal Hocko wrote: > > On Mon 05-11-18 13:19:25, Alexander Duyck wrote: > > > This patchset is essentially a refactor of the page initialization logic > > > that is meant to provide for better

Re: [mm PATCH v5 0/7] Deferred page init improvements

2018-11-14 Thread Michal Hocko
out it. We should just remove it rather than make the code more complex. I fell more and more guilty to add there actually. -- Michal Hocko SUSE Labs ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-30 Thread Michal Hocko
On Mon 29-10-18 23:55:12, Dan Williams wrote: > On Mon, Oct 29, 2018 at 11:29 PM Michal Hocko wrote: > > > > On Mon 29-10-18 12:59:11, Alexander Duyck wrote: > > > On Mon, 2018-10-29 at 19:18 +0100, Michal Hocko wrote: > [..] > > > The patches Andrew pus

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-30 Thread Michal Hocko
On Mon 29-10-18 12:59:11, Alexander Duyck wrote: > On Mon, 2018-10-29 at 19:18 +0100, Michal Hocko wrote: [...] I will try to get to your other points later. > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 89d2a2ab3fe6..048e4cc72fdf 100644 > > --- a/mm/page

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-29 Thread Michal Hocko
On Mon 29-10-18 10:42:33, Alexander Duyck wrote: > On Mon, 2018-10-29 at 18:24 +0100, Michal Hocko wrote: > > On Mon 29-10-18 10:01:28, Alexander Duyck wrote: [...] > > > So there end up being a few different issues with constructors. First > > > in my mind is that it

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-29 Thread Michal Hocko
On Mon 29-10-18 10:34:22, Dan Williams wrote: > On Mon, Oct 29, 2018 at 10:24 AM Michal Hocko wrote: > > > > On Mon 29-10-18 10:01:28, Alexander Duyck wrote: > > > On Mon, 2018-10-29 at 17:35 +0100, Michal Hocko wrote: > [..] > > > > You are already doing p

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-29 Thread Michal Hocko
On Mon 29-10-18 10:01:28, Alexander Duyck wrote: > On Mon, 2018-10-29 at 17:35 +0100, Michal Hocko wrote: > > On Mon 29-10-18 08:59:34, Alexander Duyck wrote: [...] > > > So for example the call "online_pages_range" doesn't invoke the > > > online_page_callb

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-29 Thread Michal Hocko
On Mon 29-10-18 08:59:34, Alexander Duyck wrote: > On Mon, 2018-10-29 at 15:12 +0100, Michal Hocko wrote: > > On Wed 17-10-18 08:02:20, Alexander Duyck wrote: > > > On 10/17/2018 12:52 AM, Michal Hocko wrote: > > > > On Thu 11-10-18 10:38:39, Alexander Duyck wrote: &

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-29 Thread Michal Hocko
On Mon 29-10-18 08:49:46, Dan Williams wrote: > On Wed, Oct 17, 2018 at 8:02 AM Alexander Duyck > wrote: > > > > On 10/17/2018 12:52 AM, Michal Hocko wrote: > > > On Thu 11-10-18 10:38:39, Alexander Duyck wrote: > > >> On 10/11/2018 1:55 AM, Michal Hocko

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-29 Thread Michal Hocko
On Wed 17-10-18 08:02:20, Alexander Duyck wrote: > On 10/17/2018 12:52 AM, Michal Hocko wrote: > > On Thu 11-10-18 10:38:39, Alexander Duyck wrote: > > > On 10/11/2018 1:55 AM, Michal Hocko wrote: > > > > On Wed 10-10-18 20:52:42, Michal Hocko wrote: > >

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-17 Thread Michal Hocko
On Thu 11-10-18 10:38:39, Alexander Duyck wrote: > On 10/11/2018 1:55 AM, Michal Hocko wrote: > > On Wed 10-10-18 20:52:42, Michal Hocko wrote: > > [...] > > > My recollection was that we do clear the reserved bit in > > > move_pfn_range_to_zone and w

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-10 Thread Michal Hocko
On Wed 10-10-18 10:39:01, Alexander Duyck wrote: > On 10/10/2018 10:24 AM, Michal Hocko wrote: [...] > > I thought I have already made it clear that these zone device hacks are > > not acceptable to the generic hotplug code. If the current reserve bit > > handling is not

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-10 Thread Michal Hocko
On Wed 10-10-18 10:39:01, Alexander Duyck wrote: > > > On 10/10/2018 10:24 AM, Michal Hocko wrote: > > On Wed 10-10-18 09:39:08, Alexander Duyck wrote: > > > On 10/10/2018 2:58 AM, Michal Hocko wrote: > > > > On Tue 09-10-18 13:26:41, Alexander Duyck wrote: &

  1   2   >