Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-08 Thread Johannes Thumshirn
On Tue, Mar 06, 2018 at 08:52:21AM -0800, Dan Williams wrote: > > Oh, Johannes I noticed that here is one stray one still in > > drivers/acpi/nfit/mce.c. Do you mind pulling it into your patch to keep the > > drivers/acpi/nfit/* changes together? > > I'll fix this locally. Sorry for the late

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-06 Thread Dan Williams
On Mon, Mar 5, 2018 at 8:06 PM, Ross Zwisler wrote: > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: >> Dynamic debug can be instructed to add the function name to the debug >> output using the +f switch, so there is no need for the nfit module

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Ross Zwisler
On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Ross Zwisler
On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Dan Williams
On Mon, Mar 5, 2018 at 10:01 AM, Ross Zwisler wrote: > On Mon, Mar 05, 2018 at 09:53:47AM -0800, Dan Williams wrote: >> On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler >> wrote: >> > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Ross Zwisler
On Mon, Mar 05, 2018 at 09:53:47AM -0800, Dan Williams wrote: > On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler > wrote: > > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > >> Dynamic debug can be instructed to add the function name to the debug >

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Dan Williams
On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler wrote: > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: >> Dynamic debug can be instructed to add the function name to the debug >> output using the +f switch, so there is no need for the nfit module

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Ross Zwisler
On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this

[PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-02 Thread Johannes Thumshirn
Dynamic debug can be instructed to add the function name to the debug output using the +f switch, so there is no need for the nfit module to do it again. If a user decides to add the +f switch for nfit's dynamic debug this results in double prints of the function name like the following: [