Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-09 Thread Jens Axboe
On 3/9/18 9:35 AM, Ross Zwisler wrote: > On Fri, Mar 09, 2018 at 08:38:57AM -0700, Jens Axboe wrote: >> On 3/9/18 8:38 AM, Jens Axboe wrote: >>> On 3/8/18 5:20 PM, Ross Zwisler wrote: This has gotten Reviewed-by tags from Christoph and Ming Lei. Al, are you the right person to merge

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-09 Thread Ross Zwisler
On Fri, Mar 09, 2018 at 08:38:57AM -0700, Jens Axboe wrote: > On 3/9/18 8:38 AM, Jens Axboe wrote: > > On 3/8/18 5:20 PM, Ross Zwisler wrote: > >> This has gotten Reviewed-by tags from Christoph and Ming Lei. > >> > >> Al, are you the right person to merge this? Or is the correct person Jens, >

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-09 Thread Jens Axboe
On 3/9/18 8:38 AM, Jens Axboe wrote: > On 3/8/18 5:20 PM, Ross Zwisler wrote: >> This has gotten Reviewed-by tags from Christoph and Ming Lei. >> >> Al, are you the right person to merge this? Or is the correct person Jens, >> whom I accidentally didn't include when I sent this out? >> >> Just

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-09 Thread Jens Axboe
On 3/8/18 5:20 PM, Ross Zwisler wrote: > This has gotten Reviewed-by tags from Christoph and Ming Lei. > > Al, are you the right person to merge this? Or is the correct person Jens, > whom I accidentally didn't include when I sent this out? > > Just wanted to make sure this got merged, and to

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-03-08 Thread Ross Zwisler
This has gotten Reviewed-by tags from Christoph and Ming Lei. Al, are you the right person to merge this? Or is the correct person Jens, whom I accidentally didn't include when I sent this out? Just wanted to make sure this got merged, and to see whether it was targeting v4.16 or v4.17.

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-02-21 Thread Ming Lei
On Tue, Feb 13, 2018 at 7:05 AM, Ross Zwisler wrote: > The following commit: > > commit aa4d86163e4e ("block: loop: switch to VFS ITER_BVEC") > > replaced __do_lo_send_write(), which used ITER_KVEC iterators, with > lo_write_bvec() which uses ITER_BVEC iterators. In

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-02-13 Thread Dan Williams
On Tue, Feb 13, 2018 at 11:22 AM, Ross Zwisler wrote: > On Tue, Feb 13, 2018 at 03:54:04PM +0100, Christoph Hellwig wrote: >> Looks good: >> >> Reviewed-by: Christoph Hellwig >> >> Can you wire up your test cases for blktests? > > Is blktests really the

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-02-13 Thread Ross Zwisler
On Tue, Feb 13, 2018 at 03:54:04PM +0100, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig > > Can you wire up your test cases for blktests? Is blktests really the right place for this test? This failure is highly dependent on the configuration of the

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-02-13 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig Can you wire up your test cases for blktests? ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

[PATCH] loop: Fix lost writes caused by missing flag

2018-02-12 Thread Ross Zwisler
The following commit: commit aa4d86163e4e ("block: loop: switch to VFS ITER_BVEC") replaced __do_lo_send_write(), which used ITER_KVEC iterators, with lo_write_bvec() which uses ITER_BVEC iterators. In this change, though, the WRITE flag was lost: - iov_iter_kvec(, ITER_KVEC | WRITE, ,