Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-11 Thread Jan Kara
On Fri 08-09-17 11:39:13, Ted Tso wrote: > On Fri, Sep 08, 2017 at 09:25:43AM +1000, Dave Chinner wrote: > > > Okay, so other ideas (which you have also probably already though of) > > > include: > > > > > > 1) Just return -EBUSY if anyone tries to change the DAX flag of an inode > > > with > >

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-08 Thread Theodore Ts'o
On Fri, Sep 08, 2017 at 09:25:43AM +1000, Dave Chinner wrote: > > Okay, so other ideas (which you have also probably already though of) > > include: > > > > 1) Just return -EBUSY if anyone tries to change the DAX flag of an inode > > with > > open mappings or any open file handles. > > You

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-08 Thread Jan Kara
On Fri 08-09-17 09:25:43, Dave Chinner wrote: > On Thu, Sep 07, 2017 at 04:19:00PM -0600, Ross Zwisler wrote: > > On Fri, Sep 08, 2017 at 08:12:01AM +1000, Dave Chinner wrote: > > > On Thu, Sep 07, 2017 at 03:51:48PM -0600, Ross Zwisler wrote: > > > > On Thu, Sep 07, 2017 at 03:26:10PM -0600,

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-07 Thread Dave Chinner
On Thu, Sep 07, 2017 at 04:19:00PM -0600, Ross Zwisler wrote: > On Fri, Sep 08, 2017 at 08:12:01AM +1000, Dave Chinner wrote: > > On Thu, Sep 07, 2017 at 03:51:48PM -0600, Ross Zwisler wrote: > > > On Thu, Sep 07, 2017 at 03:26:10PM -0600, Andreas Dilger wrote: > > > > However, I wonder if this

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-07 Thread Ross Zwisler
On Fri, Sep 08, 2017 at 08:12:01AM +1000, Dave Chinner wrote: > On Thu, Sep 07, 2017 at 03:51:48PM -0600, Ross Zwisler wrote: > > On Thu, Sep 07, 2017 at 03:26:10PM -0600, Andreas Dilger wrote: > > > However, I wonder if this could > > > be prevented at runtime, and only allow S_DAX to be set when

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-07 Thread Dave Chinner
On Thu, Sep 07, 2017 at 03:51:48PM -0600, Ross Zwisler wrote: > On Thu, Sep 07, 2017 at 03:26:10PM -0600, Andreas Dilger wrote: > > However, I wonder if this could > > be prevented at runtime, and only allow S_DAX to be set when the inode is > > first instantiated, and wouldn't be allowed to

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-07 Thread Ross Zwisler
On Thu, Sep 07, 2017 at 03:26:10PM -0600, Andreas Dilger wrote: > On Sep 7, 2017, at 3:13 PM, Ross Zwisler wrote: > > > > On Thu, Sep 07, 2017 at 01:54:45PM -0700, Dan Williams wrote: > >> On Wed, Sep 6, 2017 at 10:07 AM, Ross Zwisler > >>

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-07 Thread Ross Zwisler
On Thu, Sep 07, 2017 at 01:54:45PM -0700, Dan Williams wrote: > On Wed, Sep 6, 2017 at 10:07 AM, Ross Zwisler > wrote: > > On Tue, Sep 05, 2017 at 09:12:35PM -0500, Eric Sandeen wrote: > >> On 9/5/17 5:35 PM, Ross Zwisler wrote: > >> > The original intent of this

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-06 Thread Ross Zwisler
On Tue, Sep 05, 2017 at 09:12:35PM -0500, Eric Sandeen wrote: > On 9/5/17 5:35 PM, Ross Zwisler wrote: > > The original intent of this series was to add a per-inode DAX flag to ext4 > > so that it would be consistent with XFS. In my travels I found and fixed > > several related issues in both

Re: [PATCH 0/9] add ext4 per-inode DAX flag

2017-09-05 Thread Eric Sandeen
On 9/5/17 5:35 PM, Ross Zwisler wrote: > The original intent of this series was to add a per-inode DAX flag to ext4 > so that it would be consistent with XFS. In my travels I found and fixed > several related issues in both ext4 and XFS. Hi Ross - hch had a lot of reasons to nuke the dax flag

[PATCH 0/9] add ext4 per-inode DAX flag

2017-09-05 Thread Ross Zwisler
The original intent of this series was to add a per-inode DAX flag to ext4 so that it would be consistent with XFS. In my travels I found and fixed several related issues in both ext4 and XFS. I'm not fully happy with the ways that ext4 DAX interacts with conflicting features (journaling, inline