Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Dave Jiang
On 11/27/18 1:10 PM, Mimi Zohar wrote: > On Tue, 2018-11-27 at 11:48 -0800, Dan Williams wrote: > >> I was thinking that the generic-length *is* the format. This does not >> work for ecyptfs because it has that: >> >> payload_datalen = sizeof(struct ecryptfs_auth_tok); >> >> ...detail that i

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Mimi Zohar
On Tue, 2018-11-27 at 11:48 -0800, Dan Williams wrote: > I was thinking that the generic-length *is* the format. This does not > work for ecyptfs because it has that: > > payload_datalen = sizeof(struct ecryptfs_auth_tok); > > ...detail that is ecryptfs specific. For nvdimm the only detail o

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 11:35 AM Mimi Zohar wrote: > > On Tue, 2018-11-27 at 11:10 -0800, Dan Williams wrote: > > On Tue, Nov 27, 2018 at 10:24 AM Mimi Zohar wrote: > > > > > > On Tue, 2018-11-27 at 09:20 -0700, Dave Jiang wrote: > > > > > > > > On 11/27/18 12:20 AM, Dan Williams wrote: > > > > >

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Mimi Zohar
On Tue, 2018-11-27 at 11:10 -0800, Dan Williams wrote: > On Tue, Nov 27, 2018 at 10:24 AM Mimi Zohar wrote: > > > > On Tue, 2018-11-27 at 09:20 -0700, Dave Jiang wrote: > > > > > > On 11/27/18 12:20 AM, Dan Williams wrote: > > > > On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: > > > >> > > > >>

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 10:24 AM Mimi Zohar wrote: > > On Tue, 2018-11-27 at 09:20 -0700, Dave Jiang wrote: > > > > On 11/27/18 12:20 AM, Dan Williams wrote: > > > On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: > > >> > > >> Adding nvdimm key format type to encrypted keys in order to limit the

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Mimi Zohar
On Tue, 2018-11-27 at 09:20 -0700, Dave Jiang wrote: > > On 11/27/18 12:20 AM, Dan Williams wrote: > > On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: > >> > >> Adding nvdimm key format type to encrypted keys in order to limit the size > > > > s/Adding/Add an/ > > > >> of the key to 32-bytes.

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-27 Thread Dave Jiang
On 11/27/18 12:20 AM, Dan Williams wrote: > On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: >> >> Adding nvdimm key format type to encrypted keys in order to limit the size > > s/Adding/Add an/ > >> of the key to 32-bytes. >> >> Signed-off-by: Dave Jiang >> --- >> security/keys/encrypted-k

Re: [PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-26 Thread Dan Williams
On Fri, Nov 9, 2018 at 2:13 PM Dave Jiang wrote: > > Adding nvdimm key format type to encrypted keys in order to limit the size s/Adding/Add an/ > of the key to 32-bytes. > > Signed-off-by: Dave Jiang > --- > security/keys/encrypted-keys/encrypted.c | 29 - > 1 fi

[PATCH 01/11] keys-encrypted: add nvdimm key format type to encrypted keys

2018-11-09 Thread Dave Jiang
Adding nvdimm key format type to encrypted keys in order to limit the size of the key to 32bytes. Signed-off-by: Dave Jiang --- security/keys/encrypted-keys/encrypted.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/security/keys/encrypted-ke