Re: [PATCH 1/9] iomap: Fix misplaced page flushing

2020-08-27 Thread Christoph Hellwig
On Mon, Aug 24, 2020 at 03:55:02PM +0100, Matthew Wilcox (Oracle) wrote: > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index bcfc288dba3f..cffd575e57b6 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -715,6 +715,7 @@ iomap_write_end_inline(struct inode *

Re: [PATCH 1/9] iomap: Fix misplaced page flushing

2020-08-25 Thread Darrick J. Wong
On Mon, Aug 24, 2020 at 03:55:02PM +0100, Matthew Wilcox (Oracle) wrote: > If iomap_unshare_actor() unshares to an inline iomap, the page was > not being flushed. block_write_end() and __iomap_write_end() already > contain flushes, so adding it to iomap_write_end_inline() seems like > the best pla

Re: [PATCH 1/9] iomap: Fix misplaced page flushing

2020-08-24 Thread Dave Chinner
On Mon, Aug 24, 2020 at 03:55:02PM +0100, Matthew Wilcox (Oracle) wrote: > If iomap_unshare_actor() unshares to an inline iomap, the page was > not being flushed. block_write_end() and __iomap_write_end() already > contain flushes, so adding it to iomap_write_end_inline() seems like > the best pla

[PATCH 1/9] iomap: Fix misplaced page flushing

2020-08-24 Thread Matthew Wilcox (Oracle)
If iomap_unshare_actor() unshares to an inline iomap, the page was not being flushed. block_write_end() and __iomap_write_end() already contain flushes, so adding it to iomap_write_end_inline() seems like the best place. That means we can remove it from iomap_write_actor(). Signed-off-by: Matthe