Re: [PATCH 10/22] memremap: add a migrate callback to struct dev_pagemap_ops

2019-06-14 Thread Christoph Hellwig
On Thu, Jun 13, 2019 at 04:42:07PM -0700, Ralph Campbell wrote: > This needs to either initialize "page" or be changed to "vmf->page". > Otherwise, it is a NULL pointer dereference. Thanks, fixed. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org

Re: [PATCH 10/22] memremap: add a migrate callback to struct dev_pagemap_ops

2019-06-13 Thread Ralph Campbell
On 6/13/19 2:43 AM, Christoph Hellwig wrote: This replaces the hacky ->fault callback, which is currently directly called from common code through a hmm specific data structure as an exercise in layering violations. Signed-off-by: Christoph Hellwig --- include/linux/hmm.h | 6 --

[PATCH 10/22] memremap: add a migrate callback to struct dev_pagemap_ops

2019-06-13 Thread Christoph Hellwig
This replaces the hacky ->fault callback, which is currently directly called from common code through a hmm specific data structure as an exercise in layering violations. Signed-off-by: Christoph Hellwig --- include/linux/hmm.h | 6 -- include/linux/memremap.h | 6 ++