Re: [PATCH 17/21] mm: Change return values of finish_mkwrite_fault()

2016-11-15 Thread Kirill A. Shutemov
On Fri, Nov 04, 2016 at 05:25:13AM +0100, Jan Kara wrote: > Currently finish_mkwrite_fault() returns 0 when PTE got changed before > we acquired PTE lock and VM_FAULT_WRITE when we succeeded in modifying > the PTE. This is somewhat confusing since 0 generally means success, it > is also

[PATCH 17/21] mm: Change return values of finish_mkwrite_fault()

2016-11-03 Thread Jan Kara
Currently finish_mkwrite_fault() returns 0 when PTE got changed before we acquired PTE lock and VM_FAULT_WRITE when we succeeded in modifying the PTE. This is somewhat confusing since 0 generally means success, it is also inconsistent with finish_fault() which returns 0 on success. Change

[PATCH 17/21] mm: Change return values of finish_mkwrite_fault()

2016-11-01 Thread Jan Kara
Currently finish_mkwrite_fault() returns 0 when PTE got changed before we acquired PTE lock and VM_FAULT_WRITE when we succeeded in modifying the PTE. This is somewhat confusing since 0 generally means success, it is also inconsistent with finish_fault() which returns 0 on success. Change