Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-03-05 Thread Ross Zwisler
On Tue, Feb 06, 2018 at 03:19:15PM -0800, Darrick J. Wong wrote: <> > The last time I paid much attention to DAX was the thread "re-enable XFS > per-inode DAX"[1] last September. Motivating me to merge anything else > into DAX involves convincing me that we (mm, fs, dax developers) have > some

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-06 Thread Dan Williams
On Tue, Feb 6, 2018 at 3:19 PM, Darrick J. Wong wrote: > On Tue, Feb 06, 2018 at 03:32:00PM -0700, Dave Jiang wrote: [..] > The last time I paid much attention to DAX was the thread "re-enable XFS > per-inode DAX"[1] last September. Motivating me to merge anything else >

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-06 Thread Darrick J. Wong
On Tue, Feb 06, 2018 at 03:32:00PM -0700, Dave Jiang wrote: > On 02/01/2018 05:43 PM, Darrick J. Wong wrote: > > On Fri, Feb 02, 2018 at 10:44:13AM +1100, Dave Chinner wrote: > >> On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: > >>> When using realtime device (rtdev) with xfs where

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-06 Thread Dave Jiang
On 02/01/2018 05:43 PM, Darrick J. Wong wrote: > On Fri, Feb 02, 2018 at 10:44:13AM +1100, Dave Chinner wrote: >> On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: >>> When using realtime device (rtdev) with xfs where the data device is not >>> DAX capable, two issues arise. One is when

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Dave Chinner
On Thu, Feb 01, 2018 at 04:43:32PM -0800, Darrick J. Wong wrote: > On Fri, Feb 02, 2018 at 10:44:13AM +1100, Dave Chinner wrote: > > On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: > > > Signed-off-by: Dave Jiang > > > Reported-by: Darrick Wong

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Dave Chinner
On Thu, Feb 01, 2018 at 05:13:40PM -0700, Dave Jiang wrote: > > > On 02/01/2018 04:44 PM, Dave Chinner wrote: > > On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: > >> When using realtime device (rtdev) with xfs where the data device is not > >> DAX capable, two issues arise. One is

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Darrick J. Wong
On Fri, Feb 02, 2018 at 10:44:13AM +1100, Dave Chinner wrote: > On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: > > When using realtime device (rtdev) with xfs where the data device is not > > DAX capable, two issues arise. One is when data device is not DAX but the > > realtime device

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Darrick J. Wong
On Thu, Feb 01, 2018 at 05:08:36PM -0700, Dave Jiang wrote: > > On 02/01/2018 04:28 PM, Darrick J. Wong wrote: > >> [PATCH 2 2/2] xfs: fix rt_dev usage for DAX > > > > "[PATCH v2 2/2]" to distinguish the version number from the patch number > > mor

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Dave Jiang
On 02/01/2018 04:44 PM, Dave Chinner wrote: > On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: >> When using realtime device (rtdev) with xfs where the data device is not >> DAX capable, two issues arise. One is when data device is not DAX but the >> realtime device is DAX capable, we

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Dave Jiang
On 02/01/2018 04:28 PM, Darrick J. Wong wrote: >> [PATCH 2 2/2] xfs: fix rt_dev usage for DAX > > "[PATCH v2 2/2]" to distinguish the version number from the patch number > more explicitly. > > On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: >&

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Dave Chinner
On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: > When using realtime device (rtdev) with xfs where the data device is not > DAX capable, two issues arise. One is when data device is not DAX but the > realtime device is DAX capable, we currently disable DAX. > After passing this check,

Re: [PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Darrick J. Wong
> [PATCH 2 2/2] xfs: fix rt_dev usage for DAX "[PATCH v2 2/2]" to distinguish the version number from the patch number more explicitly. On Thu, Feb 01, 2018 at 01:33:05PM -0700, Dave Jiang wrote: > When using realtime device (rtdev) with xfs where the data device is not > DAX

[PATCH 2 2/2] xfs: fix rt_dev usage for DAX

2018-02-01 Thread Dave Jiang
When using realtime device (rtdev) with xfs where the data device is not DAX capable, two issues arise. One is when data device is not DAX but the realtime device is DAX capable, we currently disable DAX. After passing this check, we are also not marking the inode as DAX capable. This change will