Re: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()

2016-10-03 Thread Christoph Hellwig
On Mon, Oct 03, 2016 at 04:42:46PM +0200, Jan Kara wrote: > Ah, you are right. After reading the code again this patch is not needed > anymore because xfs_file_iomap_begin() returns IOMAP_F_NEW whenever we > allocated block regardless whether it was zeroed-out or not. But if I get it > right, all

Re: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()

2016-10-03 Thread Jan Kara
On Tue 27-09-16 19:13:50, Christoph Hellwig wrote: > On Tue, Sep 27, 2016 at 07:17:07PM +0200, Jan Kara wrote: > > OK, the changelog is stale but I actually took care to integrate this with > > your iomap patches and for the new invalidation code in iomap_dax_actor() > > to work we need this

Re: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()

2016-09-27 Thread Christoph Hellwig
On Tue, Sep 27, 2016 at 07:17:07PM +0200, Jan Kara wrote: > OK, the changelog is stale but I actually took care to integrate this with > your iomap patches and for the new invalidation code in iomap_dax_actor() > to work we need this additional information... It's not just the changelogs (which

Re: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()

2016-09-27 Thread Jan Kara
On Tue 27-09-16 10:01:18, Christoph Hellwig wrote: > On Tue, Sep 27, 2016 at 06:43:33PM +0200, Jan Kara wrote: > > So far we did not set BH_New for newly allocated blocks for DAX inodes > > in __xfs_get_blocks() because we wanted to avoid zeroing done in generic > > DAX code which was racy. Now

Re: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks()

2016-09-27 Thread Christoph Hellwig
On Tue, Sep 27, 2016 at 06:43:33PM +0200, Jan Kara wrote: > So far we did not set BH_New for newly allocated blocks for DAX inodes > in __xfs_get_blocks() because we wanted to avoid zeroing done in generic > DAX code which was racy. Now the zeroing is gone so we can remove this > workaround and