Re: [PATCH v1 07/11] mm/sparse-vmemmap: populate compound pagemaps

2021-05-13 Thread Joao Martins
On 5/10/21 8:19 PM, Dan Williams wrote: > On Thu, May 6, 2021 at 4:02 AM Joao Martins wrote: > [..] +static pte_t * __meminit vmemmap_lookup_address(unsigned long addr) >>> >>> I think this can be replaced with a call to follow_pte(_mm...). >>> >> >> Ah, of course! That would shorten things

Re: [PATCH v1 07/11] mm/sparse-vmemmap: populate compound pagemaps

2021-05-10 Thread Dan Williams
On Thu, May 6, 2021 at 4:02 AM Joao Martins wrote: [..] > >> +static pte_t * __meminit vmemmap_lookup_address(unsigned long addr) > > > > I think this can be replaced with a call to follow_pte(_mm...). > > > > Ah, of course! That would shorten things up too. Now that I look closely, I notice

Re: [PATCH v1 07/11] mm/sparse-vmemmap: populate compound pagemaps

2021-05-06 Thread Joao Martins
On 5/6/21 2:18 AM, Dan Williams wrote: > On Thu, Mar 25, 2021 at 4:10 PM Joao Martins > wrote: >> >> A compound pagemap is a dev_pagemap with @align > PAGE_SIZE and it >> means that pages are mapped at a given huge page alignment and utilize >> uses compound pages as opposed to order-0 pages. >>

Re: [PATCH v1 07/11] mm/sparse-vmemmap: populate compound pagemaps

2021-05-05 Thread Dan Williams
On Thu, Mar 25, 2021 at 4:10 PM Joao Martins wrote: > > A compound pagemap is a dev_pagemap with @align > PAGE_SIZE and it > means that pages are mapped at a given huge page alignment and utilize > uses compound pages as opposed to order-0 pages. > > To minimize struct page overhead we take

[PATCH v1 07/11] mm/sparse-vmemmap: populate compound pagemaps

2021-03-25 Thread Joao Martins
A compound pagemap is a dev_pagemap with @align > PAGE_SIZE and it means that pages are mapped at a given huge page alignment and utilize uses compound pages as opposed to order-0 pages. To minimize struct page overhead we take advantage of the fact that most tail pages look the same (except the