Re: [PATCH v2 6/8] cxl/mem: Enable commands via CEL

2021-02-16 Thread Bartosz Golaszewski
On Thu, Feb 11, 2021 at 1:12 PM Jonathan Cameron wrote: > [snip!] > > > > @@ -869,6 +891,14 @@ static struct cxl_mem *cxl_mem_create(struct pci_dev > > *pdev, u32 reg_lo, > > mutex_init(&cxlm->mbox_mutex); > > cxlm->pdev = pdev; > > cxlm->regs = regs + offset; > > + cxlm->

Re: [PATCH v2 6/8] cxl/mem: Enable commands via CEL

2021-02-11 Thread Dan Williams
On Thu, Feb 11, 2021 at 9:45 AM Ben Widawsky wrote: [..] > > > + if (mbox_cmd.size_out > sizeof(gsl)) { > > > + dev_warn(dev, "%zu excess logs\n", > > > +(mbox_cmd.size_out - sizeof(gsl)) / > > > +sizeof(struct gsl_entry)); > > > > This c

Re: [PATCH v2 6/8] cxl/mem: Enable commands via CEL

2021-02-11 Thread Ben Widawsky
On 21-02-11 12:02:15, Jonathan Cameron wrote: > On Tue, 9 Feb 2021 16:02:57 -0800 > Ben Widawsky wrote: > > > CXL devices identified by the memory-device class code must implement > > the Device Command Interface (described in 8.2.9 of the CXL 2.0 spec). > > While the driver already maintains a l

Re: [PATCH v2 6/8] cxl/mem: Enable commands via CEL

2021-02-11 Thread Jonathan Cameron
On Tue, 9 Feb 2021 16:02:57 -0800 Ben Widawsky wrote: > CXL devices identified by the memory-device class code must implement > the Device Command Interface (described in 8.2.9 of the CXL 2.0 spec). > While the driver already maintains a list of commands it supports, there > is still a need to be

[PATCH v2 6/8] cxl/mem: Enable commands via CEL

2021-02-09 Thread Ben Widawsky
CXL devices identified by the memory-device class code must implement the Device Command Interface (described in 8.2.9 of the CXL 2.0 spec). While the driver already maintains a list of commands it supports, there is still a need to be able to distinguish between commands that the driver knows abou