Re: [PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns

2018-02-13 Thread Ross Zwisler
On Tue, Feb 13, 2018 at 01:35:19PM -0700, Dave Jiang wrote: > > > On 02/13/2018 01:31 PM, Ross Zwisler wrote: > > On Thu, Feb 08, 2018 at 05:38:19PM -0700, Dave Jiang wrote: > >> The function return values are confusing with the way the function is > >> named. We expect a true or false return

Re: [PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns

2018-02-13 Thread Dave Jiang
On 02/13/2018 01:31 PM, Ross Zwisler wrote: > On Thu, Feb 08, 2018 at 05:38:19PM -0700, Dave Jiang wrote: >> The function return values are confusing with the way the function is >> named. We expect a true or false return value but it actually returns >> 0/-errno. This makes the code very

Re: [PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns

2018-02-13 Thread Ross Zwisler
On Thu, Feb 08, 2018 at 05:38:19PM -0700, Dave Jiang wrote: > The function return values are confusing with the way the function is > named. We expect a true or false return value but it actually returns > 0/-errno. This makes the code very confusing. Changing the return values > to return a bool

[PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns

2018-02-08 Thread Dave Jiang
The function return values are confusing with the way the function is named. We expect a true or false return value but it actually returns 0/-errno. This makes the code very confusing. Changing the return values to return a bool where if DAX is supported then return true and no DAX support