RE: [PATCH v8 1/3] ndctl, monitor: add ndctl monitor

2018-06-27 Thread Qi, Fuli
> -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Thursday, June 28, 2018 12:53 PM > To: Qi, Fuli/斉 福利 > Cc: linux-nvdimm > Subject: Re: [PATCH v8 1/3] ndctl, monitor: add ndctl monitor > > On Wed, Jun 27, 2018 at 8:02 PM, Qi,

Re: [PATCH v8 1/3] ndctl, monitor: add ndctl monitor

2018-06-27 Thread Dan Williams
On Wed, Jun 27, 2018 at 8:02 PM, Qi, Fuli wrote: > Thanks for your comments. > Thanks for continuing to work through the feedback. >> > +static struct monitor_dimm *util_dimm_event_filter(struct monitor_dimm >> > *mdimm, >> > + const char *__ident) >> > +{ >> > + char

RE: [PATCH v8 1/3] ndctl, monitor: add ndctl monitor

2018-06-27 Thread Qi, Fuli
Thanks for your comments. > -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Thursday, June 28, 2018 12:09 AM > To: Qi, Fuli/斉 福利 > Cc: linux-nvdimm > Subject: Re: [PATCH v8 1/3] ndctl, monitor: add ndctl monitor > > On Tue, Jun

Re: [PATCH v8 1/3] ndctl, monitor: add ndctl monitor

2018-06-27 Thread Dan Williams
On Tue, Jun 26, 2018 at 10:24 PM, QI Fuli wrote: > Ndctl monitor is used for monitoring the smart events of nvdimm DIMMs. > When a smart event fires, monitor will output the notifications which > include dimm health status and evnet informations to syslog or a > logfile by setting [--logfile]

[PATCH v8 1/3] ndctl, monitor: add ndctl monitor

2018-06-26 Thread QI Fuli
Ndctl monitor is used for monitoring the smart events of nvdimm DIMMs. When a smart event fires, monitor will output the notifications which include dimm health status and evnet informations to syslog or a logfile by setting [--logfile] option. The notifications follow json format and can be