Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-22 Thread antlists
On 20/12/2020 09:46, Coly Li wrote: Currently blocks/badblocks.c is used by md raid and nvdimm code, and the badblocks table is irrelevant to any of these two subsystems. Good to know. If there will be better code for similar or better functionality, it should be cool. For me, if the

Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-20 Thread Coly Li
On 12/18/20 11:25 AM, Dan Williams wrote: > [ add Neil, original gooodguy who wrote badblocks ] > > > On Thu, Dec 3, 2020 at 9:16 AM Coly Li wrote: >> >> Recently I received a bug report that current badblocks code does not >> properly handle multiple ranges. For example, >>

Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-20 Thread Coly Li
On 12/20/20 4:02 AM, antlists wrote: > On 03/12/2020 17:15, Coly Li wrote: >> This patch is an initial effort to improve badblocks_set() for setting >> bad blocks range when it covers multiple already set bad ranges in the >> bad blocks table, and to do it as fast as possible. > > Is this your

Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-19 Thread antlists
On 03/12/2020 17:15, Coly Li wrote: This patch is an initial effort to improve badblocks_set() for setting bad blocks range when it covers multiple already set bad ranges in the bad blocks table, and to do it as fast as possible. Is this your patch, or submitted as part of the bug report?

Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-17 Thread Dan Williams
[ add Neil, original gooodguy who wrote badblocks ] On Thu, Dec 3, 2020 at 9:16 AM Coly Li wrote: > > Recently I received a bug report that current badblocks code does not > properly handle multiple ranges. For example, > badblocks_set(bb, 32, 1, true); > badblocks_set(bb, 34,

[RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-03 Thread Coly Li
Recently I received a bug report that current badblocks code does not properly handle multiple ranges. For example, badblocks_set(bb, 32, 1, true); badblocks_set(bb, 34, 1, true); badblocks_set(bb, 36, 1, true); badblocks_set(bb, 32, 12, true); Then indeed