Re: [ndctl PATCH] ndctl, firmware-update: kill usage of flock() in verify_fw_file()

2018-02-23 Thread Ross Zwisler
On Thu, Feb 22, 2018 at 10:59:27PM -0800, Dan Williams wrote: > It serves no purpose, we never explicitly unlock it, and it causes > needless failures if the firmware file happens to be on a filesystem > that does not support file locks. > > Cc: Dave Jiang > Signed-off-by:

[ndctl PATCH] ndctl, firmware-update: kill usage of flock() in verify_fw_file()

2018-02-22 Thread Dan Williams
It serves no purpose, we never explicitly unlock it, and it causes needless failures if the firmware file happens to be on a filesystem that does not support file locks. Cc: Dave Jiang Signed-off-by: Dan Williams --- ndctl/update.c |6 --