Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-29 Thread Dan Williams
On Fri, Feb 21, 2020 at 2:21 AM qi.f...@fujitsu.com wrote: > > > > On 2/20/20 5:28 AM, Verma, Vishal L wrote: > > On Wed, 2020-02-19 at 12:09 -0800, Dan Williams wrote: > > Let's do a compromise, because users also hate nonsensical legacy that > they can't avoid. How about an

Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-21 Thread qi.f...@fujitsu.com
On 2/20/20 5:28 AM, Verma, Vishal L wrote: > On Wed, 2020-02-19 at 12:09 -0800, Dan Williams wrote: Let's do a compromise, because users also hate nonsensical legacy that they can't avoid. How about an environment variable, "NDCTL_LIST_LINT", that users can set to opt into

Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-19 Thread Verma, Vishal L
On Wed, 2020-02-19 at 12:09 -0800, Dan Williams wrote: > > > > > > Let's do a compromise, because users also hate nonsensical legacy that > > > they can't avoid. How about an environment variable, > > > "NDCTL_LIST_LINT", that users can set to opt into the latest / > > > cleanest output format

Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-19 Thread Dan Williams
On Wed, Feb 19, 2020 at 12:01 PM Verma, Vishal L wrote: > > On Wed, 2020-02-19 at 10:53 -0800, Dan Williams wrote: > > > > > > > Will this break existing code that parses the javascript output? > > > > > > > > Always a potential for that. That said, I'd rather attempt to make it > > > > symmetric

Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-19 Thread Verma, Vishal L
On Wed, 2020-02-19 at 10:53 -0800, Dan Williams wrote: > > > > > Will this break existing code that parses the javascript output? > > > > > > Always a potential for that. That said, I'd rather attempt to make it > > > symmetric and replace it if someone screams, rather than let this > > > quirk

Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-19 Thread Dan Williams
On Wed, Feb 19, 2020 at 10:12 AM Jeff Moyer wrote: > > Dan Williams writes: > > > On Wed, Feb 19, 2020 at 9:56 AM Jeff Moyer wrote: > >> > >> Dan Williams writes: > >> > >> > The only expected difference between "ndctl list -R" and "ndctl list > >> > -Rv" is some additional output fields.

Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-19 Thread Jeff Moyer
Dan Williams writes: > On Wed, Feb 19, 2020 at 9:56 AM Jeff Moyer wrote: >> >> Dan Williams writes: >> >> > The only expected difference between "ndctl list -R" and "ndctl list >> > -Rv" is some additional output fields. Instead it currently results in >> > the region array being contained in

Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-19 Thread Dan Williams
On Wed, Feb 19, 2020 at 9:56 AM Jeff Moyer wrote: > > Dan Williams writes: > > > The only expected difference between "ndctl list -R" and "ndctl list > > -Rv" is some additional output fields. Instead it currently results in > > the region array being contained in a named "regions" list object.

Re: [ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2020-02-19 Thread Jeff Moyer
Dan Williams writes: > The only expected difference between "ndctl list -R" and "ndctl list > -Rv" is some additional output fields. Instead it currently results in > the region array being contained in a named "regions" list object. > > # ndctl list -R -r 0 > [ > { > "dev":"region0", >

[ndctl PATCH] ndctl/list: Drop named list objects from verbose listing

2019-11-26 Thread Dan Williams
The only expected difference between "ndctl list -R" and "ndctl list -Rv" is some additional output fields. Instead it currently results in the region array being contained in a named "regions" list object. # ndctl list -R -r 0 [ { "dev":"region0", "size":4294967296,