Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-26 Thread Jeff Moyer
Dan Williams writes: > On Wed, Feb 26, 2020 at 1:52 PM Jeff Moyer wrote: >> >> Dan Williams writes: >> >> >> Missing doctext. Specifically, there should be a big, fat warning >> >> against changing the region alignment. >> > >> > I don't mind adding one, but is this the right place to

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-26 Thread Dan Williams
On Wed, Feb 26, 2020 at 1:52 PM Jeff Moyer wrote: > > Dan Williams writes: > > >> Missing doctext. Specifically, there should be a big, fat warning > >> against changing the region alignment. > > > > I don't mind adding one, but is this the right place to document an > > API warning? If the

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-26 Thread Jeff Moyer
Dan Williams writes: >> Missing doctext. Specifically, there should be a big, fat warning >> against changing the region alignment. > > I don't mind adding one, but is this the right place to document an > API warning? If the audience is future ndctl developers that should be > warned to keep

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-26 Thread Dan Williams
On Tue, Feb 25, 2020 at 3:23 PM Dan Williams wrote: > > On Wed, Feb 19, 2020 at 10:04 AM Jeff Moyer wrote: > > > > Dan Williams writes: > > > > > > > > +NDCTL_EXPORT unsigned long ndctl_region_get_align(struct ndctl_region > > > *region) > > > +{ > > > + return region->align; > > > +} > >

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-25 Thread Dan Williams
On Wed, Feb 19, 2020 at 10:04 AM Jeff Moyer wrote: > > Dan Williams writes: > > > > > +NDCTL_EXPORT unsigned long ndctl_region_get_align(struct ndctl_region > > *region) > > +{ > > + return region->align; > > +} > > + > > +NDCTL_EXPORT int ndctl_region_set_align(struct ndctl_region *region,

Re: [ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-02-19 Thread Jeff Moyer
Dan Williams writes: > > +NDCTL_EXPORT unsigned long ndctl_region_get_align(struct ndctl_region > *region) > +{ > + return region->align; > +} > + > +NDCTL_EXPORT int ndctl_region_set_align(struct ndctl_region *region, > + unsigned long align) > +{ > + struct ndctl_ctx

[ndctl PATCH 1/2] ndctl/region: Support ndctl_region_{get, set}_align()

2020-01-30 Thread Dan Williams
Add support for the new kernel facility to set space alignment constraints at the region level. Update the unit tests to bypass the default 16MiB alignment constraint. Add the new parameter to the default region listing given how central it is to understanding the valid values for