RE: [ndctl PATCH v11 5/5] ndctl, test: add a new unit test for monitor

> On Thu, 2018-07-12 at 15:51 -0400, Masayoshi Mizuma wrote: > > Hi Qi, > > > > Nice work! Let me ask some comments. > > > > On 07/10/2018 11:00 PM, QI Fuli wrote: > > [...] > > > diff --git a/test/monitor.sh b/test/monitor.sh new file mode 100755 > > > index 000..43cb11f > > > --- /dev/null >

Re: [ndctl PATCH v11 5/5] ndctl, test: add a new unit test for monitor

On Thu, 2018-07-12 at 15:51 -0400, Masayoshi Mizuma wrote: > Hi Qi, > > Nice work! Let me ask some comments. > > On 07/10/2018 11:00 PM, QI Fuli wrote: > [...] > > diff --git a/test/monitor.sh b/test/monitor.sh > > new file mode 100755 > > index 000..43cb11f > > --- /dev/null > > +++

Re: [ndctl PATCH v11 5/5] ndctl, test: add a new unit test for monitor

Hi Qi, Nice work! Let me ask some comments. On 07/10/2018 11:00 PM, QI Fuli wrote: [...] > diff --git a/test/monitor.sh b/test/monitor.sh > new file mode 100755 > index 000..43cb11f > --- /dev/null > +++ b/test/monitor.sh > @@ -0,0 +1,177 @@ > +#!/bin/bash -Ex > + > +#

[ndctl PATCH v11 5/5] ndctl, test: add a new unit test for monitor

Add a new unit test to test all options of the monitor command. Based-on-patch-by: Yasunori Goto Signed-off-by: QI Fuli --- .gitignore | 1 + test/Makefile.am | 14 +++- test/list-smart-dimm.c | 117 +++ test/monitor.sh| 177