RE: [ndctl PATCH v13 2/5] ndctl, monitor: add main ndctl monitor configuration file

2018-11-05 Thread qi.f...@fujitsu.com
> > Hi, > > > > I have a future cleanup request. I've just come across, ciniparser > > [1]. It would be great if we could drop the open coded implementation and > > just > use that library. > > We use ccan modules for other portions of ndctl. > > > > [1]:

RE: [ndctl PATCH v13 2/5] ndctl, monitor: add main ndctl monitor configuration file

2018-10-15 Thread qi.f...@fujitsu.com
> > Hi, > > I have a future cleanup request. I've just come across, ciniparser [1]. It > would > be great if we could drop the open coded implementation and just use that > library. > We use ccan modules for other portions of ndctl. > > [1]: https://ccodearchive.net/info/ciniparser.html Hi

Re: [ndctl PATCH v13 2/5] ndctl, monitor: add main ndctl monitor configuration file

2018-10-15 Thread Dan Williams
On Fri, Jul 13, 2018 at 4:34 PM QI Fuli wrote: > > This patch adds the main configuration file(/etc/ndctl/monitor.conf) > of ndctl monitor. It contains the configuration directives that give > ndctl monitor instructions. Users can change the configuration by > editing this file or using

[ndctl PATCH v13 2/5] ndctl, monitor: add main ndctl monitor configuration file

2018-07-13 Thread QI Fuli
This patch adds the main configuration file(/etc/ndctl/monitor.conf) of ndctl monitor. It contains the configuration directives that give ndctl monitor instructions. Users can change the configuration by editing this file or using [--config-file] option to override this file. The changed value