Re: [ndctl PATCH v2] ndctl, test: add a new unit test for monitor

2018-07-07 Thread Verma, Vishal L
On Fri, 2018-07-06 at 20:43 -0700, Dan Williams wrote: > On Fri, Jul 6, 2018 at 6:48 PM, QI Fuli wrote: > > Hi Masa, > > > > Thank you for your comments. > > > > On 7/7/2018 12:08 AM, Masayoshi Mizuma wrote: > > > > > > Hi Qi, > > > > > > On 07/06/2018 01:22 AM, QI Fuli wrote: > > > > > > >

RE: [ndctl PATCH v2] ndctl, test: add a new unit test for monitor

2018-07-06 Thread Qi, Fuli
> -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Saturday, July 7, 2018 12:58 PM > To: Qi, Fuli/斉 福利 > Cc: linux-nvdimm > Subject: Re: [ndctl PATCH v2] ndctl, test: add a new unit test for monitor > > On Thu, Jul 5, 2018 at

Re: [ndctl PATCH v2] ndctl, test: add a new unit test for monitor

2018-07-06 Thread Dan Williams
On Thu, Jul 5, 2018 at 10:22 PM, QI Fuli wrote: > Add a new unit test to test the following options of the monitor command. >--dimm >--bus >--region >--namespace >--logfile >--config-file > > Based-on-patch-by: Yasunori Goto > Acked-by: Masayoshi Mizuma > Signed-off-by:

Re: [ndctl PATCH v2] ndctl, test: add a new unit test for monitor

2018-07-06 Thread Dan Williams
On Fri, Jul 6, 2018 at 6:48 PM, QI Fuli wrote: > Hi Masa, > > Thank you for your comments. > > On 7/7/2018 12:08 AM, Masayoshi Mizuma wrote: >> >> Hi Qi, >> >> On 07/06/2018 01:22 AM, QI Fuli wrote: >>> >>> Add a new unit test to test the following options of the monitor command. >>> --dimm

Re: [ndctl PATCH v2] ndctl, test: add a new unit test for monitor

2018-07-06 Thread QI Fuli
Hi Masa, Thank you for your comments. On 7/7/2018 12:08 AM, Masayoshi Mizuma wrote: Hi Qi, On 07/06/2018 01:22 AM, QI Fuli wrote: Add a new unit test to test the following options of the monitor command. --dimm --bus --region --namespace --logfile --config-file

Re: [ndctl PATCH v2] ndctl, test: add a new unit test for monitor

2018-07-06 Thread Masayoshi Mizuma
Hi Qi, On 07/06/2018 01:22 AM, QI Fuli wrote: > Add a new unit test to test the following options of the monitor command. >--dimm >--bus >--region >--namespace >--logfile >--config-file > > Based-on-patch-by: Yasunori Goto > Acked-by: Masayoshi Mizuma I think this

[ndctl PATCH v2] ndctl, test: add a new unit test for monitor

2018-07-05 Thread QI Fuli
Add a new unit test to test the following options of the monitor command. --dimm --bus --region --namespace --logfile --config-file Based-on-patch-by: Yasunori Goto Acked-by: Masayoshi Mizuma Signed-off-by: QI Fuli --- v1 -> v2: - Add init() - Add get_filter_dimm() to get