Re: [ndctl PATCH v2] ndctl/lib: fix symbol redefinitions reported by GCC10

2020-01-30 Thread Dan Williams
On Thu, Jan 30, 2020 at 4:40 PM Vishal Verma wrote: > > A toolchain update in Fedora 32 caused new compile errors due to > multiple definitions of dimm_ops structures. The declarations in > 'private.h' for the various NFIT families are present so that libndctl > can find all the per-family

[ndctl PATCH v2] ndctl/lib: fix symbol redefinitions reported by GCC10

2020-01-30 Thread Vishal Verma
A toolchain update in Fedora 32 caused new compile errors due to multiple definitions of dimm_ops structures. The declarations in 'private.h' for the various NFIT families are present so that libndctl can find all the per-family dimm-ops. However they need to be declared as extern because the