RE: [ndctl PATCH v2 1/4] libndctl: add support for NVDIMM_FAMILY_HYPERV's _DSM Function 1

2019-03-21 Thread Dexuan Cui
> From: Verma, Vishal L > Sent: Wednesday, March 20, 2019 5:23 PM > ... > Also on a more general note, the patches in this series don't appear to > be correctly threaded. Normally, patch emails in a series are replies to > the first patch (either 1/N or the cover letter), and this allows for >

Re: [ndctl PATCH v2 1/4] libndctl: add support for NVDIMM_FAMILY_HYPERV's _DSM Function 1

2019-03-20 Thread Verma, Vishal L
Hi Dexuan, Thanks for these patches - I had a few comments below. Also on a more general note, the patches in this series don't appear to be correctly threaded. Normally, patch emails in a series are replies to the first patch (either 1/N or the cover letter), and this allows for easier review

[ndctl PATCH v2 1/4] libndctl: add support for NVDIMM_FAMILY_HYPERV's _DSM Function 1

2019-02-19 Thread Dexuan Cui
This patch retrieves the health info by Hyper-V _DSM method Function 1: Get Health Information (Function Index 1) See http://www.uefi.org/RFIC_LIST ("Virtual NVDIMM 0x1901"). Now "ndctl list --dimms --health --idle" can show a line "health_state":"ok", e.g. { "dev":"nmem0",