> From: Verma, Vishal L
> Sent: Friday, March 22, 2019 11:29 AM
>
> On Fri, 2019-03-22 at 17:55 +, Dexuan Cui wrote:
> > > From: Dan Williams
> > > Sent: Thursday, March 21, 2019 11:12 PM
> > > To: Dexuan Cui
> > >
> > > On Thu, Mar 21, 2019 at 11:03 PM Dexuan Cui
> wrote:
> > > > > From:
On Fri, 2019-03-22 at 17:55 +, Dexuan Cui wrote:
> > From: Dan Williams
> > Sent: Thursday, March 21, 2019 11:12 PM
> > To: Dexuan Cui
> >
> > On Thu, Mar 21, 2019 at 11:03 PM Dexuan Cui wrote:
> > > > From: Dan Williams
> > > > Sent: Thursday, March 21, 2019 10:37 PM
> > > >
> > > >
> From: Dan Williams
> Sent: Friday, March 22, 2019 11:04 AM
>
> On Fri, Mar 22, 2019 at 10:56 AM Dexuan Cui wrote:
> >
> > > I'd rather change ndctl_dimm_cmd_is_supported() to call back into a
> > > dimm-op so that the Hyper-V implementation can say "yes, I support
> > > (emulate) the
On Fri, Mar 22, 2019 at 10:56 AM Dexuan Cui wrote:
>
> > From: Dan Williams
> > Sent: Thursday, March 21, 2019 11:12 PM
> > To: Dexuan Cui
> >
> > On Thu, Mar 21, 2019 at 11:03 PM Dexuan Cui wrote:
> > >
> > > > From: Dan Williams
> > > > Sent: Thursday, March 21, 2019 10:37 PM
> > > >
> > >
> From: Dan Williams
> Sent: Thursday, March 21, 2019 11:12 PM
> To: Dexuan Cui
>
> On Thu, Mar 21, 2019 at 11:03 PM Dexuan Cui wrote:
> >
> > > From: Dan Williams
> > > Sent: Thursday, March 21, 2019 10:37 PM
> > >
> > > No, I think you misunderstand. Hyper-V implements "function-1",
> > >
On Thu, Mar 21, 2019 at 11:03 PM Dexuan Cui wrote:
>
> > From: Dan Williams
> > Sent: Thursday, March 21, 2019 10:37 PM
> >
> > No, I think you misunderstand. Hyper-V implements "function-1",
> > "command-1" support can be emulated. The request is to translate the
> > Hyper-V function-1 payload
> From: Dan Williams
> Sent: Thursday, March 21, 2019 10:37 PM
>
> No, I think you misunderstand. Hyper-V implements "function-1",
> "command-1" support can be emulated. The request is to translate the
> Hyper-V function-1 payload into the command-1 payload format.
Then, yes, I think so. The
On Thu, Mar 21, 2019 at 10:09 PM Dexuan Cui wrote:
>
> > From: Dan Williams
> > Sent: Thursday, March 21, 2019 9:13 PM
> > > ...
> > > Actually, this _is_ an issue for NVDIMM_FAMILY_HYPERV (and the other
> > > families except for NVDIMM_FAMILY_INTEL) : see the kernel function
> > >
> From: Dan Williams
> Sent: Thursday, March 21, 2019 9:13 PM
> > ...
> > Actually, this _is_ an issue for NVDIMM_FAMILY_HYPERV (and the other
> > families except for NVDIMM_FAMILY_INTEL) : see the kernel function
> > acpi_nfit_register_dimms(), where ND_CMD_SMART is set in the
> > "cmd_mask"
On Thu, Mar 21, 2019 at 9:06 PM Dexuan Cui wrote:
>
> > From: Dexuan Cui
> > Sent: Thursday, March 21, 2019 7:09 PM
>
> > IMO there are 2 issues in ndctl/monitor.c: filter_dimm():
> >
> > 1. IMO the cmd numbers ND_CMD_SMART (1) and
> > ND_CMD_SMART_THRESHOLD(2) are not really device-neutral. They
> From: Dexuan Cui
> Sent: Thursday, March 21, 2019 7:09 PM
> IMO there are 2 issues in ndctl/monitor.c: filter_dimm():
>
> 1. IMO the cmd numbers ND_CMD_SMART (1) and
> ND_CMD_SMART_THRESHOLD(2) are not really device-neutral. They
> work for ndctl/lib/intel.c and it looks they happen to work
On Thu, Mar 21, 2019 at 7:09 PM Dexuan Cui wrote:
[..]
> > That way if the user enters any of the unsupported options, they will
> > just fail normally, and the user will be expected to provide the right
> > options for the environment they know they're running in.
>
> When the user enters any of
> From: Verma, Vishal L
> Sent: Wednesday, March 20, 2019 6:55 PM
> ...
> >
> > -static void filter_dimm(struct ndctl_dimm *dimm, struct util_filter_ctx
> > *fctx)
> > +static bool ndctl_dimm_test_and_enable_notification(struct ndctl_dimm
> *dimm)
> > {
> > - struct monitor_dimm *mdimm;
> > -
On Wed, 2019-02-20 at 05:11 +, Dexuan Cui wrote:
> Currently "ndctl monitor" fails for NVDIMM_FAMILY_HYPERV due to
> "no smart support".
>
> NVDIMM_FAMILY_HYPERV doesn't use ND_CMD_SMART to get the health info.
> Instead, it uses ND_CMD_CALL, so the checking here can't apply,and it
>
> From: qi.f...@fujitsu.com
> Sent: Sunday, February 24, 2019 8:48 PM
> To: Dexuan Cui ; Dave Jiang ;
> Vishal Verma ; Dan Williams
> ; linux-nvdimm@lists.01.org; Michael Kelley
> ; Johannes Thumshirn
> Subject: RE: [ndctl PATCH v2 4/4] ndctl, monitor: support
&
>
> Hi Qi,
> Generally speaking, I agree with you, but here the fact is that we can only
> monitor this
> one single event "dimm-health-state" for Hyper-V Virtual NVDIMM, and the other
> events are meaningless for Hyper-V Virtual NVDIMM, as they're not supported by
> Hyper-V Virtual NVDIMM.
>
>
> From: qi.f...@fujitsu.com
> Sent: Thursday, February 21, 2019 12:40 AM
> > ...
> > + /*
> > +* Hyper-V Virtual NVDIMM doesn't use ND_CMD_SMART to get the
> > health info. Instead, it uses ND_CMD_CALL, so the checking here can't
> > +* apply, and it doesn't support threshold alarms --
> -Original Message-
> From: Dexuan Cui [mailto:de...@microsoft.com]
> Sent: Wednesday, February 20, 2019 2:12 PM
> To: Dave Jiang ; Vishal Verma
> ; Dan Williams ;
> linux-nvdimm@lists.01.org; Michael Kelley ; Qi,
> Fuli/斉 福利 ; Johannes Thumshirn
> Subject: [n
Currently "ndctl monitor" fails for NVDIMM_FAMILY_HYPERV due to
"no smart support".
NVDIMM_FAMILY_HYPERV doesn't use ND_CMD_SMART to get the health info.
Instead, it uses ND_CMD_CALL, so the checking here can't apply,and it
doesn't support threshold alarms -- actually it only supports one
19 matches
Mail list logo
