Re: [ndctl PATCH v3 1/4] libndctl: test enablement for non-nfit devices

2021-03-18 Thread Santosh Sivaraj
"Verma, Vishal L" writes: Hi Vishal, > On Thu, 2021-03-11 at 13:16 +0530, Santosh Sivaraj wrote: >> Unify adding dimms for papr and nfit families, this will help in adding > > Minor nit, but it seems like the subject line and the first sentence in > the body should be swapped. The one-line

Re: [ndctl PATCH v3 1/4] libndctl: test enablement for non-nfit devices

2021-03-17 Thread Verma, Vishal L
On Thu, 2021-03-11 at 13:16 +0530, Santosh Sivaraj wrote: > Unify adding dimms for papr and nfit families, this will help in adding Minor nit, but it seems like the subject line and the first sentence in the body should be swapped. The one-line description of what's happening in this patch is

[ndctl PATCH v3 1/4] libndctl: test enablement for non-nfit devices

2021-03-10 Thread Santosh Sivaraj
Unify adding dimms for papr and nfit families, this will help in adding all attributes needed for the unit tests too. We don't fail adding a dimm if some of the dimm attributes are missing, so this will work fine on PAPR platforms where most dimm attributes are provided. Signed-off-by: Santosh