Re: [ndctl PATCH v5 1/6] libndctl: Refactor out add_dimm() to handle NFIT specific init

2020-06-03 Thread Vaibhav Jain
Hi Vishal, Thanks for reviewing this patch. My responses below: "Verma, Vishal L" writes: > On Sat, 2020-05-30 at 03:35 +0530, Vaibhav Jain wrote: >> Presently add_dimm() only probes dimms that support NFIT/ACPI. Hence >> this patch refactors this functionality into two functions namely >>

Re: [ndctl PATCH v5 1/6] libndctl: Refactor out add_dimm() to handle NFIT specific init

2020-06-02 Thread Verma, Vishal L
On Sat, 2020-05-30 at 03:35 +0530, Vaibhav Jain wrote: > Presently add_dimm() only probes dimms that support NFIT/ACPI. Hence > this patch refactors this functionality into two functions namely > add_dimm() and add_nfit_dimm(). Function add_dimm() performs > allocation and common 'struct

[ndctl PATCH v5 1/6] libndctl: Refactor out add_dimm() to handle NFIT specific init

2020-05-29 Thread Vaibhav Jain
Presently add_dimm() only probes dimms that support NFIT/ACPI. Hence this patch refactors this functionality into two functions namely add_dimm() and add_nfit_dimm(). Function add_dimm() performs allocation and common 'struct ndctl_dimm' initialization and depending on whether the dimm-bus