Re: [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon

2018-05-31 Thread Dan Williams
On Fri, May 25, 2018 at 1:49 AM, Qi, Fuli wrote: >> As mentioned above this function seems to assume that the only DIMM events to >> send are DIMM health events. It's ok to save other object monitoring to a >> later patch, >> but let's at least support DIMM health >> events: >> >>

RE: [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon

2018-05-25 Thread Qi, Fuli
> As mentioned above this function seems to assume that the only DIMM events to > send are DIMM health events. It's ok to save other object monitoring to a > later patch, > but let's at least support DIMM health > events: > > dimm-spares-remaining > dimm-media-temperature >

RE: [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon

2018-05-15 Thread Qi, Fuli
> -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Wednesday, May 16, 2018 2:07 AM > To: Qi, Fuli/斉 福利 <qi.f...@jp.fujitsu.com> > Cc: linux-nvdimm <linux-nvdimm@lists.01.org> > Subject: Re: [PATCH v6 2/4] ndctl, monitor: add nd

Re: [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon

2018-05-15 Thread Dan Williams
On Tue, May 15, 2018 at 1:32 AM, Qi, Fuli wrote: [..] >> Actually, I don't see a need to have LOG_DESTINATION_FILE at all. Why not >> just >> do: >> >> ndctl monitor 2>file >> >> ...to redirect stderr to a file? > > In my understanding, this stderr redirection does

RE: [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon

2018-05-15 Thread Qi, Fuli
> -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Saturday, May 12, 2018 3:45 AM > To: Qi, Fuli/斉 福利 <qi.f...@jp.fujitsu.com> > Cc: linux-nvdimm <linux-nvdimm@lists.01.org> > Subject: Re: [PATCH v6 2/4] ndctl, monitor: add nd

Re: [PATCH v6 2/4] ndctl, monitor: add ndctl monitor daemon

2018-05-11 Thread Dan Williams
On Sun, May 6, 2018 at 10:09 PM, QI Fuli wrote: > This patch adds the body file of ndctl monitor daemon. This is too short. Let's copy your cover letter details into this patch since the cover letter is thrown away, but the commit messages are preserved in git: ---