On Tue, Jun 26, 2018 at 8:15 AM, Qi, Fuli wrote:
> Hi Dan,
> Thanks for your comments.
>
[..]
>> > + if (strcmp(buf, "bus") == 0) {
>> > + set_config((const char **), value);
>>
>> The cast is unnecessary, and I think we can clean this up further by having
>>
Hi Dan,
Thanks for your comments.
> -Original Message-
> From: Dan Williams [mailto:dan.j.willi...@intel.com]
> Sent: Tuesday, June 26, 2018 1:43 PM
> To: Qi, Fuli/斉 福利
> Cc: linux-nvdimm
> Subject: Re: [PATCH v7 2/3] ndctl, monitor: add main ndctl monitor
>
On Mon, Jun 18, 2018 at 1:27 AM, QI Fuli wrote:
> This patch adds the main configuration file(/etc/ndctl/monitor.conf)
> of ndctl monitor. It contains the configuration directives that give
> ndctl monitor instructions. Users can change the configuration by
> editing this file or by using
