Re: [ndclt PATCH] ndctl, monitor: Fix duplicate prefix in monitor.log

2018-08-02 Thread Verma, Vishal L
On Thu, 2018-08-02 at 09:22 -0400, Masayoshi Mizuma wrote: > Hi QI, > > On 08/02/2018 05:42 AM, Qi, Fuli wrote: > ... > > > > diff --git a/ndctl/monitor.c b/ndctl/monitor.c index > > > > c6419ad..4e5daf5 > > > > 100644 > > > > --- a/ndctl/monitor.c > > > > +++ b/ndctl/monitor.c > > > > @@

Re: [ndclt PATCH] ndctl, monitor: Fix duplicate prefix in monitor.log

2018-08-02 Thread Masayoshi Mizuma
Hi QI, On 08/02/2018 05:42 AM, Qi, Fuli wrote: ... >>> diff --git a/ndctl/monitor.c b/ndctl/monitor.c index c6419ad..4e5daf5 >>> 100644 >>> --- a/ndctl/monitor.c >>> +++ b/ndctl/monitor.c >>> @@ -614,7 +614,8 @@ int cmd_monitor(int argc, const char **argv, void *ctx) >>> goto out; >>>

RE: [ndclt PATCH] ndctl, monitor: Fix duplicate prefix in monitor.log

2018-08-02 Thread Qi, Fuli
> -Original Message- > From: Masayoshi Mizuma [mailto:msys.miz...@gmail.com] > Sent: Thursday, August 2, 2018 3:15 AM > To: Qi, Fuli/斉 福利 ; linux-nvdimm@lists.01.org > Subject: Re: [ndclt PATCH] ndctl, monitor: Fix duplicate prefix in monitor.log > > Hi QI, > >

Re: [ndclt PATCH] ndctl, monitor: Fix duplicate prefix in monitor.log

2018-08-01 Thread Masayoshi Mizuma
Hi QI, On 07/31/2018 01:15 AM, QI Fuli wrote: > When a monitor runs with [--log] option, the prefix will be dually > added to monitor.log. Therefore, the monitor cannot log the smart > notification to syslog. This patch is used to prevent prefix from > being dually added to monitor.log. > >