Re: [PATCH 2/2] mm: simplify follow_pte{,pmd}

2020-11-11 Thread Stephen Rothwell
Hi Christoph, On Wed, 11 Nov 2020 09:28:42 +0100 Christoph Hellwig wrote: > > On Wed, Nov 11, 2020 at 09:26:20AM +0100, Christian Borntraeger wrote: > > > > On 11.11.20 09:18, Christoph Hellwig wrote: > > > On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote: > > >> Sorry, I

Re: [PATCH 2/2] mm: simplify follow_pte{,pmd}

2020-11-11 Thread Christoph Hellwig
On Wed, Nov 11, 2020 at 09:26:20AM +0100, Christian Borntraeger wrote: > > On 11.11.20 09:18, Christoph Hellwig wrote: > > On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote: > >> Sorry, I think this patch may be causing a regression for us for s390? > >>

Re: [PATCH 2/2] mm: simplify follow_pte{,pmd}

2020-11-11 Thread Christian Borntraeger
On 11.11.20 09:18, Christoph Hellwig wrote: > On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote: >> Sorry, I think this patch may be causing a regression for us for s390? >> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/432129279#L768 >> >> (via

Re: [PATCH 2/2] mm: simplify follow_pte{,pmd}

2020-11-11 Thread Christoph Hellwig
On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote: > Sorry, I think this patch may be causing a regression for us for s390? > https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/432129279#L768 > > (via

Re: [PATCH 2/2] mm: simplify follow_pte{,pmd}

2020-11-10 Thread Nick Desaulniers
Sorry, I think this patch may be causing a regression for us for s390? https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/432129279#L768 (via https://lore.kernel.org/linux-mm/20201029101432.47011-3-...@lst.de) ___ Linux-nvdimm

Re: [PATCH 2/2] mm: simplify follow_pte{,pmd}

2020-11-10 Thread Matthew Wilcox
On Thu, Oct 29, 2020 at 11:14:32AM +0100, Christoph Hellwig wrote: > Merge __follow_pte_pmd, follow_pte_pmd and follow_pte into a single > follow_pte function and just pass two additional NULL arguments for > the two previous follow_pte callers. > > Signed-off-by: Christoph Hellwig Reviewed-by: