Re: [PATCH v3 1/3] dax: Add an enum for specifying dax wakup mode

2021-04-21 Thread Vivek Goyal
On Wed, Apr 21, 2021 at 05:16:24PM +0100, Matthew Wilcox wrote: > On Wed, Apr 21, 2021 at 11:56:31AM -0400, Vivek Goyal wrote: > > +/** > > + * enum dax_entry_wake_mode: waitqueue wakeup toggle > > s/toggle/behaviour/ ? Will do. > > > + * @WAKE_NEXT: wake only the first waiter in the waitqueue

Re: [PATCH v3 1/3] dax: Add an enum for specifying dax wakup mode

2021-04-21 Thread Matthew Wilcox
On Wed, Apr 21, 2021 at 11:56:31AM -0400, Vivek Goyal wrote: > +/** > + * enum dax_entry_wake_mode: waitqueue wakeup toggle s/toggle/behaviour/ ? > + * @WAKE_NEXT: wake only the first waiter in the waitqueue > + * @WAKE_ALL: wake all waiters in the waitqueue > + */ > +enum dax_entry_wake_mode {

Re: [PATCH v3 1/3] dax: Add an enum for specifying dax wakup mode

2021-04-21 Thread Vivek Goyal
On Wed, Apr 21, 2021 at 11:24:40AM +0200, Jan Kara wrote: > On Mon 19-04-21 17:36:34, Vivek Goyal wrote: > > Dan mentioned that he is not very fond of passing around a boolean > > true/false > > to specify if only next waiter should be woken up or all waiters should be > > woken up. He instead

Re: [PATCH v3 1/3] dax: Add an enum for specifying dax wakup mode

2021-04-21 Thread Jan Kara
On Mon 19-04-21 17:36:34, Vivek Goyal wrote: > Dan mentioned that he is not very fond of passing around a boolean true/false > to specify if only next waiter should be woken up or all waiters should be > woken up. He instead prefers that we introduce an enum and make it very > explicity at the