Re: [PATCH] libnvdimm: Fix __nd_ioctl() to check error in cmd_rc

2018-11-07 Thread Dan Williams
On Wed, Nov 7, 2018 at 10:52 AM Toshi Kani wrote: > > ndctl zero-labels completes with a large number of zeroed nmems when > it fails to do zeroing on a protected NVDIMM. > > # ndctl zero-labels nmem1 > zeroed 65504 nmems > > When an ACPI call completes with error, xlat_status() called from >

Re: [daxctl PATCH] daxctl: Opt-in to /sys/bus/dax ABI

2018-11-07 Thread Dan Williams
On Wed, Nov 7, 2018 at 11:44 AM Jeff Moyer wrote: > > Dan Williams writes: > > > In support of the kernel's conversion of the dax-subsystem from a > > 'class' to a 'bus', teach the libdaxctl subsystem-layout-specific code > > to parse the new layout. The kernel changes do not effect the primary

Re: [RFC v2 01/14] kunit: test: add KUnit test runner core

2018-11-07 Thread Shuah Khan
On 11/06/2018 06:28 PM, Brendan Higgins wrote: > On Fri, Nov 2, 2018 at 11:44 AM Shuah Khan wrote: >> >> On 10/23/2018 05:57 PM, Brendan Higgins wrote: > >>> + * Example: >>> + * >>> + * .. code-block:: c >>> + * >>> + * void add_test_basic(struct test *test) >>> + * { >>> + *

Re: [RFC v2 00/14] kunit: introduce KUnit, the Linux kernel unit testing framework

2018-11-07 Thread Frank Rowand
On 11/6/18 5:17 PM, Brendan Higgins wrote: > On Fri, Nov 2, 2018 at 11:23 AM Shuah Khan wrote: >> >> Hi Brendan, > >> Framework looks good. I think it would be helpful to include a real test > > Great to hear! > >> in the patch series to get a feel for how effective it is. > > Alright, will

[PATCH] libnvdimm: Fix __nd_ioctl() to check error in cmd_rc

2018-11-07 Thread Toshi Kani
ndctl zero-labels completes with a large number of zeroed nmems when it fails to do zeroing on a protected NVDIMM. # ndctl zero-labels nmem1 zeroed 65504 nmems When an ACPI call completes with error, xlat_status() called from acpi_nfit_ctl() sets error to *cmd_rc. __nd_ioctl(), however,

Re: [PATCH] libnvdimm: Fix __nd_ioctl() to check error in cmd_rc

2018-11-07 Thread Kani, Toshi
On Wed, 2018-11-07 at 11:34 -0800, Dan Williams wrote: > On Wed, Nov 7, 2018 at 10:52 AM Toshi Kani wrote: > > > > ndctl zero-labels completes with a large number of zeroed nmems when > > it fails to do zeroing on a protected NVDIMM. > > > > # ndctl zero-labels nmem1 > > zeroed 65504 nmems