Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Matthew Wilcox
On Tue, Sep 22, 2020 at 12:23:45PM -0400, Qian Cai wrote: > On Fri, 2020-09-11 at 00:47 +0100, Matthew Wilcox (Oracle) wrote: > > Size the uptodate array dynamically to support larger pages in the > > page cache. With a 64kB page, we're only saving 8 bytes per page today, > > but with a 2MB

Re: NVFS XFS metadata (was: [PATCH] pmem: export the symbols __copy_user_flushcache and __copy_from_user_flushcache)

2020-09-22 Thread Matthew Wilcox
On Tue, Sep 22, 2020 at 12:46:05PM -0400, Mikulas Patocka wrote: > I agree that the b+tree were a good choice for XFS. > > In RAM-based maps, red-black trees or avl trees are used often. In > disk-based maps, btrees or b+trees are used. That's because in RAM, you > are optimizing for the number

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Qian Cai
On Tue, 2020-09-22 at 18:05 +0100, Matthew Wilcox wrote: > On Tue, Sep 22, 2020 at 12:23:45PM -0400, Qian Cai wrote: > > On Fri, 2020-09-11 at 00:47 +0100, Matthew Wilcox (Oracle) wrote: > > > Size the uptodate array dynamically to support larger pages in the > > > page cache. With a 64kB page,

Re: NVFS XFS metadata (was: [PATCH] pmem: export the symbols __copy_user_flushcache and __copy_from_user_flushcache)

2020-09-22 Thread Mikulas Patocka
On Tue, 22 Sep 2020, Matthew Wilcox wrote: > On Mon, Sep 21, 2020 at 12:20:42PM -0400, Mikulas Patocka wrote: > > The same for directories - NVFS hashes the file name and uses radix-tree > > to locate a directory page where the directory entry is located. XFS > > b+trees would result in much

[PATCH] kernel/resource: Fix use of ternary condition in release_mem_region_adjustable

2020-09-22 Thread Nathan Chancellor
Clang warns: kernel/resource.c:1281:53: warning: operator '?:' has lower precedence than '|'; '|' will be evaluated first [-Wbitwise-conditional-parentheses] new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0); ~

Re: [RFC] nvfs: a filesystem for persistent memory

2020-09-22 Thread Ritesh Harjani
On 9/15/20 6:30 PM, Matthew Wilcox wrote: On Tue, Sep 15, 2020 at 08:34:41AM -0400, Mikulas Patocka wrote: - when the fsck.nvfs tool mmaps the device /dev/pmem0, the kernel uses buffer cache for the mapping. The buffer cache slows does fsck by a factor of 5 to 10. Could it be possible to

Re: [PATCH] kernel/resource: Fix use of ternary condition in release_mem_region_adjustable

2020-09-22 Thread David Hildenbrand
On 22.09.20 08:07, Nathan Chancellor wrote: > Clang warns: > > kernel/resource.c:1281:53: warning: operator '?:' has lower precedence > than '|'; '|' will be evaluated first > [-Wbitwise-conditional-parentheses] > new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : > 0);

Re: NVFS XFS metadata (was: [PATCH] pmem: export the symbols __copy_user_flushcache and __copy_from_user_flushcache)

2020-09-22 Thread Matthew Wilcox
On Mon, Sep 21, 2020 at 12:20:42PM -0400, Mikulas Patocka wrote: > The same for directories - NVFS hashes the file name and uses radix-tree > to locate a directory page where the directory entry is located. XFS > b+trees would result in much more accesses than the radix-tree. What? Radix trees

Re: [RFC] nvfs: a filesystem for persistent memory

2020-09-22 Thread Ira Weiny
On Mon, Sep 21, 2020 at 12:19:07PM -0400, Mikulas Patocka wrote: > > > On Tue, 15 Sep 2020, Dan Williams wrote: > > > > TODO: > > > > > > - programs run approximately 4% slower when running from Optane-based > > > persistent memory. Therefore, programs and libraries should use page cache > > >

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Qian Cai
on_hash dm_log dm_mod [ 8805.895521][T445431] CPU: 61 PID: 445431 Comm: trinity-c61 Not tainted 5.9.0-rc6-next-20200922 #3 [ 8805.895551][T445431] NIP: c04734a0 LR: c047335c CTR: [ 8805.895571][T445431] REGS: c01fe5427620 TRAP: 0700 Not tainted (5.9.0-rc6-next-20

Re: NVFS XFS metadata (was: [PATCH] pmem: export the symbols __copy_user_flushcache and __copy_from_user_flushcache)

2020-09-22 Thread Mikulas Patocka
Hi Thanks for reviewing NVFS. On Tue, 22 Sep 2020, Dave Chinner wrote: > Hi Mikulas, > > I'll say up front that I think you're barking up the wrong tree > trying to knock down XFS and ext4 to justify NVFS. NVFS will stand > or fall on it's own merits, not on how you think it's better than >

Re: [PATCH v4 00/23] device-dax: Support sub-dividing soft-reserved ranges

2020-09-22 Thread Dan Williams
On Tue, Sep 8, 2020 at 3:46 AM David Hildenbrand wrote: > > On 22.08.20 01:21, Andrew Morton wrote: > > On Wed, 19 Aug 2020 18:53:57 -0700 Dan Williams > > wrote: > > > >>> I think I am missing some important pieces. Bear with me. > >> > >> No worries, also bear with me, I'm going to be offline

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Qian Cai
On Tue, 2020-09-22 at 18:05 +0100, Matthew Wilcox wrote: > On Tue, Sep 22, 2020 at 12:23:45PM -0400, Qian Cai wrote: > > On Fri, 2020-09-11 at 00:47 +0100, Matthew Wilcox (Oracle) wrote: > > > Size the uptodate array dynamically to support larger pages in the > > > page cache. With a 64kB page,

Amazon.co.jp アカウント所有権の証明(名前、その他個人情報)の確認

2020-09-22 Thread Amazon.co.jp
平素は Amazon.co.jp をご利用いただき、誠にありがとうございます。 お客様のアカウントで異常なアクティビティが検出されたためAmazon アカウントを停止させていただいております。アカウントにログインして画面の指示に従うことで、アカウントのロックを解除していただけます。 Amazon ログイン 請求先情報の確認が完了するまで、お客様のアカウントへのアクセスを停止させていただきますので、ご了承ください。 異常なログインIP:185.137.106.252 何卒、よろしくお願い申し上げます。

New order

2020-09-22 Thread Tippawan Sonkhun
Hello linux-nvdimm,We are interested in your Products  which you displayed on the site and we want to purchase some of the products.Please send us more information about your company for our ref. with your conditions and terms as below,*Delivery time*Payment term ( LC or TT )*Minimum order

Re: NVFS XFS metadata (was: [PATCH] pmem: export the symbols __copy_user_flushcache and __copy_from_user_flushcache)

2020-09-22 Thread Dave Chinner
On Tue, Sep 22, 2020 at 12:46:05PM -0400, Mikulas Patocka wrote: > Thanks for reviewing NVFS. Not a review - I've just had a cursory look and not looked any deeper after I'd noticed various red flags... > On Tue, 22 Sep 2020, Dave Chinner wrote: > > IOWs, extent based trees were chosen because

Re: [x86/copy_mc] a0ac629ebe: fio.read_iops -43.3% regression

2020-09-22 Thread Dan Williams
On Thu, Aug 6, 2020 at 8:35 AM Ingo Molnar wrote: > > > * Dan Williams wrote: > > > On Thu, Aug 6, 2020 at 6:35 AM Ingo Molnar wrote: > > > > > > > > > * kernel test robot wrote: > > > > > > > Greeting, > > > > > > > > FYI, we noticed a -43.3% regression of fio.read_iops due to commit: > > > >

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Matthew Wilcox
On Tue, Sep 22, 2020 at 09:06:03PM -0400, Qian Cai wrote: > On Tue, 2020-09-22 at 18:05 +0100, Matthew Wilcox wrote: > > On Tue, Sep 22, 2020 at 12:23:45PM -0400, Qian Cai wrote: > > > On Fri, 2020-09-11 at 00:47 +0100, Matthew Wilcox (Oracle) wrote: > > > > Size the uptodate array dynamically to

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Darrick J. Wong
On Wed, Sep 23, 2020 at 03:48:59AM +0100, Matthew Wilcox wrote: > On Tue, Sep 22, 2020 at 09:06:03PM -0400, Qian Cai wrote: > > On Tue, 2020-09-22 at 18:05 +0100, Matthew Wilcox wrote: > > > On Tue, Sep 22, 2020 at 12:23:45PM -0400, Qian Cai wrote: > > > > On Fri, 2020-09-11 at 00:47 +0100,