Re: [ndctl PATCH] ndctl: --enable-destructive implies --enable-test

2016-07-29 Thread Ross Zwisler
On Fri, Jul 29, 2016 at 09:44:02PM -0700, Dan Williams wrote: > Currently the build fails if --enable-destructive is specified without > --enable-test, but --enable-destructive assumes that --enable-test is > already specified. Just force --enable-test to satisfy the requirement. > > Reported-by:

[ndctl PATCH] ndctl: --enable-destructive implies --enable-test

2016-07-29 Thread Dan Williams
Currently the build fails if --enable-destructive is specified without --enable-test, but --enable-destructive assumes that --enable-test is already specified. Just force --enable-test to satisfy the requirement. Reported-by: Ross Zwisler Signed-off-by: Dan Williams --- configure.ac | 14 +++

Re: [PATCH] ndctl: fix --enable-destructive build failure

2016-07-29 Thread Dan Williams
On Fri, Jul 29, 2016 at 3:02 PM, Ross Zwisler wrote: > This commit: > > commit 0d119368385a ("ndctl: reorganize file structure, use per sub-directory > makefiles") > > reorganized the file structure & makefiles in ndctl, but broke builds that > used the --enable-destructive option. Here are some

Re: Subtle races between DAX mmap fault and write path

2016-07-29 Thread Dan Williams
On Fri, Jul 29, 2016 at 5:12 PM, Dave Chinner wrote: > On Fri, Jul 29, 2016 at 07:44:25AM -0700, Dan Williams wrote: >> On Thu, Jul 28, 2016 at 7:21 PM, Dave Chinner wrote: >> > On Thu, Jul 28, 2016 at 10:10:33AM +0200, Jan Kara wrote: >> >> On Thu 28-07-16 08:19:49, Dave Chinner wrote: >> [..] >

Re: Subtle races between DAX mmap fault and write path

2016-07-29 Thread Dave Chinner
On Fri, Jul 29, 2016 at 07:44:25AM -0700, Dan Williams wrote: > On Thu, Jul 28, 2016 at 7:21 PM, Dave Chinner wrote: > > On Thu, Jul 28, 2016 at 10:10:33AM +0200, Jan Kara wrote: > >> On Thu 28-07-16 08:19:49, Dave Chinner wrote: > [..] > >> So DAX doesn't need flushing to maintain consistent view

[PATCH] ndctl: fix --enable-destructive build failure

2016-07-29 Thread Ross Zwisler
This commit: commit 0d119368385a ("ndctl: reorganize file structure, use per sub-directory makefiles") reorganized the file structure & makefiles in ndctl, but broke builds that used the --enable-destructive option. Here are some of the failure messages: ../test/blk_namespaces.o: In function

Re: [PATCH] block: remove BLK_DEV_DAX config option

2016-07-29 Thread Jens Axboe
On 07/29/2016 12:23 PM, Ross Zwisler wrote: The functionality for block device DAX was already removed with this commit: commit acc93d30d7d4 ("Revert "block: enable dax for raw block devices"") However, we still had a config option hanging around that was always disabled because it depended on

[PATCH] libnvdimm, nd_blk: mask off reserved status bits

2016-07-29 Thread Ross Zwisler
The "NVDIMM Block Window Driver Writer's Guide": http://pmem.io/documents/ http://pmem.io/documents/NVDIMM_DriverWritersGuide-July-2016.pdf defines the layout of the block window status register. For the July 2016 version of the spec linked to above, this happens in Figure 4 on page 26. The onl

Re: [PATCH] block: remove BLK_DEV_DAX config option

2016-07-29 Thread Dan Williams
On Fri, Jul 29, 2016 at 11:23 AM, Ross Zwisler wrote: > The functionality for block device DAX was already removed with this > commit: > > commit acc93d30d7d4 ("Revert "block: enable dax for raw block devices"") > > However, we still had a config option hanging around that was always > disabled be

[PATCH] block: remove BLK_DEV_DAX config option

2016-07-29 Thread Ross Zwisler
The functionality for block device DAX was already removed with this commit: commit acc93d30d7d4 ("Revert "block: enable dax for raw block devices"") However, we still had a config option hanging around that was always disabled because it depended on CONFIG_BROKEN. This config option was introdu

Re: Subtle races between DAX mmap fault and write path

2016-07-29 Thread Dan Williams
On Thu, Jul 28, 2016 at 7:21 PM, Dave Chinner wrote: > On Thu, Jul 28, 2016 at 10:10:33AM +0200, Jan Kara wrote: >> On Thu 28-07-16 08:19:49, Dave Chinner wrote: [..] >> So DAX doesn't need flushing to maintain consistent view of the data but it >> does need flushing to make sure fsync(2) results

Re: HPE SMART data retreival

2016-07-29 Thread Johannes Thumshirn
On Thu, Jul 28, 2016 at 01:43:17PM -0400, Linda Knippers wrote: [...] > > +acpi_nfit_decode_dsm_mask_from_hpe2(unsigned long dsm_mask) > > +{ > > + unsigned long cmd_mask = 0; > > + > > + if (test_bit(1, &dsm_mask)) > > + set_bit(ND_CMD_SMART, &dsm_mask); > > + if (test_bit(2, &ds