Re: [PATCH 12/20] mm: Factor out common parts of write fault handling

2016-10-17 Thread Ross Zwisler
On Tue, Sep 27, 2016 at 06:08:16PM +0200, Jan Kara wrote: > Currently we duplicate handling of shared write faults in > wp_page_reuse() and do_shared_fault(). Factor them out into a common > function. > > Signed-off-by: Jan Kara > --- > mm/memory.c | 78 >

Re: [PATCH 10/20] mm: Move handling of COW faults into DAX code

2016-10-17 Thread Ross Zwisler
On Tue, Sep 27, 2016 at 06:08:14PM +0200, Jan Kara wrote: > Move final handling of COW faults from generic code into DAX fault > handler. That way generic code doesn't have to be aware of peculiarities > of DAX locking so remove that knowledge. > > Signed-off-by: Jan Kara > --- >

Re: [PATCH 0/20 v3] dax: Clear dirty bits after flushing caches

2016-10-17 Thread Ross Zwisler
On Mon, Oct 17, 2016 at 10:47:32AM +0200, Jan Kara wrote: > This week I plan to rebase both series on top of rc1 + your THP patches so > that we can move on with merging the stuff. Yea...so how are we going to coordinate merging of these series for the v4.10 merge window? My series mostly

Re: [PATCH] DAX: enable iostat for read/write

2016-10-17 Thread Dan Williams
On Mon, Oct 17, 2016 at 10:40 AM, Kani, Toshimitsu wrote: > On Sat, 2016-10-15 at 18:54 +1100, Dave Chinner wrote: >> On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote: > : >> > +static void dax_iostat_start(struct gendisk *disk, struct iov_iter >> > *iter, >> > +

Re: [PATCH v2] DAX: enable iostat for read/write

2016-10-17 Thread Kani, Toshimitsu
On Mon, 2016-10-17 at 11:29 -0600, Ross Zwisler wrote: > On Mon, Oct 17, 2016 at 11:18:58AM -0600, Toshi Kani wrote: > > > > DAX IO path does not support iostat, but its metadata IO path does. > > Therefore, iostat shows metadata IO statistics only, which has been > > confusing to users. > > > >

Re: [PATCH] DAX: enable iostat for read/write

2016-10-17 Thread Kani, Toshimitsu
On Sat, 2016-10-15 at 18:54 +1100, Dave Chinner wrote: > On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote:  : > > +static void dax_iostat_start(struct gendisk *disk, struct iov_iter > > *iter, > > +  unsigned long *start) > > +{ > > + int rw = iov_iter_rw(iter); >

Re: [PATCH 09/20] mm: Factor out functionality to finish page faults

2016-10-17 Thread Ross Zwisler
On Tue, Sep 27, 2016 at 06:08:13PM +0200, Jan Kara wrote: > Introduce function finish_fault() as a helper function for finishing > page faults. It is rather thin wrapper around alloc_set_pte() but since > we'd want to call this from DAX code or filesystems, it is still useful > to avoid some

Re: [PATCH 09/20] mm: Factor out functionality to finish page faults

2016-10-17 Thread Ross Zwisler
On Tue, Sep 27, 2016 at 06:08:13PM +0200, Jan Kara wrote: > Introduce function finish_fault() as a helper function for finishing > page faults. It is rather thin wrapper around alloc_set_pte() but since > we'd want to call this from DAX code or filesystems, it is still useful > to avoid some

Re: [PATCH v2] DAX: enable iostat for read/write

2016-10-17 Thread Ross Zwisler
On Mon, Oct 17, 2016 at 11:18:58AM -0600, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note, iostat still

[PATCH v2] DAX: enable iostat for read/write

2016-10-17 Thread Toshi Kani
DAX IO path does not support iostat, but its metadata IO path does. Therefore, iostat shows metadata IO statistics only, which has been confusing to users. Add iostat support to the DAX read/write path. Note, iostat still does not support the DAX mmap path as it allows user applications to

Re: [PATCH 08/20] mm: Allow full handling of COW faults in ->fault handlers

2016-10-17 Thread Ross Zwisler
On Tue, Sep 27, 2016 at 06:08:12PM +0200, Jan Kara wrote: > To allow full handling of COW faults add memcg field to struct vm_fault > and a return value of ->fault() handler meaning that COW fault is fully > handled and memcg charge must not be canceled. This will allow us to > remove knowledge

[PATCH -next] libnvdimm: fix error return code in __blk_label_update()

2016-10-17 Thread Wei Yongjun
From: Wei Yongjun Fix to return error code -ENXIO from the nd_label_alloc_slot() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/nvdimm/label.c | 4 +++- 1 file changed, 3

Re: [PATCH v6 17/17] dax: remove "depends on BROKEN" from FS_DAX_PMD

2016-10-17 Thread Jan Kara
On Mon 17-10-16 11:27:24, Aneesh Kumar K.V wrote: > Ross Zwisler writes: > > > Now that DAX PMD faults are once again working and are now participating in > > DAX's radix tree locking scheme, allow their config option to be enabled. > > > > Signed-off-by: Ross

Re: [PATCH 03/20] mm: Use pgoff in struct vm_fault instead of passing it separately

2016-10-17 Thread Jan Kara
On Fri 14-10-16 12:42:51, Ross Zwisler wrote: > On Tue, Sep 27, 2016 at 06:08:07PM +0200, Jan Kara wrote: > > struct vm_fault has already pgoff entry. Use it instead of passing pgoff > > as a separate argument and then assigning it later. > > > > Signed-off-by: Jan Kara > > --- > >

Re: [PATCH 0/20 v3] dax: Clear dirty bits after flushing caches

2016-10-17 Thread Jan Kara
On Thu 13-10-16 14:34:34, Ross Zwisler wrote: > On Mon, Oct 03, 2016 at 01:13:58PM +0200, Jan Kara wrote: > > On Mon 03-10-16 02:32:48, Christoph Hellwig wrote: > > > On Mon, Oct 03, 2016 at 10:15:49AM +0200, Jan Kara wrote: > > > > Yeah, so DAX path is special because it installs its own PTE

Re: [PATCH v7 15/17] dax: add struct iomap based DAX PMD support

2016-10-17 Thread Aneesh Kumar K.V
Ross Zwisler writes: > DAX PMDs have been disabled since Jan Kara introduced DAX radix tree based > locking. This patch allows DAX PMDs to participate in the DAX radix tree > based locking scheme so that they can be re-enabled using the new struct > iomap based