Re: [ndctl PATCH] ndctl: add an api for getting ars_status flags

2018-06-05 Thread Verma, Vishal L
On Tue, 2018-06-05 at 19:07 -0700, Dan Williams wrote: > On Tue, Jun 5, 2018 at 5:00 PM, Vishal Verma > wrote: > > The ARS status command defines a 'flags' field that wasn't being > > exposed > > via an API yet. Add a new ndctl_cmd_ars_get_flags() helper to retrieve > > this field. > > > >

Re: [ndctl PATCH] ndctl: add an api for getting ars_status flags

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 5:00 PM, Vishal Verma wrote: > The ARS status command defines a 'flags' field that wasn't being exposed > via an API yet. Add a new ndctl_cmd_ars_get_flags() helper to retrieve > this field. > > Reported-by: Jacek Zloch > Cc: Dan Williams > Signed-off-by: Vishal Verma

Re: [PATCH v2 3/3] libnvdimm: don't flush power-fail protected CPU caches

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 4:58 PM, Ross Zwisler wrote: > This commit: > > 5fdf8e5ba566 ("libnvdimm: re-enable deep flush for pmem devices via fsync()") > > intended to make sure that deep flush was always available even on > platforms which support a power-fail protected CPU cache. An unintended >

Re: [Qemu-devel] Questions about vNVDIMM on qemu/KVM

2018-06-05 Thread Yasunori Goto
> Hi, > > > > > > I'm investigating status of vNVDIMM on qemu/KVM, > > > and I have some questions about it. I'm glad if anyone answer them. > > > > > > In my understanding, qemu/KVM has a feature to show NFIT for guest, > > > and it will be still updated about platform capability with this

[ndctl PATCH] ndctl: add an api for getting ars_status flags

2018-06-05 Thread Vishal Verma
The ARS status command defines a 'flags' field that wasn't being exposed via an API yet. Add a new ndctl_cmd_ars_get_flags() helper to retrieve this field. Reported-by: Jacek Zloch Cc: Dan Williams Signed-off-by: Vishal Verma --- ndctl/lib/ars.c| 10 ++ ndctl/lib/libndctl.sym

[ndctl PATCH v3] ndctl: refactor validation of the ars_status command

2018-06-05 Thread Vishal Verma
The APIs that iterate over the information contained in an ars_atatus command require a prior, successfully completed ars_status command struct. We were neglecting to verify that the firmware status too indicates a success. We were also incorrectly requiring that ars_status->status be zero, where

[PATCH v2 1/3] libnvdimm: unconditionally deep flush on *sync

2018-06-05 Thread Ross Zwisler
Prior to this commit we would only do a "deep flush" in response to an msync/fsync/sync call if the nvdimm_has_cache() returned true at the time we were setting up the request queue. This happens due to the write cache value passed in to blk_queue_write_cache(). We do have a "write_cache" sysfs

[PATCH v2 3/3] libnvdimm: don't flush power-fail protected CPU caches

2018-06-05 Thread Ross Zwisler
This commit: 5fdf8e5ba566 ("libnvdimm: re-enable deep flush for pmem devices via fsync()") intended to make sure that deep flush was always available even on platforms which support a power-fail protected CPU cache. An unintended side effect of this change was that we also lost the ability to

[PATCH v2 2/3] libnvdimm: use dax_write_cache* helpers

2018-06-05 Thread Ross Zwisler
Use dax_write_cache() and dax_write_cache_enabled() instead of open coding the bit operations. Signed-off-by: Ross Zwisler --- drivers/dax/super.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index

Re: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 3:07 PM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: >> On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: >> > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler >> > wrote: >> > > On Tue, Jun 05, 2018 at 06:25:27PM

Re: [PATCH 2/2] libnvdimm: don't flush power-fail protected CPU caches

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 2:59 PM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 02:20:38PM -0700, Dan Williams wrote: >> On Tue, Jun 5, 2018 at 1:58 PM, Ross Zwisler >> wrote: >> > This commit: >> > >> > 5fdf8e5ba566 ("libnvdimm: re-enable deep flush for pmem devices via >> > fsync()") >> > >> >

Re: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Ross Zwisler
On Tue, Jun 05, 2018 at 09:37:25PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: > > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler > > wrote: > > > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: > > >> On Mon, May 21, 2018 at

Re: [PATCH 2/2] libnvdimm: don't flush power-fail protected CPU caches

2018-06-05 Thread Ross Zwisler
On Tue, Jun 05, 2018 at 02:20:38PM -0700, Dan Williams wrote: > On Tue, Jun 5, 2018 at 1:58 PM, Ross Zwisler > wrote: > > This commit: > > > > 5fdf8e5ba566 ("libnvdimm: re-enable deep flush for pmem devices via > > fsync()") > > > > intended to make sure that deep flush was always available even

Re: [PATCH 2/2] libnvdimm: don't flush power-fail protected CPU caches

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 1:58 PM, Ross Zwisler wrote: > This commit: > > 5fdf8e5ba566 ("libnvdimm: re-enable deep flush for pmem devices via fsync()") > > intended to make sure that deep flush was always available even on > platforms which support a power-fail protected CPU cache. An unintended >

[PATCH 1/2] libnvdimm: use dax_write_cache* helpers

2018-06-05 Thread Ross Zwisler
Use dax_write_cache() and dax_write_cache_enabled() instead of open coding the bit operations. Signed-off-by: Ross Zwisler --- drivers/dax/super.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index

[PATCH 2/2] libnvdimm: don't flush power-fail protected CPU caches

2018-06-05 Thread Ross Zwisler
This commit: 5fdf8e5ba566 ("libnvdimm: re-enable deep flush for pmem devices via fsync()") intended to make sure that deep flush was always available even on platforms which support a power-fail protected CPU cache. An unintended side effect of this change was that we also lost the ability to

Re: KASAN vs ZONE_DEVICE (was: Re: [PATCH v2 2/7] dax: change bdev_dax_supported()...)

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 7:01 AM, Andrey Ryabinin wrote: > > > On 06/05/2018 07:22 AM, Dan Williams wrote: >> On Mon, Jun 4, 2018 at 8:32 PM, Dan Williams >> wrote: >>> [ adding KASAN devs...] >>> >>> On Mon, Jun 4, 2018 at 4:40 PM, Dan Williams >>> wrote: On Sun, Jun 3, 2018 at 6:48 PM,

Re: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 11:15:00AM -0700, Dan Williams wrote: > On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler > wrote: > > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: > >> On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: > >> > Add a machine command line option

Re: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 9:42 AM, Ross Zwisler wrote: > On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: >> On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: >> > Add a machine command line option to allow the user to control the Platform >> > Capabilities Structure

Re: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Ross Zwisler
On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote: > On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: > > Add a machine command line option to allow the user to control the Platform > > Capabilities Structure in the virtualized NFIT. This Platform Capabilities > >

回复:Ø  MRO采购专业人员如何提升自己的专业技能

2018-06-05 Thread 请转交相关单位
___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-06-05 Thread Michael S. Tsirkin
On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote: > Add a machine command line option to allow the user to control the Platform > Capabilities Structure in the virtualized NFIT. This Platform Capabilities > Structure was added in ACPI 6.2 Errata A. > > Signed-off-by: Ross Zwisler I

Re: [PATCH v2 00/11] mm: Teach memory_failure() about ZONE_DEVICE pages

2018-06-05 Thread Dan Williams
On Tue, Jun 5, 2018 at 7:11 AM, Michal Hocko wrote: > On Mon 04-06-18 07:31:25, Dan Williams wrote: > [...] >> I'm trying to solve this real world problem when real poison is >> consumed through a dax mapping: >> >> mce: Uncorrected hardware memory error in user-access at af34214200 >>

Re: [PATCH v2 00/11] mm: Teach memory_failure() about ZONE_DEVICE pages

2018-06-05 Thread Michal Hocko
On Mon 04-06-18 07:31:25, Dan Williams wrote: [...] > I'm trying to solve this real world problem when real poison is > consumed through a dax mapping: > > mce: Uncorrected hardware memory error in user-access at af34214200 > {1}[Hardware Error]: It has been corrected by h/w and

Re: KASAN vs ZONE_DEVICE (was: Re: [PATCH v2 2/7] dax: change bdev_dax_supported()...)

2018-06-05 Thread Andrey Ryabinin
On 06/05/2018 07:22 AM, Dan Williams wrote: > On Mon, Jun 4, 2018 at 8:32 PM, Dan Williams wrote: >> [ adding KASAN devs...] >> >> On Mon, Jun 4, 2018 at 4:40 PM, Dan Williams >> wrote: >>> On Sun, Jun 3, 2018 at 6:48 PM, Dan Williams >>> wrote: On Sun, Jun 3, 2018 at 5:25 PM, Dave

Re: KASAN vs ZONE_DEVICE (was: Re: [PATCH v2 2/7] dax: change bdev_dax_supported()...)

2018-06-05 Thread Dmitry Vyukov
On Tue, Jun 5, 2018 at 6:22 AM, Dan Williams wrote: > On Mon, Jun 4, 2018 at 8:32 PM, Dan Williams wrote: >> [ adding KASAN devs...] >> >> On Mon, Jun 4, 2018 at 4:40 PM, Dan Williams >> wrote: >>> On Sun, Jun 3, 2018 at 6:48 PM, Dan Williams >>> wrote: On Sun, Jun 3, 2018 at 5:25 PM,