Re: [PATCH 2/2] nfit, test: cleanup test scripts

2018-06-18 Thread Verma, Vishal L
On Thu, 2018-06-14 at 15:43 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Cleanup some test scripts by using helper functions. > > Signed-off-by: Masayoshi Mizuma > --- > test/blk-exhaust.sh | 21 ++-- > test/btt-check.sh | 52

Re: [PATCH] tools/testing/nvdimm: advertise a write cache for nfit_test

2018-06-18 Thread Ross Zwisler
On Mon, Jun 18, 2018 at 05:17:02PM -0600, Vishal Verma wrote: > Commit 546eb0317cfa "libnvdimm, pmem: Do not flush power-fail protected CPU > caches" > fixed the write_cache detection to correctly show the lack of a write > cache based on the platform capabilities described in the ACPI NFIT. The

[PATCH] tools/testing/nvdimm: advertise a write cache for nfit_test

2018-06-18 Thread Vishal Verma
Commit 546eb0317cfa "libnvdimm, pmem: Do not flush power-fail protected CPU caches" fixed the write_cache detection to correctly show the lack of a write cache based on the platform capabilities described in the ACPI NFIT. The nfit_test unit tests expected a write cache to be present, so change

Re: [PATCH] libnvdimm, pmem: Fix memcpy_mcsafe() return code handling in nsio_rw_bytes()

2018-06-18 Thread Jeff Moyer
Dan Williams writes: > Commit 60622d68227d "x86/asm/memcpy_mcsafe: Return bytes remaining" > converted callers of memcpy_mcsafe() to expect a positive 'bytes > remaining' value rather than a negative error code. The nsio_rw_bytes() > conversion failed to return success. The failure is benign in

Re: [ndctl PATCH] ndctl, test: Update tests for capacity vs namespace-label locking

2018-06-18 Thread Dan Williams
On Mon, Jun 18, 2018 at 2:35 PM, Vishal Verma wrote: > On 06/14, Dan Williams wrote: >> Check that namespaces can be enumerated, but are disabled if the labels >> are readable while the DIMM is locked. Alternatively, if the namespace >> label area is locked, validate that regions with the

Re: [PATCH v3 1/2] acpi/nfit: Update nfit driver to comply with ACPI 6.1

2018-06-18 Thread Dan Williams
On Mon, Jun 18, 2018 at 2:37 PM, Elliott, Robert (Persistent Memory) wrote: > > >> -Original Message- >> From: Dan Williams [mailto:dan.j.willi...@intel.com] >> Sent: Monday, June 18, 2018 2:47 PM >> To: Kani, Toshi >> Cc: linux-ker...@vger.kernel.org; linux-nvdimm@lists.01.org; Moore,

RE: [PATCH v3 1/2] acpi/nfit: Update nfit driver to comply with ACPI 6.1

2018-06-18 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Monday, June 18, 2018 2:47 PM > To: Kani, Toshi > Cc: linux-ker...@vger.kernel.org; linux-nvdimm@lists.01.org; Moore, Robert > ; Li, Juston ; > r...@rjwysocki.net; linux-a...@vger.kernel.org; Elliott,

Re: [PATCH v3 1/2] acpi/nfit: Update nfit driver to comply with ACPI 6.1

2018-06-18 Thread Dan Williams
On Mon, Jun 18, 2018 at 12:39 PM, Kani, Toshi wrote: > On Mon, 2018-06-18 at 12:01 -0700, Dan Williams wrote: >> On Mon, Apr 25, 2016 at 2:43 PM Toshi Kani wrote: >> > >> > ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure >> > as follows. >> > - Valid Fields, Manufacturing

Re: [PATCH] libnvdimm, pmem: Fix memcpy_mcsafe() return code handling in nsio_rw_bytes()

2018-06-18 Thread Vishal Verma
On 06/18, Dan Williams wrote: > Commit 60622d68227d "x86/asm/memcpy_mcsafe: Return bytes remaining" > converted callers of memcpy_mcsafe() to expect a positive 'bytes > remaining' value rather than a negative error code. The nsio_rw_bytes() > conversion failed to return success. The failure is

Re: [PATCH v3 1/2] acpi/nfit: Update nfit driver to comply with ACPI 6.1

2018-06-18 Thread Dan Williams
On Mon, Apr 25, 2016 at 2:43 PM Toshi Kani wrote: > > ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure > as follows. > - Valid Fields, Manufacturing Location, and Manufacturing Date >are added from reserved range. No change in the structure size. > - IDs (SPD values) are

[PATCH] libnvdimm, pmem: Fix memcpy_mcsafe() return code handling in nsio_rw_bytes()

2018-06-18 Thread Dan Williams
Commit 60622d68227d "x86/asm/memcpy_mcsafe: Return bytes remaining" converted callers of memcpy_mcsafe() to expect a positive 'bytes remaining' value rather than a negative error code. The nsio_rw_bytes() conversion failed to return success. The failure is benign in that nsio_rw_bytes() will end

Re: [PATCH] x86: optimize memcpy_flushcache

2018-06-18 Thread Dan Williams
On Mon, Jun 18, 2018 at 5:50 AM, Mikulas Patocka wrote: > Hi Mike > > Could you please push this patch to the kernel 4.18-rc? Dan Williams said > that he will submit it, but he forgot about it. ...to be clear I acked it and asked Ingo to take it. Will need a resubmit for 4.19. Ingo, see below

Re: x86: optimize memcpy_flushcache

2018-06-18 Thread Mike Snitzer
On Mon, Jun 18 2018 at 8:50am -0400, Mikulas Patocka wrote: > Hi Mike > > Could you please push this patch to the kernel 4.18-rc? Dan Williams said > that he will submit it, but he forgot about it. > > Without this patch, dm-writecache is suffering 2% penalty because of > memcpy_flushcache

[PATCH] x86: optimize memcpy_flushcache

2018-06-18 Thread Mikulas Patocka
Hi Mike Could you please push this patch to the kernel 4.18-rc? Dan Williams said that he will submit it, but he forgot about it. Without this patch, dm-writecache is suffering 2% penalty because of memcpy_flushcache overhead. Mikulas From: Mikulas Patocka I use memcpy_flushcache in my

[PATCH v7 3/3] ndctl, monitor: add the unit file of systemd for ndctl-monitor service

2018-06-18 Thread QI Fuli
This patch adds the systemd unit file for ndctl-monitor service. The systemd unit directory can be configured by setting environment variable "--with-systemd-unit-dir[=DIR]". A monitor daemon can be started as a system service: # systemctl start ndctl-monitor.service Signed-off-by: QI Fuli

[PATCH v7 2/3] ndctl, monitor: add main ndctl monitor configuration file

2018-06-18 Thread QI Fuli
This patch adds the main configuration file(/etc/ndctl/monitor.conf) of ndctl monitor. It contains the configuration directives that give ndctl monitor instructions. Users can change the configuration by editing this file or by using [--config-file=] option to override this file. The changed value

[PATCH v7 1/3] ndctl, monitor: add ndctl monitor

2018-06-18 Thread QI Fuli
Ndctl monitor is used for monitoring the smart events of nvdimm DIMMs. When a smart event fires, monitor will output the notifications which including dimm health status and event infomations to syslog, stderr or a logfile by setting [--logfile] option. The notifications follow json format and can

[PATCH v7 0/3] ndctl, monitor: add ndctl monitor daemon

2018-06-18 Thread QI Fuli
This is the v7 patch for ndctl monitor, a tiny daemon to monitor the smart events of nvdimm DIMMs. Since NVDIMM does not have a feature like mirroring, if it breaks down, the data will be impossible to restore. Ndctl monitor daemon will catch the smart events notify from firmware and outputs