Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type

2019-11-12 Thread Dan Williams
On Tue, Nov 12, 2019 at 10:02 PM Aneesh Kumar K.V wrote: > > On 11/13/19 6:56 AM, Dan Williams wrote: > > On Tue, Nov 12, 2019 at 1:23 AM Aneesh Kumar K.V > > wrote: > >> > >> Dan Williams writes: > >> > >>> A 'struct device_type' instance can carry default attributes for the > >>> device. Use

Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type

2019-11-12 Thread Aneesh Kumar K.V
On 11/13/19 6:56 AM, Dan Williams wrote: On Tue, Nov 12, 2019 at 1:23 AM Aneesh Kumar K.V wrote: Dan Williams writes: A 'struct device_type' instance can carry default attributes for the device. Use this facility to remove the export of nd_numa_attribute_group and put the responsibility on

Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type

2019-11-12 Thread Dan Williams
On Tue, Nov 12, 2019 at 1:23 AM Aneesh Kumar K.V wrote: > > Dan Williams writes: > > > A 'struct device_type' instance can carry default attributes for the > > device. Use this facility to remove the export of > > nd_numa_attribute_group and put the responsibility on the core rather > > than

Re: DAX filesystem support on ARMv8

2019-11-12 Thread Matthew Wilcox
On Tue, Nov 12, 2019 at 09:15:18AM -0800, Dan Williams wrote: > On Mon, Nov 11, 2019 at 6:12 PM Bharat Kumar Gogada > wrote: > > > > Hi All, > > > > As per Documentation/filesystems/dax.txt > > > > The DAX code does not work correctly on architectures which have virtually > > mapped caches such

Re: [PATCH 00/16] Memory Hierarchy: Enable target node lookups for reserved memory

2019-11-12 Thread Dan Williams
On Tue, Nov 12, 2019 at 3:43 AM Aneesh Kumar K.V wrote: > > Dan Williams writes: > > > Yes, this patch series looks like a pile of boring libnvdimm cleanups, > > but buried at the end are some small gems that testing with libnvdimm > > uncovered. These gems will prove more valuable over time for

Re: [ndctl PATCH v2 1/2] ndctl/namespace: Rework counts reported by enable-namespace

2019-11-12 Thread Verma, Vishal L
On Tue, 2019-11-05 at 10:27 -0700, Vishal Verma wrote: > Add detection of 'seed' namespaces > (ndctl_namespace_is_configuration_idle()) to the enable-namespace > operatiuon and libndctl API. In libndctl, return a '1' for seed > namespaces. In namespace.c, reinterpret a '1' based on a check for a

Re: DAX filesystem support on ARMv8

2019-11-12 Thread Dan Williams
On Mon, Nov 11, 2019 at 6:12 PM Bharat Kumar Gogada wrote: > > Hi All, > > As per Documentation/filesystems/dax.txt > > The DAX code does not work correctly on architectures which have virtually > mapped caches such as ARM, MIPS and SPARC. > > Can anyone please shed light on dax filesystem issue

Re: [PATCH 11/16] libnvdimm: Simplify root read-only definition for the 'resource' attribute

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > Rather than update the permission in ->is_visible() set the permission > directly at declaration time. > Reviewed-by: Aneesh Kumar K.V > Cc: Ira Weiny > Cc: Vishal Verma > Signed-off-by: Dan Williams > --- > drivers/nvdimm/namespace_devs.c |9 +++-- >

Re: [PATCH 10/16] dax: Simplify root read-only definition for the 'resource' attribute

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > Rather than update the permission in ->is_visible() set the permission > directly at declaration time. > Reviewed-by: Aneesh Kumar K.V > Cc: Ira Weiny > Cc: Vishal Verma > Signed-off-by: Dan Williams > --- > drivers/dax/bus.c |4 +--- > 1 file changed, 1

Re: [PATCH 09/16] dax: Create a dax device_type

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > Move the open coded release method and attribute groups to a 'struct > device_type' instance. > Reviewed-by: Aneesh Kumar K.V > Cc: Ira Weiny > Cc: Vishal Verma > Signed-off-by: Dan Williams > --- > drivers/dax/bus.c |8 ++-- > 1 file changed, 6

Re: [PATCH 12/16] dax: Add numa_node to the default device-dax attributes

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > It is confusing that device-dax instances publish a 'target_node' > attribute, but not a 'numa_node'. The 'numa_node' information is > available elsewhere in the sysfs device hierarchy, but it is not obvious > and not reliable from one device-dax instance-type (e.g. child

Re: [PATCH 08/16] libnvdimm: Move nvdimm_bus_attribute_group to device_type

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > A 'struct device_type' instance can carry default attributes for the > device. Use this facility to remove the export of > nvdimm_bus_attribute_group and put the responsibility on the core rather > than leaf implementations to define this attribute. > Reviewed-by: Aneesh

Re: [PATCH 07/16] libnvdimm: Move nvdimm_attribute_group to device_type

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > A 'struct device_type' instance can carry default attributes for the > device. Use this facility to remove the export of > nvdimm_attribute_group and put the responsibility on the core rather > than leaf implementations to define this attribute. > Reviewed-by: Aneesh Kumar

Re: [PATCH 06/16] libnvdimm: Move nd_mapping_attribute_group to device_type

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > A 'struct device_type' instance can carry default attributes for the > device. Use this facility to remove the export of > nd_mapping_attribute_group and put the responsibility on the core rather > than leaf implementations to define this attribute. > Reviewed-by: Aneesh

Re: [PATCH 05/16] libnvdimm: Move nd_region_attribute_group to device_type

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > A 'struct device_type' instance can carry default attributes for the > device. Use this facility to remove the export of > nd_region_attribute_group and put the responsibility on the core rather > than leaf implementations to define this attribute. > Reviewed-by: Aneesh

Re: [PATCH 00/16] Memory Hierarchy: Enable target node lookups for reserved memory

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > Yes, this patch series looks like a pile of boring libnvdimm cleanups, > but buried at the end are some small gems that testing with libnvdimm > uncovered. These gems will prove more valuable over time for Memory > Hierarchy management as more platforms, via the ACPI HMAT

Re: [PATCH 03/16] libnvdimm: Move nd_device_attribute_group to device_type

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > A 'struct device_type' instance can carry default attributes for the > device. Use this facility to remove the export of > nd_device_attribute_group and put the responsibility on the core rather > than leaf implementations to define this attribute. > > For regions this

Re: [PATCH 01/16] libnvdimm: Move attribute groups to device type

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > Statically initialize the attribute groups for each libnvdimm > device_type. This is a preparation step for removing unnecessary exports > of attributes that can be included in the device_type by default. > > Also take the opportunity to mark 'struct device_type' instances

Re: [PATCH 02/16] libnvdimm: Move region attribute group definition

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > In preparation for moving region attributes from device attribute groups > to the region device-type, reorder the declaration so that it can be > referenced by the device-type definition without forward declarations. > No functional changes are intended to result from this

Re: DAX filesystem support on ARMv8

2019-11-12 Thread Jan Kara
Hi! On Tue 12-11-19 02:12:09, Bharat Kumar Gogada wrote: > As per Documentation/filesystems/dax.txt > > The DAX code does not work correctly on architectures which have virtually > mapped caches such as ARM, MIPS and SPARC. > > Can anyone please shed light on dax filesystem issue w.r.t ARM

Re: Inquiry (REVISED PROFORMA) - Urgent!!

2019-11-12 Thread Paul Clever
___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org

Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type

2019-11-12 Thread Aneesh Kumar K.V
Dan Williams writes: > A 'struct device_type' instance can carry default attributes for the > device. Use this facility to remove the export of > nd_numa_attribute_group and put the responsibility on the core rather > than leaf implementations to define this attribute. > > Cc: Ira Weiny > Cc: