Re: [RFC v5 0/7] PMEM device emulation without nfit depenency

2020-12-16 Thread Santosh Sivaraj
Dan Williams writes: > Typically RFC means "not ready to apply, still seeking fundamental > approach feedback". Should I be looking to consider this for > v5.11-rc1, or is this still RFC / should wait for v5.12? I would like this to go in, after your comments to the previously RFC, I guess this

Re: [RFC v5 1/7] testing/nvdimm: Add test module for non-nfit platforms

2020-12-16 Thread Santosh Sivaraj
Dan Williams writes: > On Mon, Dec 14, 2020 at 2:39 AM Santosh Sivaraj wrote: >> >> The current test module cannot be used for testing platforms (make check) >> that do not have support for NFIT. In order to get the ndctl tests working, >> we need a module which can emulate NVDIMM devices

Re: [ndctl PATCH 6/8] lib/inject: check whether cmd is created successfully

2020-12-16 Thread Zhiqiang Liu
On 2020/12/17 11:33, Verma, Vishal L wrote: > On Fri, 2020-11-06 at 17:27 +0800, Zhiqiang Liu wrote: >> ndctl_bus_cmd_new_ars_cp() is called to create cmd, >> which may return NULL. We need to check whether it >> is NULL in callers, such as ndctl_namespace_get_clear_uint >> and

Re: [ndctl PATCH V2 0/8] fix serverl issues reported by Coverity

2020-12-16 Thread Zhiqiang Liu
On 2020/12/17 11:41, Verma, Vishal L wrote: > On Wed, 2020-11-25 at 09:00 +0800, Zhiqiang Liu wrote: >> Changes: V1->V2 >> - add one empty line in 1/8 patch as suggested by Jeff Moyer >> . >> >> >> Recently, we use Coverity to analysis the ndctl package. >> Several issues should be resolved to

Re: [ndctl PATCH V2 0/8] fix serverl issues reported by Coverity

2020-12-16 Thread Verma, Vishal L
On Wed, 2020-11-25 at 09:00 +0800, Zhiqiang Liu wrote: > Changes: V1->V2 > - add one empty line in 1/8 patch as suggested by Jeff Moyer > . > > > Recently, we use Coverity to analysis the ndctl package. > Several issues should be resolved to make Coverity happy. > > Zhiqiang Liu (8): >

Re: [ndctl PATCH 6/8] lib/inject: check whether cmd is created successfully

2020-12-16 Thread Verma, Vishal L
On Fri, 2020-11-06 at 17:27 +0800, Zhiqiang Liu wrote: > ndctl_bus_cmd_new_ars_cp() is called to create cmd, > which may return NULL. We need to check whether it > is NULL in callers, such as ndctl_namespace_get_clear_uint > and ndctl_namespace_injection_status. > > Signed-off-by: Zhiqiang Liu >

Re: [PATCH daxctl v2 0/5] daxctl: device align support

2020-12-16 Thread Verma, Vishal L
On Wed, 2020-12-16 at 22:48 +, Joao Martins wrote: > Hey, > > This series adds support for: > > 1) {create,reconfigure}-device for selecting @align (hugepage size). > Here we add a '-a|--align 4K|2M|1G' option to the existing commands; > > 2) Listing now displays align (if supported). >

Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference

2020-12-16 Thread Ira Weiny
On Tue, Dec 15, 2020 at 06:09:02PM -0800, Andy Lutomirski wrote: > On Tue, Dec 15, 2020 at 5:32 PM Ira Weiny wrote: > > > > On Fri, Dec 11, 2020 at 02:14:28PM -0800, Andy Lutomirski wrote: > > > On Mon, Nov 23, 2020 at 10:10 PM wrote: > > > > IOW we have: > > > > > > struct extended_pt_regs { >

Re: [PATCH ndctl v1 0/8] daxctl: Add device align and range mapping allocation

2020-12-16 Thread Dan Williams
On Wed, Dec 16, 2020 at 2:54 PM Joao Martins wrote: > > On 12/16/20 10:31 PM, Dan Williams wrote: > > On Wed, Dec 16, 2020 at 1:51 PM Joao Martins > > wrote: > >> > >> On 12/16/20 6:42 PM, Verma, Vishal L wrote: > >>> On Wed, 2020-12-16 at 11:39 +, Joao Martins wrote: > On 7/16/20 7:46

Re: [PATCH ndctl v1 0/8] daxctl: Add device align and range mapping allocation

2020-12-16 Thread Joao Martins
On 12/16/20 10:31 PM, Dan Williams wrote: > On Wed, Dec 16, 2020 at 1:51 PM Joao Martins > wrote: >> >> On 12/16/20 6:42 PM, Verma, Vishal L wrote: >>> On Wed, 2020-12-16 at 11:39 +, Joao Martins wrote: On 7/16/20 7:46 PM, Joao Martins wrote: > Hey, > > This series builds on

[PATCH daxctl v2 1/5] daxctl: add daxctl_dev_{get,set}_align()

2020-12-16 Thread Joao Martins
Add support for changing devices alignment. On kernels that do not support per-device align sysfs property we set it to 0. Signed-off-by: Joao Martins --- daxctl/lib/libdaxctl-private.h | 1 + daxctl/lib/libdaxctl.c | 36 daxctl/lib/libdaxctl.sym

[PATCH daxctl v2 5/5] daxctl/test: Add a test for daxctl-create with align

2020-12-16 Thread Joao Martins
Add a test which uses the newly added --align property which allows a device created with daxctl create-device to select its page size. If the available size is bigger than 1G then use 1G as page size, otherwise use 2M. Signed-off-by: Joao Martins --- test/daxctl-create.sh | 29

[PATCH daxctl v2 4/5] daxctl: add align support in create-device

2020-12-16 Thread Joao Martins
Allow changing devices alignment when creating a new child device. Signed-off-by: Joao Martins --- Documentation/daxctl/daxctl-create-device.txt | 8 daxctl/device.c | 8 2 files changed, 16 insertions(+) diff --git

[PATCH daxctl v2 3/5] daxctl: add align support in reconfigure-device

2020-12-16 Thread Joao Martins
Add an alignment option to reconfigure-device and use the newly added libdaxctl API to set the alignment of the device prior to setting size. Signed-off-by: Joao Martins --- Documentation/daxctl/daxctl-reconfigure-device.txt | 12 +++ daxctl/device.c|

[PATCH daxctl v2 2/5] util/json: Print device align

2020-12-16 Thread Joao Martins
Fetch device align and include it on listings. Signed-off-by: Joao Martins --- util/json.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/util/json.c b/util/json.c index 77bd4781551d..357dff20d6be 100644 --- a/util/json.c +++ b/util/json.c @@ -455,7 +455,7 @@ struct

[PATCH daxctl v2 0/5] daxctl: device align support

2020-12-16 Thread Joao Martins
Hey, This series adds support for: 1) {create,reconfigure}-device for selecting @align (hugepage size). Here we add a '-a|--align 4K|2M|1G' option to the existing commands; 2) Listing now displays align (if supported). Testing requires a 5.10+ kernel. v1 -> v2: * Fix listing of dax

Re: [PATCH ndctl v1 0/8] daxctl: Add device align and range mapping allocation

2020-12-16 Thread Dan Williams
On Wed, Dec 16, 2020 at 1:51 PM Joao Martins wrote: > > On 12/16/20 6:42 PM, Verma, Vishal L wrote: > > On Wed, 2020-12-16 at 11:39 +, Joao Martins wrote: > >> On 7/16/20 7:46 PM, Joao Martins wrote: > >>> Hey, > >>> > >>> This series builds on top of this one[0] and does the following > >>>

Re: [PATCH ndctl v1 0/8] daxctl: Add device align and range mapping allocation

2020-12-16 Thread Joao Martins
On 12/16/20 6:42 PM, Verma, Vishal L wrote: > On Wed, 2020-12-16 at 11:39 +, Joao Martins wrote: >> On 7/16/20 7:46 PM, Joao Martins wrote: >>> Hey, >>> >>> This series builds on top of this one[0] and does the following improvements >>> to the Soft-Reserved subdivision: >>> >>> 1) Support

Re: [PATCH ndctl v1 0/8] daxctl: Add device align and range mapping allocation

2020-12-16 Thread Joao Martins
On 12/16/20 7:13 PM, Dan Williams wrote: > On Wed, Dec 16, 2020 at 3:41 AM Joao Martins > wrote: >> >> On 7/16/20 7:46 PM, Joao Martins wrote: >>> Hey, >>> >>> This series builds on top of this one[0] and does the following improvements >>> to the Soft-Reserved subdivision: >>> >>> 1) Support

Re: [RFC PATCH v3 4/9] mm, fsdax: Refactor memory-failure handler for dax mapping

2020-12-16 Thread Dave Chinner
On Tue, Dec 15, 2020 at 08:14:09PM +0800, Shiyang Ruan wrote: > The current memory_failure_dev_pagemap() can only handle single-mapped > dax page for fsdax mode. The dax page could be mapped by multiple files > and offsets if we let reflink feature & fsdax mode work together. So, > we refactor

Re: [RFC PATCH v3 0/9] fsdax: introduce fs query to support reflink

2020-12-16 Thread Jane Chu
Hi, Shiyang, On 12/15/2020 4:14 AM, Shiyang Ruan wrote: The call trace is like this: memory_failure() pgmap->ops->memory_failure() => pmem_pgmap_memory_failure() gendisk->fops->corrupted_range() => - pmem_corrupted_range() -

Re: [PATCH ndctl v1 0/8] daxctl: Add device align and range mapping allocation

2020-12-16 Thread Dan Williams
On Wed, Dec 16, 2020 at 3:41 AM Joao Martins wrote: > > On 7/16/20 7:46 PM, Joao Martins wrote: > > Hey, > > > > This series builds on top of this one[0] and does the following improvements > > to the Soft-Reserved subdivision: > > > > 1) Support for {create,reconfigure}-device for selecting

Re: [PATCH ndctl v1 0/8] daxctl: Add device align and range mapping allocation

2020-12-16 Thread Verma, Vishal L
On Wed, 2020-12-16 at 11:39 +, Joao Martins wrote: > On 7/16/20 7:46 PM, Joao Martins wrote: > > Hey, > > > > This series builds on top of this one[0] and does the following improvements > > to the Soft-Reserved subdivision: > > > > 1) Support for {create,reconfigure}-device for selecting

Re: [PATCH ndctl v1 0/8] daxctl: Add device align and range mapping allocation

2020-12-16 Thread Joao Martins
On 7/16/20 7:46 PM, Joao Martins wrote: > Hey, > > This series builds on top of this one[0] and does the following improvements > to the Soft-Reserved subdivision: > > 1) Support for {create,reconfigure}-device for selecting @align (hugepage > size). > Here we add a '-a|--align 4K|2M|1G'

Re: [PATCH ndctl v2 10/10] daxctl/test: Add tests for dynamic dax regions

2020-12-16 Thread Joao Martins
On 12/16/20 10:25 AM, Verma, Vishal L wrote: > On Thu, 2020-12-10 at 15:01 +, Joao Martins wrote: >> On 7/21/20 5:49 PM, Joao Martins wrote: >>> On 7/13/20 5:08 PM, Joao Martins wrote: Add a couple tests which exercise the new sysfs based interface for Soft-Reserved regions (by

Re: [PATCH ndctl v2 10/10] daxctl/test: Add tests for dynamic dax regions

2020-12-16 Thread Verma, Vishal L
On Thu, 2020-12-10 at 15:01 +, Joao Martins wrote: > On 7/21/20 5:49 PM, Joao Martins wrote: > > On 7/13/20 5:08 PM, Joao Martins wrote: > > > Add a couple tests which exercise the new sysfs based > > > interface for Soft-Reserved regions (by EFI/HMAT, or > > > efi_fake_mem). > > > > > > The

Re: [PATCH ndctl v2 10/10] daxctl/test: Add tests for dynamic dax regions

2020-12-16 Thread Verma, Vishal L
On Thu, 2020-12-10 at 15:01 +, Joao Martins wrote: > On 7/21/20 5:49 PM, Joao Martins wrote: > > On 7/13/20 5:08 PM, Joao Martins wrote: > > > Add a couple tests which exercise the new sysfs based > > > interface for Soft-Reserved regions (by EFI/HMAT, or > > > efi_fake_mem). > > > > > > The