Re: [RESEND PATCH] nvdimm: fix some compilation warnings

2019-05-15 Thread Qian Cai
> On May 15, 2019, at 7:25 PM, Dan Williams wrote: > > On Tue, May 14, 2019 at 8:08 AM Qian Cai wrote: >> >> Several places (dimm_devs.c, core.c etc) include label.h but only >> label.c uses NSINDEX_SIGNATURE, so move its definition to label.c >> instead.

Re: [RESEND PATCH] nvdimm: fix some compilation warnings

2019-05-15 Thread Qian Cai
>>} >> >> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c >> index 7ff684159f29..2eb6a6cfe9e4 100644 >> --- a/drivers/nvdimm/bus.c >> +++ b/drivers/nvdimm/bus.c >> @@ -642,7 +642,7 @@ static struct attribute *nd_device_attributes[] = { >>NULL, >> }; >> >> -/**

[PATCH] nvdimm: fix compilation warnings with W=1

2019-05-16 Thread Qian Cai
e: 'struct attribute_group nd_numa_attribute_group = ' Those are just some member assignments for the "struct attribute_group" instances and it can't be expressed in the kernel-doc. Reviewed-by: Vishal Verma Signed-off-by: Qian Cai --- drivers/nvdimm/bus.c | 4 ++-- drivers/nvdimm/label.c |

[PATCH] nvdimm: fix some compilation warnings

2019-04-26 Thread Qian Cai
ich is only reserved for the kernel-doc. drivers/nvdimm/bus.c:648: warning: cannot understand function prototype: 'struct attribute_group nd_device_attribute_group = ' drivers/nvdimm/bus.c:677: warning: cannot understand function prototype: 'struct attribute_group nd_numa_attribute_group = ' Sig

Re: [RESEND PATCH] nvdimm: fix some compilation warnings

2019-06-26 Thread Qian Cai
On Thu, 2019-05-16 at 00:29 +, Verma, Vishal L wrote: > On Wed, 2019-05-15 at 17:26 -0700, Dan Williams wrote: > > On Wed, May 15, 2019 at 5:25 PM Verma, Vishal L > > wrote: > > > On Wed, 2019-05-15 at 16:25 -0700, Dan Williams wrote: > > > > > diff --git a/drivers/nvdimm/btt.c

devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-16 Thread Qian Cai
Every so often recently, booting Intel CPU server on linux-next triggers this warning. Trying to figure out if the commit 7cc7867fb061 ("mm/devm_memremap_pages: enable sub-section remap") is the culprit here. # ./scripts/faddr2line vmlinux devm_memremap_pages+0x894/0xc70

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-17 Thread Qian Cai
> On Aug 16, 2019, at 11:57 PM, Dan Williams wrote: > > On Fri, Aug 16, 2019 at 8:34 PM Qian Cai wrote: >> >> >> >>> On Aug 16, 2019, at 5:48 PM, Dan Williams wrote: >>> >>> On Fri, Aug 16, 2019 at 2:36 PM Qian Cai wrote: >&g

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-16 Thread Qian Cai
> On Aug 16, 2019, at 5:48 PM, Dan Williams wrote: > > On Fri, Aug 16, 2019 at 2:36 PM Qian Cai wrote: >> >> Every so often recently, booting Intel CPU server on linux-next triggers this >> warning. Trying to figure out if the commit 7cc7867fb061 >> (&q

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-17 Thread Qian Cai
> On Aug 17, 2019, at 12:59 PM, Dan Williams wrote: > > On Sat, Aug 17, 2019 at 4:13 AM Qian Cai wrote: >> >> >> >>> On Aug 16, 2019, at 11:57 PM, Dan Williams wrote: >>> >>> On Fri, Aug 16, 2019 at 8:34 PM Qian Cai wrote: &g

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-21 Thread Qian Cai
> On Aug 21, 2019, at 9:31 PM, Baoquan He wrote: > > On 08/21/19 at 05:12pm, Qian Cai wrote: >>>> Does disabling CONFIG_RANDOMIZE_BASE help? Maybe that workaround has >>>> regressed. Effectively we need to find what is causing the kernel to >>>>

Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning

2019-08-21 Thread Qian Cai
On Sat, 2019-08-17 at 23:25 -0400, Qian Cai wrote: > > On Aug 17, 2019, at 12:59 PM, Dan Williams wrote: > > > > On Sat, Aug 17, 2019 at 4:13 AM Qian Cai wrote: > > > > > > > > > > > > > On Aug 16, 2019, at 11:57 PM, Dan Williams >

[PATCH v3] nvdimm/btt: fix variable 'rc' set but not used

2019-10-31 Thread Qian Cai
aring") Signed-off-by: Qian Cai --- v3: remove the unused "rc" per Vishal. v2: include the block address that is returning an error per Dan. drivers/nvdimm/btt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.

[PATCH] nvdimm/btt: fix variable 'rc' set but not used

2019-10-30 Thread Qian Cai
aring") Signed-off-by: Qian Cai --- drivers/nvdimm/btt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 3e9f45aec8d1..59852f7e2d60 100644 --- a/drivers/nvdimm/btt.c +++ b/drivers/nvdimm/btt.c @@ -1266,6 +1266,11 @@ static int b

Re: [PATCH v2] nvdimm/btt: fix variable 'rc' set but not used

2019-10-30 Thread Qian Cai
> On Oct 30, 2019, at 5:38 PM, Verma, Vishal L wrote: > > Good find! Since we're not really using rc later, we should just > simplify this to: > >if (btt_map_write(...)) >dev_warn_ratelimited(...) >goto out_rtt; Ah, I thought about printing the rc as well at first, but it

[PATCH v2] nvdimm/btt: fix variable 'rc' set but not used

2019-10-30 Thread Qian Cai
aring") Signed-off-by: Qian Cai --- v2: include the block address that is returning an error per Dan. drivers/nvdimm/btt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c index 3e9f45aec8d1..10313be78221 100644 --- a/drivers/nvdimm/b

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Qian Cai
On Tue, 2020-09-22 at 18:05 +0100, Matthew Wilcox wrote: > On Tue, Sep 22, 2020 at 12:23:45PM -0400, Qian Cai wrote: > > On Fri, 2020-09-11 at 00:47 +0100, Matthew Wilcox (Oracle) wrote: > > > Size the uptodate array dynamically to support larger pages in the > > > pa

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-23 Thread Qian Cai
On Wed, 2020-09-23 at 03:48 +0100, Matthew Wilcox wrote: > I'm out of ideas. Maybe I'll wake up with a better idea in the morning. > I've been trying to reproduce this on x86 with a 1kB block size > filesystem, and haven't been able to yet. Maybe I'll try to setup a > powerpc cross-compilation

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Qian Cai
On Fri, 2020-09-11 at 00:47 +0100, Matthew Wilcox (Oracle) wrote: > Size the uptodate array dynamically to support larger pages in the > page cache. With a 64kB page, we're only saving 8 bytes per page today, > but with a 2MB maximum page size, we'd have to allocate more than 4kB > per page. Add

Re: [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page

2020-09-22 Thread Qian Cai
On Tue, 2020-09-22 at 18:05 +0100, Matthew Wilcox wrote: > On Tue, Sep 22, 2020 at 12:23:45PM -0400, Qian Cai wrote: > > On Fri, 2020-09-11 at 00:47 +0100, Matthew Wilcox (Oracle) wrote: > > > Size the uptodate array dynamically to support larger pages in the > > > pa

Re: [PATCH v5 0/5] mm: introduce memfd_secret system call to create "secret" memory areas

2020-09-18 Thread Qian Cai
On Thu, 2020-09-17 at 09:27 -0400, Qian Cai wrote: > On Wed, 2020-09-16 at 10:35 +0300, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Hi, > > > > This is an implementation of "secret" mappings backed by a file descriptor. > > I'v

Re: [PATCH v5 0/5] mm: introduce memfd_secret system call to create "secret" memory areas

2020-09-17 Thread Qian Cai
On Wed, 2020-09-16 at 10:35 +0300, Mike Rapoport wrote: > From: Mike Rapoport > > Hi, > > This is an implementation of "secret" mappings backed by a file descriptor. > I've dropped the boot time reservation patch for now as it is not strictly > required for the basic usage and can be easily

Re: [PATCH 18/20] block: refator submit_bio_noacct

2020-07-02 Thread Qian Cai
On Mon, Jun 29, 2020 at 09:39:45PM +0200, Christoph Hellwig wrote: > Split out a __submit_bio_noacct helper for the actual de-recursion > algorithm, and simplify the loop by using a continue when we can't > enter the queue for a bio. > > Signed-off-by: Christoph Hellwig Reverting this commit

Re: [PATCH v14 09/10] arch, mm: wire up memfd_secret system call were relevant

2020-12-07 Thread Qian Cai
On Thu, 2020-12-03 at 08:29 +0200, Mike Rapoport wrote: > From: Mike Rapoport > > Wire up memfd_secret system call on architectures that define > ARCH_HAS_SET_DIRECT_MAP, namely arm64, risc-v and x86. > > Signed-off-by: Mike Rapoport > Acked-by: Palmer Dabbelt > Acked-by: Arnd Bergmann > ---