Re: [PATCH 0/5] [v4] Allow persistent memory to be used like normal RAM

2019-01-28 Thread Balbir Singh
n be selected by its unique NUMA > node. NUMA is distance based topology, does HMAT solve these problems? How do we prevent fallback nodes of normal nodes being pmem nodes? On an unexpected crash/failure is there a scrubbing mechanism or do we rely on the allocator to do the right thing prior to reallocating any memory. Will frequent zero'ing hurt NVDIMM/pmem's life times? Balbir Singh. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [RESEND 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem

2018-05-02 Thread Balbir Singh
post what I have for review within the next few >> days. >> >> Whether this is all too late for 4.17 is another question... > > Here is the x86 version of a 'bytes remaining' memcpy_mcsafe() implemenation: > > https://lists.01.org/pipermail/linux-nvdimm/2018-May/015548.ht

Re: [PATCH v3 1/4] libnvdimm: Add of_node to region and bus descriptors

2018-04-07 Thread Balbir Singh
w > there are no pending device-tree design concerns. Hi, Dan I can ack Oliver's work, will do so in each patch Overall Acked-by: Balbir Singh <bsinghar...@gmail.com> Balbir Singh ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [RESEND 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem

2018-04-06 Thread Balbir Singh
On Fri, Apr 6, 2018 at 11:26 AM, Nicholas Piggin <npig...@gmail.com> wrote: > On Thu, 05 Apr 2018 16:40:26 -0400 > Jeff Moyer <jmo...@redhat.com> wrote: > >> Nicholas Piggin <npig...@gmail.com> writes: >> >> > On Thu, 5 Apr 2018 15:53:07 +1000

Re: [PATCH v2 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem

2018-04-05 Thread Balbir Singh
On Thu, Apr 5, 2018 at 9:26 PM, Oliver <ooh...@gmail.com> wrote: > On Thu, Apr 5, 2018 at 5:14 PM, Balbir Singh <bsinghar...@gmail.com> wrote: >> The pmem infrastructure uses memcpy_mcsafe in the pmem >> layer so as to convert machine check excpetions into >>

[PATCH v2 3/3] powerpc/mce: Handle memcpy_mcsafe

2018-04-05 Thread Balbir Singh
) and does not print any error message as the error is treated as returned via a return value and handled. Signed-off-by: Balbir Singh <bsinghar...@gmail.com> --- arch/powerpc/include/asm/mce.h | 3 +- arch/powerpc/kernel/mce.c | 77 -- 2 files chang

[PATCH v2 1/3] powerpc/mce: Bug fixes for MCE handling in kernel space

2018-04-05 Thread Balbir Singh
returned. Fixes: ba41e1e1ccb9 ("powerpc/mce: Hookup derror (load/store) UE errors") Signed-off-by: Balbir Singh <bsinghar...@gmail.com> --- arch/powerpc/kernel/mce_power.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/arc

[PATCH v2 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem

2018-04-05 Thread Balbir Singh
, largely to keep the patch simple. If needed those optimizations can be folded in. Signed-off-by: Balbir Singh <bsinghar...@gmail.com> Acked-by: Nicholas Piggin <npig...@gmail.com> --- arch/powerpc/include/asm/string.h | 2 + arch/powerpc/lib/Makefile | 2 +- arch

Re: [RESEND 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem

2018-04-04 Thread Balbir Singh
cholas Piggin <npig...@gmail.com> wrote: > > > On Thu, 5 Apr 2018 09:19:42 +1000 > > > Balbir Singh <bsinghar...@gmail.com> wrote: > > > > > >> The pmem infrastructure uses memcpy_mcsafe in the pmem > > >> layer so as to convert m

Re: [RESEND 1/3] powerpc/mce: Bug fixes for MCE handling in kernel space

2018-04-04 Thread Balbir Singh
On Thu, 5 Apr 2018 09:49:00 +1000 Nicholas Piggin <npig...@gmail.com> wrote: > On Thu, 5 Apr 2018 09:19:41 +1000 > Balbir Singh <bsinghar...@gmail.com> wrote: > > > The code currently assumes PAGE_SHIFT as the shift value of > > the pfn, this works correc

[RESEND 3/3] powerpc/mce: Handle memcpy_mcsafe

2018-04-04 Thread Balbir Singh
) and does not print any error message as the error is treated as returned via a return value and handled. Signed-off-by: Balbir Singh <bsinghar...@gmail.com> --- arch/powerpc/include/asm/mce.h | 3 +- arch/powerpc/kernel/mce.c | 77 -- 2 files chang

[RESEND 2/3] powerpc/memcpy: Add memcpy_mcsafe for pmem

2018-04-04 Thread Balbir Singh
, largely to keep the patch simple. If needed those optimizations can be folded in. Signed-off-by: Balbir Singh <bsinghar...@gmail.com> --- arch/powerpc/include/asm/string.h | 2 + arch/powerpc/lib/Makefile | 2 +- arch/powerpc/lib/memcpy_mcsafe_64.S

[RESEND 0/3] Add support for memcpy_mcsafe

2018-04-04 Thread Balbir Singh
memcpy_mcsafe via ioctls. Balbir Singh (3): powerpc/mce: Bug fixes for MCE handling in kernel space powerpc/memcpy: Add memcpy_mcsafe for pmem powerpc/mce: Handle memcpy_mcsafe arch/powerpc/include/asm/mce.h | 3 +- arch/powerpc/include/asm/string.h | 2 + arch/powerpc/kernel/mce.c

Re: [RESEND v2 4/4] powerpc/powernv: Create platform devs for nvdimm buses

2018-04-04 Thread Balbir Singh
On Wed, 4 Apr 2018 00:24:15 +1000 Oliver O'Halloran <ooh...@gmail.com> wrote: > Scan the devicetree for an nvdimm-bus compatible and create > a platform device for them. > > Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> > --- Acked-by: Balbir S

Re: [RESEND v2 1/4] libnvdimm: Add of_node to region and bus descriptors

2018-04-04 Thread Balbir Singh
> need to pass in a pointer to the relevant node in the descriptor. > > Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> > Acked-by: Dan Williams <dan.j.willi...@intel.com> > --- Acked-by: Balbir Singh <bsinghar...@gmail.com> __

Re: [PATCH 3/6] libnvdimm: Add device-tree based driver

2018-03-25 Thread Balbir Singh
> + }, > +}; > + > +/* bus wrangling */ > + > +static int __init of_nvdimm_init(void) > +{ > + /* register */ > + bus_desc.attr_groups = bus_attr_groups; > + bus_desc.provider_name = "of_nvdimm"; > + bus_desc.module = THIS_MODULE; > + > + /*

Re: [PATCH 2/6] libnvdimm: Add nd_region_destroy()

2018-03-25 Thread Balbir Singh
gt; } > EXPORT_SYMBOL_GPL(nvdimm_blk_region_create); > > +void nd_region_destroy(struct nd_region *region) > +{ > + nd_device_unregister(>dev, ND_SYNC); child_unregister seems to do the same thing, but is expected to be used as a callback from device_for_each_child() I'd suggest

Re: [PATCH 1/6] libnvdimm: Add of_node to region and bus descriptors

2018-03-25 Thread Balbir Singh
> need to pass in a pointer to the relevant node in the descriptor. > > Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> > Acked-by: Dan Williams <dan.j.willi...@intel.com> > --- Acked-by: Balbir Singh <bsinghar...@gmail.com> __

Re: [PATCH 8/9] powerpc/mm: Wire up hpte_removebolted for powernv

2017-04-11 Thread Balbir Singh
his was bolted you might be right that it is always valid and bolted > + > + /* Invalidate the TLB */ > + tlbie(vpn, psize, psize, ssize, 0); The API also does not clear linear_map_hash_slots[] under DEBUG_PAGEALLOC > + return 0; > +} > + > + Balbir Singh. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH 6/9] powerpc, mm: Enable ZONE_DEVICE on powerpc

2017-04-11 Thread Balbir Singh
on SPARSEMEM_VMEMMAP > - depends on X86_64 #arch_add_memory() comprehends device memory > + depends on (X86_64 || PPC_BOOK3S_64) #arch_add_memory() comprehends > device memory Reviewed-by: Balbir Singh <bsinghar...@gmail.com> _

Re: [PATCH 5/9] powerpc/vmemmap: Add altmap support

2017-04-11 Thread Balbir Singh
large amount of ZONE_DEVICE memory is being added to the system the > altmap reduces pressure on main system memory by allowing the mm/ > metadata to be stored on the device itself rather in main memory. > > Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> > --- Re