Re: [PATCH v16 10/11] arch, mm: wire up memfd_secret system call where relevant

2021-01-25 Thread Catalin Marinas
pi/asm/unistd.h > @@ -20,5 +20,6 @@ > #define __ARCH_WANT_SET_GET_RLIMIT > #define __ARCH_WANT_TIME32_SYSCALLS > #define __ARCH_WANT_SYS_CLONE3 > +#define __ARCH_WANT_MEMFD_SECRET I thought I already acked v10 of this patch. Here it is aga

Re: [PATCH v12 04/10] set_memory: allow querying whether set_direct_map_*() is actually enabled

2020-11-25 Thread Catalin Marinas
occurrences of open coded checks in arm64 with the new > function and provide a generic stub for architectures that always modify > page tables upon calls to set_direct_map APIs. > > Signed-off-by: Mike Rapoport Reviewed-by: Catalin Marinas _

Re: [PATCH v11 4/9] mm: introduce memfd_secret system call to create "secret" memory areas

2020-11-24 Thread Catalin Marinas
Hi Mike, On Tue, Nov 24, 2020 at 11:25:51AM +0200, Mike Rapoport wrote: > +static vm_fault_t secretmem_fault(struct vm_fault *vmf) > +{ > + struct address_space *mapping = vmf->vma->vm_file->f_mapping; > + struct inode *inode = file_inode(vmf->vma->vm_file); > + pgoff_t offset =

Re: [PATCH v10 8/9] arch, mm: wire up memfd_secret system call were relevant

2020-11-23 Thread Catalin Marinas
pi/asm/unistd.h > @@ -20,5 +20,6 @@ > #define __ARCH_WANT_SET_GET_RLIMIT > #define __ARCH_WANT_TIME32_SYSCALLS > #define __ARCH_WANT_SYS_CLONE3 > +#define __ARCH_WANT_MEMFD_SECRET > > #include For arm64: Acked-by: Catalin Marinas __

Re: [PATCH v9 8/9] arch, mm: wire up memfd_secret system call were relevant

2020-11-17 Thread Catalin Marinas
On Tue, Nov 17, 2020 at 06:29:31PM +0200, Mike Rapoport wrote: > From: Mike Rapoport > > Wire up memfd_secret system call on architectures that define > ARCH_HAS_SET_DIRECT_MAP, namely arm64, risc-v and x86. > > Signed-off-by: Mike Rapoport > Acked-by: Palmer Dabbelt > Acked-by: Arnd Bergmann

Re: [PATCH v8 3/9] set_memory: allow set_direct_map_*_noflush() for multiple pages

2020-11-13 Thread Catalin Marinas
er to set_direct_map_*_noflush() to expose this ability > with these APIs. > > Signed-off-by: Mike Rapoport > --- > arch/arm64/include/asm/cacheflush.h | 4 ++-- > arch/arm64/mm/pageattr.c| 10 ++++++ For arm64: Acked-by: Catalin Marinas _

Re: [PATCH v8 8/9] arch, mm: wire up memfd_secret system call were relevant

2020-11-13 Thread Catalin Marinas
Hi Mike, On Tue, Nov 10, 2020 at 05:14:43PM +0200, Mike Rapoport wrote: > diff --git a/arch/arm64/include/asm/unistd32.h > b/arch/arm64/include/asm/unistd32.h > index 6c1dcca067e0..c71c3fe0b6cd 100644 > --- a/arch/arm64/include/asm/unistd32.h > +++ b/arch/arm64/include/asm/unistd32.h > @@ -891,6

Re: [PATCH v2 3/7] mm: introduce memfd_secret system call to create "secret" memory areas

2020-07-31 Thread Catalin Marinas
On Fri, Jul 31, 2020 at 03:29:05PM +0100, Mark Rutland wrote: > On Thu, Jul 30, 2020 at 05:22:10PM +0100, Catalin Marinas wrote: > > On Mon, Jul 27, 2020 at 07:29:31PM +0300, Mike Rapoport wrote: > > > +static int secretmem_mmap(struct file *file, struct v

Re: [PATCH v2 3/7] mm: introduce memfd_secret system call to create "secret" memory areas

2020-07-31 Thread Catalin Marinas
On Thu, Jul 30, 2020 at 11:44:09PM +0300, Mike Rapoport wrote: > On Thu, Jul 30, 2020 at 05:22:10PM +0100, Catalin Marinas wrote: > > On Mon, Jul 27, 2020 at 07:29:31PM +0300, Mike Rapoport wrote: > > > For instance, the following example will create an uncached mapping (er

Re: [PATCH v2 3/7] mm: introduce memfd_secret system call to create "secret" memory areas

2020-07-30 Thread Catalin Marinas
Hi Mike, On Mon, Jul 27, 2020 at 07:29:31PM +0300, Mike Rapoport wrote: > For instance, the following example will create an uncached mapping (error > handling is omitted): > > fd = memfd_secret(SECRETMEM_UNCACHED); > ftruncate(fd, MAP_SIZE); > ptr = mmap(NULL, MAP_SIZE,

Re: [PATCH 6/6] arm64: uaccess: Implement *_flushcache variants

2017-08-10 Thread Catalin Marinas
On Thu, Aug 10, 2017 at 12:58:45PM +0200, Arnd Bergmann wrote: > On Tue, Jul 25, 2017 at 12:55 PM, Robin Murphy wrote: > > Implement the set of copy functions with guarantees of a clean cache > > upon completion necessary to support the pmem driver. > > > > Signed-off-by:

Re: [PATCH 5/6] arm64: Implement pmem API support

2017-08-04 Thread Catalin Marinas
Two minor comments below. On Tue, Jul 25, 2017 at 11:55:42AM +0100, Robin Murphy wrote: > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -960,6 +960,17 @@ config ARM64_UAO > regular load/store instructions if the cpu does not implement the > feature. > > +config