Re: [PATCH v4 3/5] um: track 'parent' device in a local variable

[Dan Williams]

On Tue, Jun 21, 2016 at 11:20 PM, Bart Van Assche
 wrote:
> On 06/21/2016 10:47 PM, Dan Williams wrote:
>>
>> In preparation for the removal of 'driverfs_dev' from 'struct gendisk'
>> use a local variable to track the parented vs un-parented case in
>> ubd_disk_register().
>>
>> Cc: Jeff Dike 
>> Cc: Richard Weinberger 
>> Reported-by: Bart Van Assche 
>> Signed-off-by: Dan Williams 
>> ---
>>  arch/um/drivers/ubd_kern.c |5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
>> index ef6b4d960bad..8ec7b4112f55 100644
>> --- a/arch/um/drivers/ubd_kern.c
>> +++ b/arch/um/drivers/ubd_kern.c
>> @@ -801,6 +801,7 @@ static void ubd_device_release(struct device *dev)
>>  static int ubd_disk_register(int major, u64 size, int unit,
>>  struct gendisk **disk_out)
>>  {
>> +   struct device *dev = NULL;
>> struct gendisk *disk;
>>
>> disk = alloc_disk(1 << UBD_SHIFT);
>> @@ -823,12 +824,12 @@ static int ubd_disk_register(int major, u64 size,
>> int unit,
>> ubd_devs[unit].pdev.dev.release = ubd_device_release;
>> dev_set_drvdata(_devs[unit].pdev.dev,
>> _devs[unit]);
>> platform_device_register(_devs[unit].pdev);
>> -   disk->driverfs_dev = _devs[unit].pdev.dev;
>> +   dev = _devs[unit].pdev.dev;
>> }
>>
>> disk->private_data = _devs[unit];
>> disk->queue = ubd_devs[unit].queue;
>> -   add_disk(disk);
>> +   device_add_disk(dev, disk);
>>
>> *disk_out = disk;
>> return 0;
>
>
> Hello Dan,
>
> The Reported-by tag is intended to give people credit who find bugs in the
> upstream kernel. What I reported was a bug not in the upstream kernel but in
> a previous version of this patch series so I think the "Reported-by" tag can
> be left out from this patch.

I see nothing wrong with using it to give credit to patches during
review, I also do this when static analysis finds a problem in a patch
before it gets upstream.  If the report fixes upstream code then I
additionally add a "Fixes" tag.  If you'd rather I don't list you as
reported-by that's fine, but there's nothing in the definition of
Reported-by in Documentation/SubmittingPatches that requires the bug
to be upstream first.

> Additionally, please consider to use a more descriptive name instead of
> "dev", e.g. "parent".

Sure, will do.
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH v4 3/5] um: track 'parent' device in a local variable

[Bart Van Assche]

On 06/21/2016 10:47 PM, Dan Williams wrote:

In preparation for the removal of 'driverfs_dev' from 'struct gendisk'
use a local variable to track the parented vs un-parented case in
ubd_disk_register().

Cc: Jeff Dike 
Cc: Richard Weinberger 
Reported-by: Bart Van Assche 
Signed-off-by: Dan Williams 
---
 arch/um/drivers/ubd_kern.c |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index ef6b4d960bad..8ec7b4112f55 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -801,6 +801,7 @@ static void ubd_device_release(struct device *dev)
 static int ubd_disk_register(int major, u64 size, int unit,
 struct gendisk **disk_out)
 {
+   struct device *dev = NULL;
struct gendisk *disk;

disk = alloc_disk(1 << UBD_SHIFT);
@@ -823,12 +824,12 @@ static int ubd_disk_register(int major, u64 size, int 
unit,
ubd_devs[unit].pdev.dev.release = ubd_device_release;
dev_set_drvdata(_devs[unit].pdev.dev, _devs[unit]);
platform_device_register(_devs[unit].pdev);
-   disk->driverfs_dev = _devs[unit].pdev.dev;
+   dev = _devs[unit].pdev.dev;
}

disk->private_data = _devs[unit];
disk->queue = ubd_devs[unit].queue;
-   add_disk(disk);
+   device_add_disk(dev, disk);

*disk_out = disk;
return 0;


Hello Dan,

The Reported-by tag is intended to give people credit who find bugs in 
the upstream kernel. What I reported was a bug not in the upstream 
kernel but in a previous version of this patch series so I think the 
"Reported-by" tag can be left out from this patch.


Additionally, please consider to use a more descriptive name instead of 
"dev", e.g. "parent".


Thanks,

Bart.
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm