Re: [PATCH] libnvdimm: remove redundant assignment to pointer 'dev'

2018-02-05 Thread Ross Zwisler
On Mon, Feb 05, 2018 at 10:44:07AM -0800, Dan Williams wrote: > On Mon, Feb 5, 2018 at 10:20 AM, Ross Zwisler > wrote: > > On Mon, Feb 05, 2018 at 02:08:52PM +, Colin King wrote: > >> From: Colin Ian King > >> > >> Pointer dev is being

Re: [PATCH] libnvdimm: remove redundant assignment to pointer 'dev'

2018-02-05 Thread Colin Ian King
On 05/02/18 18:44, Dan Williams wrote: > On Mon, Feb 5, 2018 at 10:20 AM, Ross Zwisler > wrote: >> On Mon, Feb 05, 2018 at 02:08:52PM +, Colin King wrote: >>> From: Colin Ian King >>> >>> Pointer dev is being assigned a value that is

Re: [PATCH] libnvdimm: remove redundant assignment to pointer 'dev'

2018-02-05 Thread Dan Williams
On Mon, Feb 5, 2018 at 10:20 AM, Ross Zwisler wrote: > On Mon, Feb 05, 2018 at 02:08:52PM +, Colin King wrote: >> From: Colin Ian King >> >> Pointer dev is being assigned a value that is never read, it is being >> re-assigned the same

Re: [PATCH] libnvdimm: remove redundant assignment to pointer 'dev'

2018-02-05 Thread Ross Zwisler
On Mon, Feb 05, 2018 at 02:08:52PM +, Colin King wrote: > From: Colin Ian King > > Pointer dev is being assigned a value that is never read, it is being > re-assigned the same value later on, hence the initialization is redundant > and can be removed. > > Cleans up

[PATCH] libnvdimm: remove redundant assignment to pointer 'dev'

2018-02-05 Thread Colin King
From: Colin Ian King Pointer dev is being assigned a value that is never read, it is being re-assigned the same value later on, hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/nvdimm/pfn_devs.c:307:17: warning: Value stored to