Re: [kbuild-all] [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-08 Thread Ye Xiaolong
On 02/03, Dave Jiang wrote: >On 02/03/2017 05:00 PM, Dan Williams wrote: >> On Fri, Feb 3, 2017 at 3:26 PM, Dan Williams >> wrote: >>> On Fri, Feb 3, 2017 at 3:25 PM, Dave Jiang wrote: On 02/03/2017 03:56 PM, kbuild test robot wrote: > Hi Dave, > > [auto build test ERROR on mmot

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-08 Thread Jan Kara
On Tue 07-02-17 08:56:56, Dan Williams wrote: > On Tue, Feb 7, 2017 at 12:44 AM, Kirill A. Shutemov > wrote: > > On Mon, Feb 06, 2017 at 09:30:22AM -0800, Dan Williams wrote: > >> On Mon, Feb 6, 2017 at 9:27 AM, Christoph Hellwig > >> wrote: > >> > On Mon, Feb 06, 2017 at 08:24:48AM -0800, Dan W

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-07 Thread Dan Williams
On Tue, Feb 7, 2017 at 9:40 AM, Kirill A. Shutemov wrote: > On Tue, Feb 07, 2017 at 08:56:56AM -0800, Dan Williams wrote: >> On Tue, Feb 7, 2017 at 12:44 AM, Kirill A. Shutemov >> wrote: >> > On Mon, Feb 06, 2017 at 09:30:22AM -0800, Dan Williams wrote: >> >> On Mon, Feb 6, 2017 at 9:27 AM, Chris

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-07 Thread Kirill A. Shutemov
On Tue, Feb 07, 2017 at 08:56:56AM -0800, Dan Williams wrote: > On Tue, Feb 7, 2017 at 12:44 AM, Kirill A. Shutemov > wrote: > > On Mon, Feb 06, 2017 at 09:30:22AM -0800, Dan Williams wrote: > >> On Mon, Feb 6, 2017 at 9:27 AM, Christoph Hellwig > >> wrote: > >> > On Mon, Feb 06, 2017 at 08:24:4

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-07 Thread Dan Williams
On Tue, Feb 7, 2017 at 12:44 AM, Kirill A. Shutemov wrote: > On Mon, Feb 06, 2017 at 09:30:22AM -0800, Dan Williams wrote: >> On Mon, Feb 6, 2017 at 9:27 AM, Christoph Hellwig wrote: >> > On Mon, Feb 06, 2017 at 08:24:48AM -0800, Dan Williams wrote: >> >> > Also can be use this opportunity >> >>

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-07 Thread Kirill A. Shutemov
On Mon, Feb 06, 2017 at 09:30:22AM -0800, Dan Williams wrote: > On Mon, Feb 6, 2017 at 9:27 AM, Christoph Hellwig wrote: > > On Mon, Feb 06, 2017 at 08:24:48AM -0800, Dan Williams wrote: > >> > Also can be use this opportunity > >> > to fold ->huge_fault into ->fault? BTW, for tmpfs we already us

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-06 Thread Dan Williams
On Mon, Feb 6, 2017 at 9:27 AM, Christoph Hellwig wrote: > On Mon, Feb 06, 2017 at 08:24:48AM -0800, Dan Williams wrote: >> > Also can be use this opportunity >> > to fold ->huge_fault into ->fault? >> >> Hmm, yes, just need a scheme to not attempt huge_faults on pte-only handlers. > > Do we need

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-06 Thread Christoph Hellwig
On Mon, Feb 06, 2017 at 08:24:48AM -0800, Dan Williams wrote: > > Also can be use this opportunity > > to fold ->huge_fault into ->fault? > > Hmm, yes, just need a scheme to not attempt huge_faults on pte-only handlers. Do we need anything more than checking vma->vm_flags for VM_HUGETLB?

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-06 Thread Dan Williams
On Mon, Feb 6, 2017 at 6:36 AM, Christoph Hellwig wrote: > On Fri, Feb 03, 2017 at 02:31:22PM -0700, Dave Jiang wrote: >> Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has >> been somewhat painful with getting the flags set and removed at the >> correct locations. More than on

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-06 Thread Christoph Hellwig
On Fri, Feb 03, 2017 at 02:31:22PM -0700, Dave Jiang wrote: > Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has > been somewhat painful with getting the flags set and removed at the > correct locations. More than one kernel oops was introduced due to > difficulties of getting t

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-06 Thread Jan Kara
On Fri 03-02-17 14:31:22, Dave Jiang wrote: > Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has > been somewhat painful with getting the flags set and removed at the > correct locations. More than one kernel oops was introduced due to > difficulties of getting the placement cor

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread kbuild test robot
Hi Dave, [auto build test WARNING on mmotm/master] [cannot apply to linus/master linux/master v4.10-rc6 next-20170203] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dave-Jiang/mm-replace-FAULT_

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread Dave Jiang
On 02/03/2017 05:00 PM, Dan Williams wrote: > On Fri, Feb 3, 2017 at 3:26 PM, Dan Williams wrote: >> On Fri, Feb 3, 2017 at 3:25 PM, Dave Jiang wrote: >>> On 02/03/2017 03:56 PM, kbuild test robot wrote: Hi Dave, [auto build test ERROR on mmotm/master] [cannot apply to linus/m

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread Dan Williams
On Fri, Feb 3, 2017 at 3:26 PM, Dan Williams wrote: > On Fri, Feb 3, 2017 at 3:25 PM, Dave Jiang wrote: >> On 02/03/2017 03:56 PM, kbuild test robot wrote: >>> Hi Dave, >>> >>> [auto build test ERROR on mmotm/master] >>> [cannot apply to linus/master linux/master v4.10-rc6 next-20170203] >>> [if

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread Dan Williams
On Fri, Feb 3, 2017 at 3:25 PM, Dave Jiang wrote: > On 02/03/2017 03:56 PM, kbuild test robot wrote: >> Hi Dave, >> >> [auto build test ERROR on mmotm/master] >> [cannot apply to linus/master linux/master v4.10-rc6 next-20170203] >> [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread Dave Jiang
On 02/03/2017 03:56 PM, kbuild test robot wrote: > Hi Dave, > > [auto build test ERROR on mmotm/master] > [cannot apply to linus/master linux/master v4.10-rc6 next-20170203] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] This one is a bit o

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread kbuild test robot
Hi Dave, [auto build test ERROR on mmotm/master] [cannot apply to linus/master linux/master v4.10-rc6 next-20170203] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dave-Jiang/mm-replace-FAULT_FL

Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread Dan Williams
On Fri, Feb 3, 2017 at 1:31 PM, Dave Jiang wrote: > Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has > been somewhat painful with getting the flags set and removed at the > correct locations. More than one kernel oops was introduced due to > difficulties of getting the placem

[PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault

2017-02-03 Thread Dave Jiang
Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has been somewhat painful with getting the flags set and removed at the correct locations. More than one kernel oops was introduced due to difficulties of getting the placement correctly. Removing the flag values and introducing an