Re: [PATCH] xfs: add regression test for DAX mount option usage

On Fri, Sep 15, 2017 at 10:39:05AM -0700, Dan Williams wrote: > Yes, but what we're worried about in the libnvdimm/nfit_test case is > internals behind sysfs interfaces. But point taken, we can at least > use the presence of certain attributes to gate tests. However, it does > mean we lose the

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Fri, Sep 15, 2017 at 2:18 AM, Johannes Thumshirn wrote: > On Thu, Sep 14, 2017 at 07:10:02AM -0700, Dan Williams wrote: >> What discouraged me from going that route in the past is the busy work >> of tracking / syncing these new debugfs feature gate flags across 2 >> source

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Thu, Sep 14, 2017 at 07:10:02AM -0700, Dan Williams wrote: > What discouraged me from going that route in the past is the busy work > of tracking / syncing these new debugfs feature gate flags across 2 > source repositories. If we want to stop depending on kernel version in > the test suite

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Thu, Sep 14, 2017 at 6:16 AM, Johannes Thumshirn wrote: > On Thu, Sep 14, 2017 at 08:19:58AM -0400, Jeff Moyer wrote: >> Dan Williams writes: >> >> > On Wed, Sep 13, 2017 at 5:40 PM, Dave Chinner wrote: >> >> On Wed, Sep 13,

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Thu, Sep 14, 2017 at 08:19:58AM -0400, Jeff Moyer wrote: > Dan Williams writes: > > > On Wed, Sep 13, 2017 at 5:40 PM, Dave Chinner wrote: > >> On Wed, Sep 13, 2017 at 05:28:39PM -0700, Dan Williams wrote: > >>> On Wed, Sep 13, 2017 at 4:34 PM,

Re: [PATCH] xfs: add regression test for DAX mount option usage

Dan Williams writes: > On Wed, Sep 13, 2017 at 5:40 PM, Dave Chinner wrote: >> On Wed, Sep 13, 2017 at 05:28:39PM -0700, Dan Williams wrote: >>> On Wed, Sep 13, 2017 at 4:34 PM, Dave Chinner wrote: >>> > /me shrugs >>> > >>> >

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Wed, Sep 13, 2017 at 05:28:39PM -0700, Dan Williams wrote: > On Wed, Sep 13, 2017 at 4:34 PM, Dave Chinner wrote: > > /me shrugs > > > > I just don't like the concept of using tracepoints to as a > > definitive diagnostic test for something working because it'll break > >

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Wed, Sep 13, 2017 at 4:34 PM, Dave Chinner wrote: > On Wed, Sep 13, 2017 at 03:23:39PM -0700, Dan Williams wrote: >> On Wed, Sep 13, 2017 at 3:01 PM, Dave Chinner wrote: >> > On Wed, Sep 13, 2017 at 08:42:15AM -0600, Ross Zwisler wrote: >> >> On Wed,

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Wed, Sep 13, 2017 at 03:23:39PM -0700, Dan Williams wrote: > On Wed, Sep 13, 2017 at 3:01 PM, Dave Chinner wrote: > > On Wed, Sep 13, 2017 at 08:42:15AM -0600, Ross Zwisler wrote: > >> On Wed, Sep 13, 2017 at 09:47:29AM +1000, Dave Chinner wrote: > >> > >> <> > >> > >> > I

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Wed, Sep 13, 2017 at 3:01 PM, Dave Chinner wrote: > On Wed, Sep 13, 2017 at 08:42:15AM -0600, Ross Zwisler wrote: >> On Wed, Sep 13, 2017 at 09:47:29AM +1000, Dave Chinner wrote: >> >> <> >> >> > I think similar concerns exist with using perf, too >> >> I though that

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Wed, Sep 13, 2017 at 08:42:15AM -0600, Ross Zwisler wrote: > On Wed, Sep 13, 2017 at 09:47:29AM +1000, Dave Chinner wrote: > > <> > > > I think similar concerns exist with using perf, too > > I though that using perf addressed both concerns? > > > > > So what happens when the user is

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Wed, Sep 13, 2017 at 09:47:29AM +1000, Dave Chinner wrote: <> > I think similar concerns exist with using perf, too I though that using perf addressed both concerns? > > > So what happens when the user is already tracing the test to > > > find a bug and the test turns all their tracing

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Tue, Sep 12, 2017 at 09:38:20AM -0600, Ross Zwisler wrote: > On Tue, Sep 12, 2017 at 04:44:11PM +1000, Dave Chinner wrote: > > On Fri, Sep 08, 2017 at 03:21:53PM -0600, Ross Zwisler wrote: > > > This adds a regression test for the following kernel patch: > > > > > > xfs: always use DAX if

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Tue, Sep 12, 2017 at 04:44:11PM +1000, Dave Chinner wrote: > On Fri, Sep 08, 2017 at 03:21:53PM -0600, Ross Zwisler wrote: > > This adds a regression test for the following kernel patch: > > > > xfs: always use DAX if mount option is used > > > > This test will also pass with kernel

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Fri, Sep 08, 2017 at 03:21:53PM -0600, Ross Zwisler wrote: > This adds a regression test for the following kernel patch: > > xfs: always use DAX if mount option is used > > This test will also pass with kernel v4.14-rc1 and beyond because the XFS > DAX I/O mount option has been disabled

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Mon, Sep 11, 2017 at 8:16 AM, Ross Zwisler wrote: > On Fri, Sep 08, 2017 at 03:21:53PM -0600, Ross Zwisler wrote: >> This adds a regression test for the following kernel patch: >> >> xfs: always use DAX if mount option is used >> >> This test will also pass with

Re: [PATCH] xfs: add regression test for DAX mount option usage

On Fri, Sep 08, 2017 at 03:21:53PM -0600, Ross Zwisler wrote: > This adds a regression test for the following kernel patch: > > xfs: always use DAX if mount option is used > > This test will also pass with kernel v4.14-rc1 and beyond because the XFS > DAX I/O mount option has been disabled

[PATCH] xfs: add regression test for DAX mount option usage

This adds a regression test for the following kernel patch: xfs: always use DAX if mount option is used This test will also pass with kernel v4.14-rc1 and beyond because the XFS DAX I/O mount option has been disabled (but not removed), so the "chattr -x" to turn off DAX doesn't actually do