Re: [PATCH 1/3] nfit_test: improve structure offset handling

2018-03-06 Thread Dan Williams
On Mon, Mar 5, 2018 at 10:42 AM, Ross Zwisler wrote: > On Tue, Feb 27, 2018 at 10:29:50AM -0700, Ross Zwisler wrote: >> In nfit_test0_setup() and nfit_test1_setup() we keep an 'offset' value >> which we use to calculate where in our 'nfit_buf' we will place our next

Re: [PATCH 1/3] nfit_test: improve structure offset handling

2018-03-05 Thread Ross Zwisler
On Tue, Feb 27, 2018 at 10:29:50AM -0700, Ross Zwisler wrote: > In nfit_test0_setup() and nfit_test1_setup() we keep an 'offset' value > which we use to calculate where in our 'nfit_buf' we will place our next > structure. The handling of 'offset' and the calculation of the placement > of the

[PATCH 1/3] nfit_test: improve structure offset handling

2018-02-27 Thread Ross Zwisler
In nfit_test0_setup() and nfit_test1_setup() we keep an 'offset' value which we use to calculate where in our 'nfit_buf' we will place our next structure. The handling of 'offset' and the calculation of the placement of the next structure is a bit inconsistent, though. We don't update 'offset'