Re: [RFC PATCH v2 2/7] ndctl: nvdimmd: add nvdimmd necessary util functions

2017-12-09 Thread Dan Williams
On Thu, Dec 7, 2017 at 1:55 AM, Qi, Fuli wrote: > > + rename(file, buf); > +} Why does the monitor need to rotate logs? This should be the responsibility of whatever is consuming the nvdimmd events. >>> >>> When I wrote it, I thought that

Re: [RFC PATCH v2 2/7] ndctl: nvdimmd: add nvdimmd necessary util functions

2017-12-07 Thread Qi, Fuli
+ rename(file, buf); +} Why does the monitor need to rotate logs? This should be the responsibility of whatever is consuming the nvdimmd events. When I wrote it, I thought that users can rotate nvdimmd logs without using other tools. If you think it is not necessary, I will remove it

Re: [RFC PATCH v2 2/7] ndctl: nvdimmd: add nvdimmd necessary util functions

2017-12-06 Thread Dan Williams
On Tue, Dec 5, 2017 at 11:14 PM, Qi, Fuli wrote: > On 2017/11/21 6:19, Dan Williams wrote: >> >> On Mon, Nov 13, 2017 at 11:46 PM, QI Fuli wrote: >>> >>> This patch is used to provide helper functions needed for nvdimm daemon. >>> These util

Re: [RFC PATCH v2 2/7] ndctl: nvdimmd: add nvdimmd necessary util functions

2017-12-05 Thread Qi, Fuli
On 2017/11/21 6:19, Dan Williams wrote: On Mon, Nov 13, 2017 at 11:46 PM, QI Fuli wrote: This patch is used to provide helper functions needed for nvdimm daemon. These util functions can be used by other features as well in the future. Signed-off-by: QI Fuli

Re: [RFC PATCH v2 2/7] ndctl: nvdimmd: add nvdimmd necessary util functions

2017-11-20 Thread Dan Williams
On Mon, Nov 13, 2017 at 11:46 PM, QI Fuli wrote: > This patch is used to provide helper functions needed for nvdimm daemon. > These util functions can be used by other features as well in the future. > > Signed-off-by: QI Fuli > --- >

[RFC PATCH v2 2/7] ndctl: nvdimmd: add nvdimmd necessary util functions

2017-11-13 Thread QI Fuli
This patch is used to provide helper functions needed for nvdimm daemon. These util functions can be used by other features as well in the future. Signed-off-by: QI Fuli --- nvdimmd/util.c | 80 ++ nvdimmd/util.h |