Re: [ndctl PATCH 1/3] ndctl: simplify JSON print flag handling

2018-06-29 Thread Verma, Vishal L
On Fri, 2018-06-29 at 16:51 -0700, Dan Williams wrote: > On Fri, Jun 29, 2018 at 4:39 PM, Ross Zwisler > wrote: > > json_object_to_json_string_ext()'s second argument is a flags field > > which > > we always want to be JSON_C_TO_STRING_PRETTY. We were going to a > > lot of > > trouble for

Re: [ndctl PATCH 1/3] ndctl: simplify JSON print flag handling

2018-06-29 Thread Dan Williams
On Fri, Jun 29, 2018 at 4:39 PM, Ross Zwisler wrote: > json_object_to_json_string_ext()'s second argument is a flags field which > we always want to be JSON_C_TO_STRING_PRETTY. We were going to a lot of > trouble for this, though. We had multiple variables set to be this one > flag and

[ndctl PATCH 1/3] ndctl: simplify JSON print flag handling

2018-06-29 Thread Ross Zwisler
json_object_to_json_string_ext()'s second argument is a flags field which we always want to be JSON_C_TO_STRING_PRETTY. We were going to a lot of trouble for this, though. We had multiple variables set to be this one flag and util_display_json_array() took it as an argument, even though it never