Re: [PATCH v4 3/5] um: track 'parent' device in a local variable

2016-06-22 Thread Dan Williams
On Tue, Jun 21, 2016 at 11:20 PM, Bart Van Assche <bart.vanass...@sandisk.com> wrote: > On 06/21/2016 10:47 PM, Dan Williams wrote: >> >> In preparation for the removal of 'driverfs_dev' from 'struct gendisk' >> use a local variable to track the parented vs un-parented c

[PATCH v4 4/5] block: convert to device_add_disk()

2016-06-21 Thread Dan Williams
onrad Rzeszutek Wilk <konrad.w...@oracle.com> Cc: Martin K. Petersen <martin.peter...@oracle.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/powerpc

[PATCH v4 0/5] Introduce device_add_disk() to kill gendisk.driverfs_dev

2016-06-21 Thread Dan Williams
ld success notification from the kbuild robot across 122 configs. --- Dan Williams (5): block: introduce device_add_disk() mmc: move 'parent' tracking to mmc_blk_data um: track 'parent' device in a local variable block: convert to device_add_disk() block: remove ->driverf

[PATCH v4 1/5] block: introduce device_add_disk()

2016-06-21 Thread Dan Williams
Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- block/genhd.c | 13 +++-- include/linux/genhd.h |8 +++- 2 files changed, 14 insertions(+),

[PATCH v4 3/5] um: track 'parent' device in a local variable

2016-06-21 Thread Dan Williams
isk.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/um/drivers/ubd_kern.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index ef6b4d960bad..8ec7b4112f55 100644 --- a/arch/um/drivers/

[PATCH v4 2/5] mmc: move 'parent' tracking to mmc_blk_data

2016-06-21 Thread Dan Williams
In preparation for the removal of 'driverfs_dev' from 'struct gendisk', carry this data in mmc_blk_data. It is used for registration of parent disks and partitions. Cc: Ulf Hansson <ulf.hans...@linaro.org> Reported-by: Bart Van Assche <bart.vanass...@sandisk.com> Signed-off-by:

Re: [PATCH v2 1/3] block: add QUEUE_FLAG_DAX for devices to advertise their DAX support

2016-06-23 Thread Dan Williams
>> return count; >>> } >>> >>> +static ssize_t queue_dax_show(struct request_queue *q, char *page) >>> +{ >>> + int bit; >>> + >>> + bit = test_bit(QUEUE_FLAG_DAX, >queue_flags); >>> + >>> +

Re: [PATCH] e820: use module_platform_driver

2016-06-24 Thread Dan Williams
On Fri, Jun 24, 2016 at 3:29 AM, Johannes Thumshirn wrote: > User module_platform_driver macro instead of open-coding it. > > Signed-off-by: Johannes Thumshirn Looks good. ___ Linux-nvdimm mailing list

[PATCH v3 0/3] Introduce device_add_disk() to kill gendisk.driverfs_dev

2016-06-17 Thread Dan Williams
ation from the kbuild robot across 116 configs. The following series implements... --- Dan Williams (3): block: introduce device_add_disk() block: convert to device_add_disk() block: remove ->driverfs_dev arch/powerpc/sysdev/axonram.c |3 +-- arch/um/drive

[PATCH v3 2/3] block: convert to device_add_disk()

2016-06-17 Thread Dan Williams
wisler <ross.zwis...@linux.intel.com> Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Cc: Martin K. Petersen <martin.peter...@oracle.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: Dan Williams <dan.j

[PATCH v3 1/3] block: introduce device_add_disk()

2016-06-17 Thread Dan Williams
Johannes Thumshirn <jthumsh...@suse.de> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- block/genhd.c | 13 +++-- include/linux/genhd.h |8 +++- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/block/genhd.c b/block/genhd

Re: [PATCH v2] libnvdimm, nfit: treat volatile virtual CD region as pmem

2016-06-25 Thread Dan Williams
On Sat, Jun 25, 2016 at 5:21 AM, joeyli <j...@suse.com> wrote: > iOn Fri, Jun 24, 2016 at 10:59:56AM -0700, Dan Williams wrote: >> On Fri, Jun 24, 2016 at 12:51 AM, Lee, Chun-Yi <joeyli.ker...@gmail.com> >> wrote: >> > This patch adds logic to treat volatile v

[PATCH 0/2] ZONE_DEVICE cleanups

2016-06-25 Thread Dan Williams
queue them with the rest of the libnvdimm-for-4.8 updates. --- Dan Williams (2): mm: CONFIG_ZONE_DEVICE stop depending on CONFIG_EXPERT mm: cleanup ifdef guards for vmem_altmap include/linux/memremap.h |2 +- kernel/memremap.c|8 mm/Kconfig |2 +

[PATCH 2/2] mm: cleanup ifdef guards for vmem_altmap

2016-06-25 Thread Dan Williams
Now that ZONE_DEVICE depends on SPARSEMEM_VMEMMAP we can simplify some ifdef guards to just ZONE_DEVICE. Reported-by: Vlastimil Babka <vba...@suse.cz> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- include/linux/memremap.h |2 +- kernel/memremap.c|8 -

[PATCH 1/2] mm: CONFIG_ZONE_DEVICE stop depending on CONFIG_EXPERT

2016-06-25 Thread Dan Williams
..@redhat.com> Reported-by: Jeff Moyer <jmo...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- mm/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/Kconfig b/mm/Kconfig index 3e2daef3c946..d109a7a0c1c4 100644 --- a/mm/Kconfig +++ b

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-06-27 Thread Dan Williams
On Mon, Jun 27, 2016 at 10:40 AM, Linda Knippers <linda.knipp...@hpe.com> wrote: > > On 6/24/2016 1:44 PM, Dan Williams wrote: >> QEMU 2.6 implements nascent support for nvdimm DSMs. Depending on >> configuration it may only implement the function0 dsm to indica

[PATCH v5 3/5] um: track 'parent' device in a local variable

2016-06-27 Thread Dan Williams
com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/um/drivers/ubd_kern.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index ef6b4d960bad..f3540270d096 100644 --- a/arch/um/drivers/ubd_kern

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-06-27 Thread Dan Williams
On Mon, Jun 27, 2016 at 11:47 AM, Linda Knippers <linda.knipp...@hpe.com> wrote: > > > On 6/27/2016 2:06 PM, Dan Williams wrote: >> On Mon, Jun 27, 2016 at 10:40 AM, Linda Knippers <linda.knipp...@hpe.com> >> wrote: >>> >>> On 6/24/2016 1:

[PATCH v5 0/5] Introduce device_add_disk() to kill gendisk.driverfs_dev

2016-06-27 Thread Dan Williams
build success notification from the kbuild robot. --- Dan Williams (5): block: introduce device_add_disk() mmc: move 'parent' tracking to mmc_blk_data um: track 'parent' device in a local variable block: convert to device_add_disk() block: remove ->driverfs_dev

Re: [ndctl PATCH 4/9] ndctl, list: allow limiting namespace listing

2016-06-27 Thread Dan Williams
On Mon, Jun 27, 2016 at 12:28 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > On 06/26, Dan Williams wrote: >> In addition to filtering by bus, dimm, and/or region, introduce >> -n/--namespace to limit the listing to the given namespace. >> >> Signed-

Re: [PATCH] ndctl: delete duplicate -v on "ndctl destroy-namespace --help" page

2016-06-27 Thread Dan Williams
On Mon, Jun 27, 2016 at 4:01 AM, Yi Zhang wrote: > "ndctl destroy-namespace --help" page display below two -v option: > [1]-v, --verbose > Emit debug messages for the namespace operation > [2]-v, --verbose > Emit debug messages for the namespace destruction

[ndctl PATCH] ndctl: update readme for vmalloc() based nfit_test

2016-06-27 Thread Dan Williams
In v4.8 when we have vmalloc() based nfit_test the test configuration no longer requires a CMA allocation. While we're updating the document, also refresh the configuration variables. Reported-by: Yigal Korman <yi...@plexistor.com> Signed-off-by: Dan Williams <dan.j.willi...@

[PATCH 0/2] nfit_test: convert to vmalloc()

2016-06-26 Thread Dan Williams
While backporting nfit_test to distro kernels a conflict between CMA and SWIOTLB was discovered. CMA requirements have also been a stumbling point for others trying to execute the tests. --- Dan Williams (2): libnvdimm, pmem: allow nfit_test to override pmem_direct_access() tools

[ndctl PATCH 5/9] ndctl: add libs dependency to spec file

2016-06-26 Thread Dan Williams
Otherwise ndctl may use an old version of ndctl-libs. The expectation is that installing an updated ndctl also includes all the capabilities of an updated libndctl. Reported-by: Jeff Moyer <jmo...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- ndctl.spec.in

[ndctl PATCH 9/9] test, libndctl: kill some dead code

2016-06-26 Thread Dan Williams
check_namespaces() used to do some i/o testing, but that's long since been replaced. Clean up some straggling statements. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- test/libndctl.c |3 --- 1 file changed, 3 deletions(-) diff --git a/test/libndctl.c b/test/libndctl.c

Re: [PATCH v2 16/17] x86/insn: remove pcommit

2016-07-22 Thread Dan Williams
On Tue, Jul 12, 2016 at 3:12 PM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Tue, Jul 12, 2016 at 7:57 AM, Peter Zijlstra <pet...@infradead.org> wrote: >> On Sat, Jul 09, 2016 at 08:25:54PM -0700, Dan Williams wrote: >>> The pcommit instruction is being dep

Re: btt ndctl question

2016-07-26 Thread Dan Williams
he btt only >> > shows a sector size. There >> > is no size value exposed by the btt sysfs information, which is >> > probably why it's not in ndctl. >> > >> > I know the size can be gotten from the block device but it looks >> > like an

Re: btt ndctl question

2016-07-26 Thread Dan Williams
or the btt. The btt only shows a >> sector size. There >> is no size value exposed by the btt sysfs information, which is probably why >> it's not in ndctl. >> >> I know the size can be gotten from the block device but it looks like an >> omission here. >&g

Re: btt ndctl question

2016-07-26 Thread Dan Williams
On Tue, Jul 26, 2016 at 2:41 PM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > On 07/26, Dan Williams wrote: >> On Tue, Jul 26, 2016 at 2:24 PM, Verma, Vishal L >> <vishal.l.ve...@intel.com> wrote: >> > On Tue, 2016-07-26 at 14:58 -0600, Vishal Verma wrote:

[PATCH v3] libnvdimm: introduce devm_nvdimm_memremap(), convert nfit_spa_map() users

2016-07-12 Thread Dan Williams
for the nd_blk_region.disable() callback. Note that the removal of nfit_spa_map() and related infrastructure is deferred to a later patch. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Change since v2: fix ARCH=um build error drivers/acpi/nfit.c | 14 +++-- drivers/nvdimm/Kconfig|2 - d

Re: [PATCH v2 2/3] nfit, libnvdimm: allow an ARS scrub to be triggered on demand

2016-07-21 Thread Dan Williams
On Thu, Jul 21, 2016 at 12:40 PM, Linda Knippers wrote: > On 07/20/2016 09:50 PM, Vishal Verma wrote: >> Normally, an ARS (Address Range Scrub) only happens at >> boot/initialization time. There can however arise situations where a >> bus-wide rescan is needed - notably,

Re: [PATCH v2 2/3] nfit, libnvdimm: allow an ARS scrub to be triggered on demand

2016-07-21 Thread Dan Williams
On Thu, Jul 21, 2016 at 12:55 PM, Linda Knippers <linda.knipp...@hpe.com> wrote: > > > On 7/21/2016 3:46 PM, Dan Williams wrote: >> On Thu, Jul 21, 2016 at 12:40 PM, Linda Knippers <linda.knipp...@hpe.com> >> wrote: >>> On 07/20/2016 09:50 PM, Vishal V

Re: [PATCH] nfit: Get rid of CONFIG_ACPI_NFIT_DEBUG

2016-07-28 Thread Dan Williams
On Thu, Jul 28, 2016 at 2:49 AM, Johannes Thumshirn wrote: > CONFIG_ACPI_NFIT_DEBUG is currently used to dump the buffers used in NFIT _DSM > calls. Within the statements guarded by CONFIG_ACPI_NFIT_DEBUG we use dynamic > debugging as well as print_hex_dump_debug(). Change the

Re: [BUG] kernel NULL pointer dereference observed during pmem btt switch test

2016-07-28 Thread Dan Williams
[ adding linux-block ] On Wed, Jul 27, 2016 at 8:20 PM, Yi Zhang wrote: > Hello everyone > > Could you help check this issue, thanks. > > Steps I used: > 1. Reserve 4*8G of memory for pmem by add kernel parameter "memmap=8G!4G > memmap=8G!12G memmap=8G!20G memmap=8G!28G" > 2.

Re: Subtle races between DAX mmap fault and write path

2016-07-27 Thread Dan Williams
[ Adding Eric ] On Wed, Jul 27, 2016 at 5:07 AM, Jan Kara wrote: > Hi, > > when testing my latest changes to DXA fault handling code I have hit the > following interesting race between the fault and write path (I'll show > function names for ext4 but xfs has the same issue AFAICT).

[PATCH v4 0/4] ARS rescanning triggered by latent errors or userspace

2016-07-23 Thread Dan Williams
or anyone more familiar with mce handling. --- Dan Williams (2): libnvdimm: register nvdimm_bus devices with an nd_bus driver nfit: move to nfit/ sub-directory Vishal Verma (2): nfit, libnvdimm: allow an ARS scrub to be triggered on demand nfit: do an ARS scrub on hittin

[PATCH v4 4/4] nfit: do an ARS scrub on hitting a latent media error

2016-07-23 Thread Dan Williams
Verma <vishal.l.ve...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit/Makefile |1 drivers/acpi/nfit/core.c| 26 +++-- drivers/acpi/nfit/mce.c | 89 +++ drivers/acpi/nfit/nfit.h|

[PATCH v4 2/4] nfit, libnvdimm: allow an ARS scrub to be triggered on demand

2016-07-23 Thread Dan Williams
re out what other sectors are bad, and thus potentially avoid triggering an mce on them in the future. Also provide a sysfs trigger to start a bus-wide scrub. Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> Signed-off-by: Dan Wil

[PATCH v5] nfit, libnvdimm: allow an ARS scrub to be triggered on demand

2016-07-24 Thread Dan Williams
re out what other sectors are bad, and thus potentially avoid triggering an mce on them in the future. Also provide a sysfs trigger to start a bus-wide scrub. Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com> Signed-off-by: Dan Wil

Re: [PATCH] libnvdimm-btt: Delete an unnecessary check before the function call "__nd_device_register"

2016-07-24 Thread Dan Williams
On Sun, Jul 24, 2016 at 2:16 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 24 Jul 2016 11:05:34 +0200 > > The __nd_device_register() function tests whether its argument is NULL > and then returns immediately. Thus

[PATCH 1/2] libnvdimm: move ->module to struct nvdimm_bus_descriptor

2016-07-21 Thread Dan Williams
Let the provider module be explicitly passed in rather than implicitly assumed by the module that calls nvdimm_bus_register(). This is in preparation for unifying the nfit and nfit_test driver teardown paths. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/

[PATCH 2/2] nfit, tools/testing/nvdimm/: unify shutdown paths

2016-07-21 Thread Dan Williams
rma <vishal.l.ve...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c | 36 ++-- tools/testing/nvdimm/test/nfit.c | 16 ++-- 2 files changed, 24 insertions(+), 28 deletions(-) diff --git

Re: [PATCH] block: remove BLK_DEV_DAX config option

2016-07-29 Thread Dan Williams
commit, removing the dead config option. > > Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> > Cc: Dave Hansen <dave.han...@linux.intel.com> > Cc: Dan Williams <dan.j.willi...@intel.com> Acked-by: Dan Williams <dan.j.willi...@intel.com>

Re: Subtle races between DAX mmap fault and write path

2016-07-29 Thread Dan Williams
On Thu, Jul 28, 2016 at 7:21 PM, Dave Chinner wrote: > On Thu, Jul 28, 2016 at 10:10:33AM +0200, Jan Kara wrote: >> On Thu 28-07-16 08:19:49, Dave Chinner wrote: [..] >> So DAX doesn't need flushing to maintain consistent view of the data but it >> does need flushing to make

Re: Subtle races between DAX mmap fault and write path

2016-07-29 Thread Dan Williams
On Fri, Jul 29, 2016 at 5:12 PM, Dave Chinner <da...@fromorbit.com> wrote: > On Fri, Jul 29, 2016 at 07:44:25AM -0700, Dan Williams wrote: >> On Thu, Jul 28, 2016 at 7:21 PM, Dave Chinner <da...@fromorbit.com> wrote: >> > On Thu, Jul 28, 2016 at 10:10:33AM +0200, Jan

Re: [BUG] kernel NULL pointer dereference observed during pmem btt switch test

2016-07-30 Thread Dan Williams
On Thu, Jul 28, 2016 at 8:50 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > [ adding linux-block ] > > On Wed, Jul 27, 2016 at 8:20 PM, Yi Zhang <yiz...@redhat.com> wrote: >> Hello everyone >> >> Could you help check this issue, thanks. >>

Re: Subtle races between DAX mmap fault and write path

2016-07-31 Thread Dan Williams
On Sun, Jul 31, 2016 at 9:07 PM, Dave Chinner wrote: > On Sun, Jul 31, 2016 at 08:13:23PM -0700, Keith Packard wrote: >> Dave Chinner writes: >> >> > So we'd see that from the point of view of a torn single sector >> > write. Ok, so we better limit DAX

Re: [PATCH] ndctl: fix --enable-destructive build failure

2016-07-29 Thread Dan Williams
On Fri, Jul 29, 2016 at 3:02 PM, Ross Zwisler wrote: > This commit: > > commit 0d119368385a ("ndctl: reorganize file structure, use per sub-directory > makefiles") > > reorganized the file structure & makefiles in ndctl, but broke builds that > used the

[ndctl PATCH] ndctl: --enable-destructive implies --enable-test

2016-07-29 Thread Dan Williams
Currently the build fails if --enable-destructive is specified without --enable-test, but --enable-destructive assumes that --enable-test is already specified. Just force --enable-test to satisfy the requirement. Reported-by: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-b

Re: [BUG] kernel NULL pointer dereference observed during pmem btt switch test

2016-07-31 Thread Dan Williams
On Sun, Jul 31, 2016 at 10:19 AM, yizhan <yiz...@redhat.com> wrote: > On 07/30/2016 11:52 PM, Dan Williams wrote: >> >> On Thu, Jul 28, 2016 at 8:50 AM, Dan Williams <dan.j.willi...@intel.com> >> wrote: >>> >>> [ adding linux-block ] >

[PATCH] block: fix bdi vs gendisk lifetime mismatch

2016-07-31 Thread Dan Williams
0xd8/0x100 [] device_create_vargs+0x1c/0x20 [] bdi_register+0x8c/0x180 [] bdi_register_dev+0x27/0x30 [] add_disk+0x175/0x4a0 Cc: <sta...@vger.kernel.org> Reported-by: Yi Zhang <yiz...@redhat.com> Tested-by: Yi Zhang <yiz...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi..

Re: [4.8 hang] xfstests generic/361 hangs on dax enabled filesystems

2016-08-02 Thread Dan Williams
On Tue, Aug 2, 2016 at 5:33 PM, Dave Chinner wrote: > Hi folks, > > Just hit a reproducable hang in generic/361. Essentially this on > a 8GB pmem device: > > mkfs.xfs -f /dev/pmem1 > mount -o dax /dev/pmem1 /mnt/scratch > xfs_io -f -c "truncate 1g" test.img > losetup -f

[PATCH] libnvdimm: fix SMART Health DSM payload definition

2016-08-11 Thread Dan Williams
oyls...@hpe.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Note, there's no urgency to get this into the kernel since the only consumer of it is userspace [1], and it can update in advance of this patch being merged upstream in v4.9. [1]: github.com/pmem/ndctl i

Re: [4.8 hang] xfstests generic/361 hangs on dax enabled filesystems

2016-08-03 Thread Dan Williams
On Wed, Aug 3, 2016 at 4:16 PM, Dave Chinner wrote: > On Wed, Aug 03, 2016 at 04:37:13PM -0600, Ross Zwisler wrote: >> On Wed, Aug 03, 2016 at 11:11:27AM -0600, Ross Zwisler wrote: >> > On Wed, Aug 03, 2016 at 10:33:54AM +1000, Dave Chinner wrote: >> > > Hi folks, >> > > >> >

[ndctl PATCH] ndctl, create-namespace: trap and report invalid sector-size values

2016-08-04 Thread Dan Williams
validate_namespace_options:437: region0: does not support btt sector_size 513 failed to reconfigure namespace Reported-by: Yi Zhang <yiz...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- ndctl/builtin-xaction-namespace.c | 40

Re: btt device node disappeared after configure with non support sector_size

2016-08-04 Thread Dan Williams
On Thu, Aug 4, 2016 at 2:15 AM, Yi Zhang wrote: > Hi folks, > > Seems I hit one issue that btt device node disappeared after configure with > non support sector_size, could you help confirm it? > > 4.7.0 > # ndctl create-namespace -f -e namespace0.0 --mode=sector -l 512 > { >

[PATCH] fs/char_dev: fix cdev_put() vs f_op->release() use-after-free

2016-08-10 Thread Dan Williams
erence before calling f_op->release(). Cc: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- fs/file_table.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index ad17e05ebf95..

[PATCH] tools/testing/nvdimm: fix SIGTERM vs hotplug crash

2016-08-10 Thread Dan Williams
/0x680 [] kthread+0xf3/0x110 [] ret_from_fork+0x1f/0x40 [] ? kthread_create_on_node+0x230/0x230 Cc: <sta...@vger.kernel.org> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- tools/testing/nvdimm/test/nfit.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/te

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-07-20 Thread Dan Williams
On Tue, Jul 19, 2016 at 3:53 PM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Tue, Jul 19, 2016 at 3:46 PM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: >> On Tue, Jul 19, 2016 at 01:01:16PM -0700, Dan Williams wrote: >>> On Tue, Jul 19, 2016 at 11:52

Re: [PATCH v2 2/3] nfit, libnvdimm: allow an ARS scrub to be triggered on demand

2016-07-21 Thread Dan Williams
t > media error, we should do a full rescan to figure out what other sectors > are bad, and thus potentially avoid triggering an mce on them in the > future. Also provide a sysfs trigger to start a bus-wide scrub. > > Cc: Dan Williams <dan.j.willi...@intel.com> > Cc: Rafael

Re: [PATCH v2] tools/testing/nvdimm: add virtual ramdisk range

2016-07-17 Thread Dan Williams
On Sun, Jul 17, 2016 at 2:36 AM, joeyli <j...@suse.com> wrote: > Hi Dan, > > On Fri, Jul 15, 2016 at 12:35:58PM -0700, Dan Williams wrote: >> Test the virtual disk ranges that platform firmware like EDK2/OVMF might >> emit. >> >> Cc: "Lee, Chun-Yi&quo

Re: [PATCH v2 1/2] nfit: fix _FIT evaluation memory leak

2016-07-18 Thread Dan Williams
On Sun, Jul 17, 2016 at 10:57 PM, Xiao Guangrong <guangrong.x...@intel.com> wrote: > > > On 07/16/2016 03:32 AM, Dan Williams wrote: >> >> acpi_evaluate_object() allocates memory. Free the buffer allocated >> during acpi_nfit_add(). Also, make it clear t

Re: [PATCH 2/3] nfit, libnvdimm: allow an ARS rescan to be triggered on demand

2016-07-19 Thread Dan Williams
t > media error, we should do a full rescan to figure out what other sectors > are bad, and thus potentially avoid triggering an mce on them in the > future. Also provide a sysfs trigger to start a bus-wide rescan. > > Cc: Dan Williams <dan.j.willi...@intel.com> > Cc: Rafael

Re: [PATCH 3/3] nfit: do an ARS rescan on hitting a latent media error

2016-07-19 Thread Dan Williams
ending > operations on them can be trapped early, avoiding machine checks. > > This is done by registering a callback function with the > x86_mce_decoder_chain and calling the new ars_rescan functionality with > the address in the mce notificatiion. > > Cc: Dan Williams &l

Re: [PATCH 1/3] pmem: clarify a debug print in pmem_clear_poison

2016-07-19 Thread Dan Williams
On Mon, Jul 18, 2016 at 5:44 PM, Vishal Verma wrote: > Prefix the sector number being cleared with a '0x' to make it clear that > this is a hex value. > > Signed-off-by: Vishal Verma > --- > drivers/nvdimm/pmem.c | 2 +- > 1 file changed, 1

Re: [PATCH 2/3] nfit, libnvdimm: allow an ARS rescan to be triggered on demand

2016-07-19 Thread Dan Williams
On Tue, Jul 19, 2016 at 10:45 AM, Vishal Verma <vishal.l.ve...@intel.com> wrote: > On 07/19, Dan Williams wrote: >> On Mon, Jul 18, 2016 at 5:44 PM, Vishal Verma <vishal.l.ve...@intel.com> >> wrote: >> > Normally, an ARS (Address Range Scrub) only happ

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-07-19 Thread Dan Williams
On Tue, Jul 19, 2016 at 11:50 AM, Linda Knippers <linda.knipp...@hpe.com> wrote: > > > On 7/19/2016 1:11 PM, Jerry Hoemann wrote: >> On Fri, Jun 24, 2016 at 10:44:25AM -0700, Dan Williams wrote: >>> QEMU 2.6 implements nascent support for nvdimm DSMs. Depending on

[ndctl PATCH] ndctl: permit NULL as a parameter to ndctl_cmd_unref

2016-07-19 Thread Dan Williams
Similar to libc free() allow NULL as a valid parameter to this freeing routine. This mirrors the behavior of the other *_unref() routines in the library. Cc: Tiffany Kasanicky <tiffany.j.kasani...@intel.com> Reported-by: Linda Knippers <linda.knipp...@hpe.com> Signed-off-by:

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-07-19 Thread Dan Williams
On Tue, Jul 19, 2016 at 3:46 PM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote: > On Tue, Jul 19, 2016 at 01:01:16PM -0700, Dan Williams wrote: >> On Tue, Jul 19, 2016 at 11:52 AM, Dan Williams <dan.j.willi...@intel.com> >> wrote: >> > On Tue, Jul 19, 2016 at 1

Re: [PATCH] acpi, nfit: fix acpi_check_dsm() vs zero functions implemented

2016-07-19 Thread Dan Williams
On Tue, Jul 19, 2016 at 11:52 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Tue, Jul 19, 2016 at 11:50 AM, Linda Knippers <linda.knipp...@hpe.com> > wrote: >> On 7/19/2016 1:11 PM, Jerry Hoemann wrote: [..] >>> As nfit_mem->family always equals NVDIMM

[PATCH v3 2/2] nfit: cleanup acpi_nfit_init calling convention

2016-07-19 Thread Dan Williams
Pass the nfit buffer as a parameter rather than hanging it off of acpi_desc. Reviewed-by: "Lee, Chun-Yi" <j...@suse.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Changes since v2: * Only context changes due to v3 of patch1 drivers/acpi/nfit

Re: [PATCH 1/2] nfit: fix _FIT evaluation memory leak

2016-07-15 Thread Dan Williams
On Fri, Jul 15, 2016 at 1:12 AM, Haozhong Zhang <haozhong.zh...@intel.com> wrote: > On 07/15/16 15:55, Haozhong Zhang wrote: >> On 07/14/16 20:28, Dan Williams wrote: >> > acpi_evaluate_object() allocates memory. Free the buffer allocated >> > during ac

Re: [PATCH 1/2] nfit: fix _FIT evaluation memory leak

2016-07-15 Thread Dan Williams
On Thu, Jul 14, 2016 at 10:47 PM, Xiao Guangrong <guangrong.x...@intel.com> wrote: > > > On 07/15/2016 11:28 AM, Dan Williams wrote: >> >> acpi_evaluate_object() allocates memory. Free the buffer allocated >> during acpi_nfit_add(). >> > > Dan, thanks f

[PATCH v2 2/2] nfit: cleanup acpi_nfit_init calling convention

2016-07-15 Thread Dan Williams
Pass the nfit buffer as a parameter rather than hanging it off of acpi_desc. Reviewed-by: "Lee, Chun-Yi" <j...@suse.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Changes since v1: * Reflowed based on fixups done to patch1, no other changes.

[PATCH v2] tools/testing/nvdimm: add virtual ramdisk range

2016-07-15 Thread Dan Williams
Test the virtual disk ranges that platform firmware like EDK2/OVMF might emit. Cc: "Lee, Chun-Yi" <j...@suse.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Changes since v1: * Move this test range to nfit_test.1 to not break the spa ordering expected by

[PATCH v2 1/2] nfit: fix _FIT evaluation memory leak

2016-07-15 Thread Dan Williams
ng <guangrong.x...@intel.com> Reported-by: Haozhong Zhang <haozhong.zh...@intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Change since v1: * Fix unitialized use of 'rc' (Haozhong) * Clarify that their is no use-after-free problem in acpi_nfit_notify() (X

[PATCH] tools/testing/nvdimm: add manufacturing_{date|location} dimm properties

2016-07-15 Thread Dan Williams
New for ACPI 6.1, these fields are used in the common dimm representation format defined by section 5.2.25.9 "NVDIMM representation format". Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- tools/testing/nvdimm/test/nfit.c | 54 +++---

Re: [PATCH 1/2] nfit: fix _FIT evaluation memory leak

2016-07-14 Thread Dan Williams
On Thu, Jul 14, 2016 at 10:15 PM, joeyli <j...@suse.com> wrote: > Hi Dan, > > On Thu, Jul 14, 2016 at 08:28:57PM -0700, Dan Williams wrote: >> acpi_evaluate_object() allocates memory. Free the buffer allocated >> during acpi_nfit_add(). >> >> Cc: <s

[PATCH 1/2] nfit: fix _FIT evaluation memory leak

2016-07-14 Thread Dan Williams
acpi_evaluate_object() allocates memory. Free the buffer allocated during acpi_nfit_add(). Cc: <sta...@vger.kernel.org> Cc: Vishal Verma <vishal.l.ve...@intel.com> Reported-by: Xiao Guangrong <guangrong.x...@intel.com> Reported-by: Haozhong Zhang <haozhong.zh...@intel.co

[PATCH 2/2] nfit: cleanup acpi_nfit_init calling convention

2016-07-14 Thread Dan Williams
Pass the nfit buffer as a parameter rather than hanging it off of acpi_desc. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c | 56 +- drivers/acpi/nfit.h |3 +- tools/testing/nvdimm/test/

Re: [PATCH v4] acpi, nfit: treat virtual ramdisk SPA as pmem region

2016-07-14 Thread Dan Williams
"flush > hint", > "interleave", or "control region" table. > > After testing on OVMF, pmem driver can support the region that it doesn't > assoicate to any NVDIMM mapping. So, treat VCD like pmem is a idea to get > a pmem block device that it contains iso. &

Re: [PATCH 1/2] libnvdimm: add missing macros

2016-07-08 Thread Dan Williams
On Fri, Jul 8, 2016 at 9:29 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > > This can't compile without these macros… Is this header really used by anyone? > Should it be removed, to avoid bit-rot? It's used by ndctl [1].

Re: [PATCH] dax: use devm_add_action_or_reset()

2016-07-06 Thread Dan Williams
Thanks, applied. On Mon, Jul 4, 2016 at 11:59 PM, Johannes Thumshirn wrote: > On Tue, Jul 05, 2016 at 11:20:07AM +0530, Vikas C Sajjan wrote: >> If devm_add_action() fails, we are explicitly calling the cleanup to free >> the resources allocated. Use the helper

Re: [PATCH] nfit: use devm_add_action_or_reset()

2016-07-06 Thread Dan Williams
Thanks, applied. On Mon, Jul 4, 2016 at 12:54 AM, joeyli wrote: > On Mon, Jul 04, 2016 at 10:02:51AM +0530, Vikas C Sajjan wrote: >> If devm_add_action() fails, we are explicitly calling the cleanup to free >> the resources allocated. Lets use the helper devm_add_action_or_reset()

[PATCH v2 02/17] nfit: don't override return value of nfit_mem_init

2016-07-09 Thread Dan Williams
We were needlessly converting nfit_mem_init() errors to -ENOMEM. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c index d79837b9d07e..f8c1a8

[PATCH v2 03/17] libnvdimm: introduce devm_nvdimm_memremap(), convert nfit_spa_map() users

2016-07-09 Thread Dan Williams
for the nd_blk_region.disable() callback. Note that the removal of nfit_spa_map() and related infrastructure is deferred to a later patch. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c | 14 +++-- drivers/nvdimm/core.c

[PATCH v2 06/17] tools/testing/nvdimm: simulate multiple flush hints per-dimm

2016-07-09 Thread Dan Williams
Sample nfit data to test the kernel's handling of the multiple flush-hint case. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- tools/testing/nvdimm/test/nfit.c | 55 +++--- 1 file changed, 33 insertions(+), 22 deletions(-) diff --git a/tools/t

[PATCH v2 05/17] libnvdimm, nfit: move flush hint mapping to region-device driver-data

2016-07-09 Thread Dan Williams
to communicate more information to the nvdimm core to facilitate this mapping, namely each dimm object now carries an array of flush hint address resources. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c | 21 +++ drivers/acpi/

[PATCH v2 04/17] libnvdimm, nfit: remove nfit_spa_map() infrastructure

2016-07-09 Thread Dan Williams
Now that all shared mappings are handled by devm_nvdimm_memremap() we no longer need nfit_spa_map() nor do we need to trigger a callback to the bus provider at region disable time. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/acpi/nfit.c

[PATCH v2 07/17] libnvdimm: keep region data alive over namespace removal

2016-07-09 Thread Dan Williams
nd_region device driver data will be used in the namespace i/o path. Re-order nd_region_remove() to ensure this data stays live across namespace device removal Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/nvdimm/region.c |3 ++- 1 file changed, 2 insertions

[PATCH v2 09/17] libnvdimm: cycle flush hints

2016-07-09 Thread Dan Williams
addresses for each cpu to have one, keep a per-cpu index of the last used hint, hash it with current pid, and assume that access pattern and scheduler randomness will keep the flush-hint usage somewhat staggered across cpus. Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-b

[PATCH v2 14/17] pmem: kill wmb_pmem()

2016-07-09 Thread Dan Williams
All users have been replaced with flushing in the pmem driver. Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/x86/include/asm/pmem.h | 36 ++--- include/linux/pmem.h

[PATCH v2 16/17] x86/insn: remove pcommit

2016-07-09 Thread Dan Williams
.shish...@linux.intel.com> Cc: Borislav Petkov <b...@suse.de> Cc: Andy Lutomirski <l...@kernel.org> Cc: Xiao Guangrong <guangrong.x...@linux.intel.com> Cc: Adrian Hunter <adrian.hun...@intel.com> Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-b

[PATCH v2 13/17] libnvdimm, pmem: use nvdimm_flush() for namespace I/O writes

2016-07-09 Thread Dan Williams
nsio_rw_bytes() is used to write info block metadata to the namespace, so it should trigger a flush after every write. Replace wmb_pmem() with nvdimm_flush() in this path. Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- dr

[PATCH v2 12/17] fs/dax: remove wmb_pmem()

2016-07-09 Thread Dan Williams
Flushing posted-write queues is now deferred to REQ_FLUSH context, or otherwise handled by an ADR event at the platform level. Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- fs/dax.c |7 +-- 1 file changed, 1 ins

[PATCH v2 15/17] Revert "KVM: x86: add pcommit support"

2016-07-09 Thread Dan Williams
linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- arch/x86/include/asm/vmx.h |1 - arch/x86/include/uapi/asm/vmx.h |4 +--- arch/x86/kvm/cpuid.c|2 +- arch/x86/kvm/cpuid.h|8 arch/x86/kvm/v

[PATCH v2 11/17] libnvdimm, pmem: flush posted-write queues on shutdown

2016-07-09 Thread Dan Williams
Commit writes to media on system shutdown or pmem driver unload. Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/nvdimm/bus.c | 16 drivers/nvdimm/pmem.c |8 include/linux/nd.h|1 + 3 files changed, 25 insertions(+) diff

[ndctl PATCH v3] ndctl, create-namespace: trap and report invalid sector-size values

2016-08-04 Thread Dan Williams
validate_namespace_options:437: region0: does not support btt sector_size 513 failed to reconfigure namespace Reported-by: Yi Zhang <yiz...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Change in v3: fix a compile warning ndctl/builtin-xaction-namesp

Re: [ndctl PATCH] ndctl, create-namespace: trap and report invalid sector-size values

2016-08-04 Thread Dan Williams
On Thu, Aug 4, 2016 at 8:32 AM, Dan Williams <dan.j.willi...@intel.com> wrote: > While the kernel will prevent invalid configurations, the user > experience of a kernel error message and disabling of the namespace is > too harsh. Trap and report these attempts to make create-namesp

[ndctl PATCH v2] ndctl, create-namespace: trap and report invalid sector-size values

2016-08-04 Thread Dan Williams
validate_namespace_options:437: region0: does not support btt sector_size 513 failed to reconfigure namespace Reported-by: Yi Zhang <yiz...@redhat.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- Changes in v2 to address unit test breakage: 1/ stop setting a default

  1   2   3   4   5   6   7   8   9   10   >